From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2C366436B3;
	Sat,  9 Dec 2023 08:19:41 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CD5A4402F1;
	Sat,  9 Dec 2023 08:19:40 +0100 (CET)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by mails.dpdk.org (Postfix) with ESMTP id B2BAF402DF
 for <dev@dpdk.org>; Sat,  9 Dec 2023 08:19:39 +0100 (CET)
Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SnKBs44wZz14Lmn;
 Sat,  9 Dec 2023 15:19:33 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.35; Sat, 9 Dec 2023 15:19:36 +0800
Subject: Re: [RFC v2 14/14] lib: use per line logging in helpers
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
CC: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
 <bruce.richardson@intel.com>, <stephen@networkplumber.org>,
 <mb@smartsharesystems.com>, Nicolas Chautru <nicolas.chautru@intel.com>,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, Cristian Dumitrescu
 <cristian.dumitrescu@intel.com>, Fan Zhang <fanzhang.oss@gmail.com>, Ashish
 Gupta <ashish.gupta@marvell.com>, Akhil Goyal <gakhil@marvell.com>, Kevin
 Laatz <kevin.laatz@intel.com>, Andrew Rybchenko
 <andrew.rybchenko@oktetlabs.ru>, Jerin Jacob <jerinj@marvell.com>, Erik
 Gabriel Carrillo <erik.g.carrillo@intel.com>, Elena Agostini
 <eagostini@nvidia.com>, Kiran Kumar K <kirankumark@marvell.com>, Nithin
 Dabilpuram <ndabilpuram@marvell.com>, Zhirun Yan <zhirun.yan@intel.com>,
 Yipeng Wang <yipeng1.wang@intel.com>, Sameh Gobriel
 <sameh.gobriel@intel.com>, Srikanth Yalavarthi <syalavarthi@marvell.com>,
 Jasvinder Singh <jasvinder.singh@intel.com>, Pavan Nikhilesh
 <pbhagavatula@marvell.com>, Reshma Pattan <reshma.pattan@intel.com>, Anatoly
 Burakov <anatoly.burakov@intel.com>, David Hunt <david.hunt@intel.com>,
 Sivaprasad Tummala <sivaprasad.tummala@amd.com>, Sachin Saxena
 <sachin.saxena@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Honnappa
 Nagarahalli <honnappa.nagarahalli@arm.com>, Ori Kam <orika@nvidia.com>, Ciara
 Power <ciara.power@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbox@nvidia.com>
References: <20231117131824.1977792-1-david.marchand@redhat.com>
 <20231208145950.2184940-1-david.marchand@redhat.com>
 <20231208145950.2184940-15-david.marchand@redhat.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <f2170b5a-8961-35c2-c5e1-c3bd33e72fda@huawei.com>
Date: Sat, 9 Dec 2023 15:19:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20231208145950.2184940-15-david.marchand@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

For lib/dmadev part
Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>

On 2023/12/8 22:59, David Marchand wrote:
> Use RTE_LOG_LINE in existing macros that append a \n.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since RFC v1:
> - converted all logging helpers in lib/,
> 
> ---
>  lib/bbdev/rte_bbdev.c                      |  5 +++--
>  lib/bpf/bpf_impl.h                         |  2 +-
>  lib/cfgfile/rte_cfgfile.c                  |  4 ++--
>  lib/compressdev/rte_compressdev_internal.h |  5 +++--
>  lib/cryptodev/rte_cryptodev.h              | 16 +++++++---------
>  lib/dmadev/rte_dmadev.c                    |  6 ++++--
>  lib/ethdev/rte_ethdev.h                    |  3 +--
>  lib/eventdev/eventdev_pmd.h                |  8 ++++----
>  lib/eventdev/rte_event_timer_adapter.c     | 17 ++++++++++-------
>  lib/gpudev/gpudev.c                        |  6 ++++--
>  lib/graph/graph_private.h                  |  5 +++--
>  lib/member/member.h                        |  4 ++--
>  lib/metrics/rte_metrics_telemetry.c        |  4 ++--
>  lib/mldev/rte_mldev.h                      |  5 +++--
>  lib/net/rte_net_crc.c                      |  8 ++++----
>  lib/node/node_private.h                    |  6 ++++--
>  lib/pdump/rte_pdump.c                      |  5 ++---
>  lib/power/power_common.h                   |  2 +-
>  lib/rawdev/rte_rawdev_pmd.h                |  4 ++--
>  lib/rcu/rte_rcu_qsbr.h                     |  8 +++-----
>  lib/regexdev/rte_regexdev.h                |  3 +--
>  lib/stack/stack_pvt.h                      |  4 ++--
>  lib/telemetry/telemetry.c                  |  4 +---
>  lib/vhost/vhost.h                          |  8 ++++----
>  lib/vhost/vhost_crypto.c                   |  6 +++---
>  25 files changed, 76 insertions(+), 72 deletions(-)
> 

...