From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2F12945A58;
	Wed,  9 Oct 2024 03:02:07 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AE564402B3;
	Wed,  9 Oct 2024 03:02:06 +0200 (CEST)
Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])
 by mails.dpdk.org (Postfix) with ESMTP id 809374025C
 for <dev@dpdk.org>; Wed,  9 Oct 2024 03:02:04 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.163.17])
 by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4XNZMF4bCjz2DcvC;
 Wed,  9 Oct 2024 09:00:57 +0800 (CST)
Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10])
 by mail.maildlp.com (Postfix) with ESMTPS id 643FD1A0188;
 Wed,  9 Oct 2024 09:02:02 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.39; Wed, 9 Oct 2024 09:02:02 +0800
Message-ID: <f22f5f89-3a99-46cf-9dcf-61beec71f1b3@huawei.com>
Date: Wed, 9 Oct 2024 09:02:01 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/3] app/testpmd: add support for querying TM nodes
To: Bruce Richardson <bruce.richardson@intel.com>, <dev@dpdk.org>
CC: <ferruh.yigit@amd.com>
References: <20241008105350.1396216-1-bruce.richardson@intel.com>
 <20241008144320.1632138-1-bruce.richardson@intel.com>
 <20241008144320.1632138-4-bruce.richardson@intel.com>
Content-Language: en-US
From: fengchengwen <fengchengwen@huawei.com>
In-Reply-To: <20241008144320.1632138-4-bruce.richardson@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Please update the testpmd doc, with that added,
Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/10/8 22:43, Bruce Richardson wrote:
> Support use of the rte_tm_node_query API to print out details about
> previously added TM nodes in testpmd.
> 
> Example output, configuring three nodes, and then printing the details:
> 
> testpmd> add port tm nonleaf node 0 100 -1 0 1 0 -1 1 0 0
> testpmd> add port tm nonleaf node 0 90 100 0 1 1 -1 1 0 0
> testpmd> add port tm leaf node    0 0   90 0 1 2 -1 0 0xffffffff 0 0
> testpmd>
> testpmd> show port tm node 0 100
> Port 0 TM Node 100
>   Parent Node ID: <NULL>
>   Level ID: 0
>   Priority: 0
>   Weight: 0
>   Shaper Profile ID: <none>
>   Shared Shaper IDs: <none>
>   Stats Mask: 0
>   Nonleaf Node Parameters
>     Num Strict Priorities: 1
>     WFQ Weights Mode: WFQ
> testpmd> show port tm node 0 90
> Port 0 TM Node 90
>   Parent Node ID: 100
>   Level ID: 1
>   Priority: 0
>   Weight: 1
>   Shaper Profile ID: <none>
>   Shared Shaper IDs: <none>
>   Stats Mask: 0
>   Nonleaf Node Parameters
>     Num Strict Priorities: 1
>     WFQ Weights Mode: WFQ
> testpmd> show port tm node 0 0
> Port 0 TM Node 0
>   Parent Node ID: 90
>   Level ID: 2
>   Priority: 0
>   Weight: 1
>   Shaper Profile ID: <none>
>   Shared Shaper IDs: <none>
>   Stats Mask: 0
>   Leaf Node Parameters
>     CMAN Mode: Tail Drop
>     WRED Profile ID: <none>
>     Shared WRED Context Ids: <none>
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  app/test-pmd/cmdline.c    |   1 +
>  app/test-pmd/cmdline_tm.c | 131 ++++++++++++++++++++++++++++++++++++++
>  app/test-pmd/cmdline_tm.h |   1 +
>  3 files changed, 133 insertions(+)
> 

...