From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 113692C55 for ; Wed, 29 Nov 2017 20:14:32 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2017 11:14:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,338,1508828400"; d="scan'208";a="7335947" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.149]) ([10.241.225.149]) by FMSMGA003.fm.intel.com with ESMTP; 29 Nov 2017 11:14:31 -0800 To: Rongqiang XIE , jingjing.wu@intel.com, declan.doherty@intel.com, thomas@monjalon.net Cc: dev@dpdk.org References: <1503983327-2017-1-git-send-email-xie.rongqiang@zte.com.cn> From: Ferruh Yigit Message-ID: Date: Wed, 29 Nov 2017 11:14:31 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1503983327-2017-1-git-send-email-xie.rongqiang@zte.com.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd:add bond type description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 19:14:33 -0000 On 8/28/2017 10:08 PM, Rongqiang XIE wrote: > In function cmd_show_bonding_config_parsed() used number represent > the bond type,in order more detailed,add bond type description > otherwise we may confused about the number type. > And also,the primary port just use in mode active backup and tlb, > so,when the mode is active backup or tlb show the primary port info > may be more appropriate. Hi Rongqiang, Sorry for the delay, this is waiting maintainer Ack for a while. I hope you are still interested in patch, there is already outstanding comment from Krill and I would also ask to split this into two patches, the bonding mode string one and bonding mode check (backup || tlb) one. Thanks, ferruh > > Signed-off-by: Rongqiang XIE <...>