From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yunjian Wang <wangyunjian@huawei.com>,
dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com
Cc: xudingke@huawei.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] net/virtio-user: fix return value of tap offload sets not checked
Date: Wed, 15 Jan 2020 12:17:49 +0100 [thread overview]
Message-ID: <f277e65d-c840-2c6c-9494-3eff7c5518f5@redhat.com> (raw)
In-Reply-To: <1578901231-16920-1-git-send-email-wangyunjian@huawei.com>
On 1/13/20 8:40 AM, Yunjian Wang wrote:
> The function vhost_kernel_tap_set_offload() could return errors,
> the return value need to be checked. And there is no need to fail
> when error is -ENOTSUP.
>
> Fixes: 1db4d2330bc8 ("net/virtio-user: check negotiated features before set")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v3:
> * Fix return value check incorrectly in v2
> v2:
> * No need to fail when error is -ENOTSUP.
> ---
> drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Applied to dpdk-next-virtio/master
Thanks,
Maxime
prev parent reply other threads:[~2020-01-15 11:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 7:40 Yunjian Wang
2020-01-14 2:14 ` Tiwei Bie
2020-01-15 11:17 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f277e65d-c840-2c6c-9494-3eff7c5518f5@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).