From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Sivaprasad Tummala <Sivaprasad.Tummala@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
Xiaolong Ye <xiaolong.ye@intel.com>
Cc: dev@dpdk.org, fbl@sysclose.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] vhost: fix mbuf allocation failures
Date: Fri, 15 May 2020 09:29:40 +0200 [thread overview]
Message-ID: <f2808fc2-6c4f-8ce9-bd6a-7448b08d69c4@redhat.com> (raw)
In-Reply-To: <20200508111751.82341-1-Sivaprasad.Tummala@intel.com>
On 5/8/20 1:17 PM, Sivaprasad Tummala wrote:
> vhost buffer allocation is successful for packets that fit
> into a linear buffer. If it fails, vhost library is expected
> to drop the current packet and skip to the next.
>
> The patch fixes the error scenario by skipping to next packet.
> Note: Drop counters are not currently supported.
>
> Fixes: c3ff0ac70acb ("vhost: improve performance by supporting large buffer")
> Cc: fbl@sysclose.org
> Cc: stable@dpdk.org
>
> v3:
> * fixed review comments - Flavio Leitner
>
> v2:
> * fixed review comments - Maxime Coquelin
> * fixed mbuf alloc errors for packed virtqueues - Maxime Coquelin
> * fixed mbuf copy errors - Flavio Leitner
>
> Signed-off-by: Sivaprasad Tummala <Sivaprasad.Tummala@intel.com>
> ---
> lib/librte_vhost/virtio_net.c | 70 +++++++++++++++++++++++++++--------
> 1 file changed, 55 insertions(+), 15 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2020-05-15 7:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 9:52 [dpdk-dev] [PATCH v1] " Sivaprasad Tummala
2020-04-29 8:43 ` Maxime Coquelin
2020-04-29 17:35 ` Flavio Leitner
2020-04-30 7:13 ` Tummala, Sivaprasad
2020-05-04 17:11 ` [dpdk-dev] [PATCH v2] vhost: fix mbuf alloc failure Sivaprasad Tummala
2020-05-04 19:32 ` Flavio Leitner
2020-05-05 5:48 ` Tummala, Sivaprasad
2020-05-05 8:20 ` Maxime Coquelin
2020-05-05 11:56 ` Tummala, Sivaprasad
2020-05-08 11:17 ` [dpdk-dev] [PATCH v3] vhost: fix mbuf allocation failures Sivaprasad Tummala
2020-05-15 7:29 ` Maxime Coquelin [this message]
2020-05-15 8:36 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2808fc2-6c4f-8ce9-bd6a-7448b08d69c4@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=Sivaprasad.Tummala@intel.com \
--cc=dev@dpdk.org \
--cc=fbl@sysclose.org \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).