From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A81D7433EC;
	Tue, 28 Nov 2023 04:33:50 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7E019402BF;
	Tue, 28 Nov 2023 04:33:50 +0100 (CET)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 3FBE04029E
 for <dev@dpdk.org>; Tue, 28 Nov 2023 04:33:48 +0100 (CET)
Received: from kwepemd100004.china.huawei.com (unknown [172.30.72.55])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SfShq629szvRBQ;
 Tue, 28 Nov 2023 11:33:15 +0800 (CST)
Received: from [10.67.121.175] (10.67.121.175) by
 kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.2.1258.28; Tue, 28 Nov 2023 11:33:45 +0800
Message-ID: <f2a095f1-f2e8-f155-70f3-78496ce7e22d@huawei.com>
Date: Tue, 28 Nov 2023 11:33:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 0/3] fix some bug for hns3
To: Ferruh Yigit <ferruh.yigit@amd.com>, Dengdui Huang
 <huangdengdui@huawei.com>, <dev@dpdk.org>, Thomas Monjalon
 <thomas@monjalon.net>, David Marchand <david.marchand@redhat.com>
CC: <stephen@networkplumber.org>, <lihuisong@huawei.com>,
 <liuyonglong@huawei.com>, <fengchengwen@huawei.com>
References: <20231127133903.1138657-1-huangdengdui@huawei.com>
 <47f2da46-e0b8-799a-258d-45f2928db132@huawei.com>
 <a9423490-02d7-41b6-96f6-e8f4633e4317@amd.com>
From: Jie Hai <haijie1@huawei.com>
In-Reply-To: <a9423490-02d7-41b6-96f6-e8f4633e4317@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.121.175]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
 kwepemd100004.china.huawei.com (7.221.188.31)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2023/11/28 2:33, Ferruh Yigit wrote:
> On 11/27/2023 1:55 PM, Jie Hai wrote:
>> On 2023/11/27 21:39, Dengdui Huang wrote:
>>> Dengdui Huang (3):
>>>     net/hns3: fix reset detect be ignored
>>>     net/hns3: fix VF wrong clear reset status
>>>     net/hns3: fix the VF reset interrupted possibly
>> Hi, Dengdui,
>>
>> Good fix.
>> For the patchset,
>> Acked-by: Jie Hai <haijie1@huawei.com>
>>
> 
> 
> Hi Jie, Dengdui, is this set for this release, which is a few days away?
> My suggestion is to wait next version as issues doesn't look critical.
> 
> 
> I applied set to next-net, but leaving decision to pull it for the
> release or not to Thomas/David.
> 
> Applied to dpdk-next-net/main, thanks.
> 
Hi, Ferruh, Thomas and David,

I'm sorry that this problem is a little serious.

a) Without [PATCH 2/3], when the VF executes the 
hns3_clear_reset_event(), unexpected memory is written.
As a result, unexpected errors occur in the program or even the app may 
crash.
b) Without [PATCH 3/3], there is a low probability that the app is 
unavailable after the FLR reset is done.
c) In addition, some LTS versions have the same problem.

Therefore, we hope that the problem can be solved in the current version.

Thanks,
Jie Hai
> .