From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 365F2A0A0F; Thu, 8 Apr 2021 01:13:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADAD8141057; Thu, 8 Apr 2021 01:13:41 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 80269141055 for ; Thu, 8 Apr 2021 01:13:39 +0200 (CEST) IronPort-SDR: jQl2FMVuZADbrxiCxkWjnuYCsNua5aoU+mls5sdlRz2ojZqRsqiWeIFJJIxq5Mam+W5WYE9a3L I3aRECVuUKsw== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="172889342" X-IronPort-AV: E=Sophos;i="5.82,204,1613462400"; d="scan'208";a="172889342" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 16:13:38 -0700 IronPort-SDR: eWqSe7lKXF7bM/K+sv5m23WP2fqSjz3ucnZWH7voOL4tvs/4zeczty4AaieZjBq1FOH46Ahufd rYm2LnUJ8yQg== X-IronPort-AV: E=Sophos;i="5.82,204,1613462400"; d="scan'208";a="396840380" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.202.196]) ([10.213.202.196]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 16:13:36 -0700 To: Salem Sol , dev@dpdk.org Cc: Jiawei Wang , Ori Kam , Xiaoyun Li References: <20210404094910.95413-2-salems@nvidia.com> <20210407114815.2423-1-salems@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 8 Apr 2021 00:13:32 +0100 MIME-Version: 1.0 In-Reply-To: <20210407114815.2423-1-salems@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [v5 1/6] app/testpmd: prepare storing VXLAN/NVGRE encap data globally X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/7/2021 12:48 PM, Salem Sol wrote: > From: Jiawei Wang > > With the current code the VXLAN/NVGRE parsing routine > stored the configuration of the header on stack, this > might lead to overwriting the data on the stack. > > Currently having VXLAN/NVGRE encap as sample actions > is done using RAW_ENCAP, for example: > 1. set raw_encap 1 eth src.../ vxlan vni.../ ipv4.../ ... > set sample_actions 0 raw_encap / port_id id 0 / end > flow create 0 ... pattern eth / end actions > sample ration 1 index 0 / jump group 1 / end > > The goal is to utilize the rte_flow_action_vxlan_encap > and rte_flow_action_nvgre_encap for sample actions. > > This patch prepares storing the external data of vxlan and > nvgre encap into global data as a pre-step to supporting > vxlan and nvgre encap as a sample actions. > > Signed-off-by: Jiawei Wang For testpmd patches in set, Reviewed-by: Ferruh Yigit Moved Slava's ack from previous version for mlx5 patches, Acked-by: Viacheslav Ovsiienko Series applied to dpdk-next-net/main, thanks.