From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0083.outbound.protection.outlook.com [104.47.0.83]) by dpdk.org (Postfix) with ESMTP id B35411AFFF for ; Mon, 16 Apr 2018 13:41:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Qx1H0FjodtYscvtEBzms6HXptJzRyGKbLC6ilEa22/c=; b=uQnvb9ax6CDvXK4K+25JWQ4a+nrRxqVhhpp+FaiXvRVB5I3JSHUwNZQ52HAv7avNH4CNlAFPhw0fA+1yDoULbXLNKuIy1bZlO+jp7Fir11rwTDX6BtR7dpxXmCXdPjxN4BonM0ODW39qJbPPypy1hd1btQjC1nYX8yJtW45C1IA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by HE1PR0402MB2777.eurprd04.prod.outlook.com (2603:10a6:3:d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.14; Mon, 16 Apr 2018 11:41:45 +0000 To: Nipun Gupta Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, dev@dpdk.org References: <1523114224-9852-1-git-send-email-nipun.gupta@nxp.com> <1523114224-9852-3-git-send-email-nipun.gupta@nxp.com> From: Shreyansh Jain Message-ID: Date: Mon, 16 Apr 2018 17:28:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1523114224-9852-3-git-send-email-nipun.gupta@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BMXPR01CA0003.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:d::13) To HE1PR0402MB2777.eurprd04.prod.outlook.com (2603:10a6:3:d4::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2777; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2777; 3:cuHT8QLfXhWXh8cEyGQ0qGICwiPA78B3SfF2iY3Gqu0UTU91fwo4RLqbXZibah5G9cXrAOaINijtobDcZ4Kni9edAbmjcCw/3zFcLorAGT0R42qWdRPlIyWob52MrluLTeEQdj4QpiMNBBg2TK7yoyFzYzzqf6VEIm9D+HsffaNJCw9AtdtFDr/5pM4KEcbXeZiWvh2xHO1Hdx4uNWa3pt77ADfk/jmXlo8vGsjXOA/oE1aIVOfc1fN9awczsieo; 25:GZBZPbHYU2hGtb11LID/JKgpFTJBEb1/v1boCnR+Ncj9ckuIqBDeGYzSSuH/w3FQ33HzWHYASbfdJT382i4d2uM00pZG+8+Yrq1/1AQoHFzPYnsP4M/B5RROhtIcApEgP72fH8ahuEnOAfLJpXun4BbWM3Gru1rwzsSDzsx17XDXj6WISmPtdPbISim2bzB4IfJCXXWn59cq4RxfQ7cqSEiyiImrcyfnecs5NJQ8tDkUDVDtmKro9CLFsM8Vv4GNrNnIkTR8DOCj/r19MWmdSylMUcIL27kKixMYieY7J6/bEywsEjk1U6z+4xOUd/fVnFFkKiuTu4xSuhVqNXE0vg==; 31:rEDOdLVS2UpE6Kgi6UIjQCjHScpFwJMD7UySw9Yx5U/8uCgSZM69lJbITqyHRH5NRvSgRJDsBWpbwdP8v6rjNSkpAgeqD2NEELTRZbXXFATr7yEa0egBhs8i11MkPkdrZL2E4Qg3QkMqkfMggrhNP3uwbFzc823Uhsd7xfv2VcO/c5Swx8S76n/6qiYT5hIg+R/h5tMZLP9hhZIx6puUJ3p8gWN+WLzY6vYzXgYr5P4= X-MS-TrafficTypeDiagnostic: HE1PR0402MB2777: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2777; 20:xt5N0Y2V/KhVF9sbBVC4w0n55MumCZ3jyCrI4Pa344v0vUkdN8Z8Xtj9NDHT1oz42DYmSMYj/PsHIMBrUrHO4HVgBSerizjGbRLuxamF6I0JnNI6N8iPITYaslDTa+IlRz8+9OfSHQkqyn6JcXvnv8esgaHAu2IwKxeaAiZcSo3Zcr0gP8k/jaTi6UIGp1oiuAsXijmmQ3ynG0asRkBv92gCbw718rlbmU9ouFhw0Lz13bNr4AuBX91aL+9fRn++esRniZRPeMmk24qlb9kqyTEUe0ozsPSoHvLAQ+4Z8qPUY+RZlifizCppmt3VE4Qd/DL02eqFwMigCsoljSnuhhWmKW9PzRMXrwheQK2xHlu8N4fs81gEIrotQRxdgcB/J4umZZ5jjW4iR7NMjcsJXVguBLLuKuTGb+9J3t3BwSzKIsGMtJ6wK4d+WzIEf2K1Ap+qjq+4jaB1JmqVfzifpyIPGFQ6e1GfYM/TzK5RPT4y6D9X8LLgh7QOonlLhRcz; 4:xhyQvfVITA7nEmZrsjQE6KbyHsuu76ZN4OzlLpBBrLomf3JMwQHDGx8zbIG08cDZVuMjaHh3PWsEzGPSDd7S5076RWvCwGyvb2VjtnC+iVwQESq4f8qkFpdwVY/Eq51eai3ucFmIkYSQej3ShQBZru5SzzTMN+6PLCeh5tpMKRwaiL0ZTCRbRwN1CLPEj9JdVGWIfMJy5jhiPvG0o+C3Crq+i1gj+8W08EXRWiiQNQASdZMi5LzjUwOAU3zs0lHNJ8YL2xLikQZAXBftdPaX9UzEe3/tQrhgQQ3zvdnffuXPeOM/xRD5d9HFrOlxEZ/O X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231232)(944501327)(52105095)(93006095)(93001095)(6055026)(6041310)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR0402MB2777; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2777; X-Forefront-PRVS: 0644578634 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(39860400002)(396003)(376002)(39380400002)(366004)(189003)(199004)(4326008)(186003)(106356001)(26005)(77096007)(47776003)(5009440100003)(25786009)(31686004)(68736007)(6862004)(230700001)(55236004)(386003)(6486002)(478600001)(2906002)(6116002)(3846002)(31696002)(97736004)(6666003)(66066001)(36756003)(8676002)(44832011)(81166006)(2616005)(53936002)(81156014)(446003)(956004)(11346002)(476003)(7736002)(6246003)(65806001)(6636002)(229853002)(8936002)(65826007)(5660300001)(486006)(305945005)(50466002)(76176011)(64126003)(37006003)(65956001)(67846002)(575784001)(86362001)(23676004)(2486003)(52116002)(16576012)(316002)(52146003)(16526019)(58126008)(105586002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2777; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA0MDJNQjI3Nzc7MjM6V1VXYmIyYUJTTm1QUzZFdEo4QmlqTGdq?= =?utf-8?B?cWFmSWVKY1pXL0h5YXlZWElpSElwdWJuSVNUcEkweEtqcGlGZlAzMUg2c3Zw?= =?utf-8?B?K24zY0UydG11cFRkR2dGN3E0L25pS3ROR0Jxdzh5ZHF5Ym55MXdBMWE0djVG?= =?utf-8?B?Vm04bFBxVXc4SVFvV1hEVERnRXhWMEYyMXpJbkZ3dkRaR2k2QWRzV1dxRlha?= =?utf-8?B?VVRYZUhlSlJZM2EyOEZIMWQzRk5ITkNYZ3QyNFdZK2dld3ZGNzF2cXVKb1Q4?= =?utf-8?B?YUlrNzIrZVhVVHVvQ0ZWQTZPWjNEeUppazFaUDA1MmZTQXpvUTRvK3ZoNzUy?= =?utf-8?B?MXJYdVFKekpKbDZacCt1Rjd5Smd3cjd3ZHk2RVhFemswSjhzamk4U3ppQVZG?= =?utf-8?B?ZDJPK2V4TXc4TVRDTW5JZElKQmFoSXJNYlJib3NuR2hGYU85bldtNytKREhP?= =?utf-8?B?OC9FRTVSODRUeTlHbFlzVjNRaE5uMk1TckpUZnY3U3JJblEvcENiKzRKRDRj?= =?utf-8?B?VHRYckdwNEl2R2NqOEJpY0svT2pTY2trUm13M3RHRXJmNUJqVXlUSDBtUnNR?= =?utf-8?B?L0MxWjlocVJCaHdHOWRMdGVWcVZ3TGl2WC9YOUFPM3VrU3NWdWdSMXRJUWdN?= =?utf-8?B?b2cwNEFPUm90Z0ZQeWRwV2gyZE5qTXNrR1hkaDc0d1ZlVnVJWnFJVGJGS1A5?= =?utf-8?B?aUpQenVWMEwyd2VuVEpDRkJZZHhzbnFqK0ZrWWFsb1BRZG1haWxNSXBIYlV2?= =?utf-8?B?eGd4NzU4bGFZZjdVczRsVnZWa2NCSVg2MWtvY0hkODZUWDZyM0dkMmdMZnp0?= =?utf-8?B?RERyQm52c3VUeENXWWEvMHlNQUIrUmJhUEpSb3NZK01vdzZQd1RaU3R5R29W?= =?utf-8?B?dmVvNURVMjc3cHZuTjgyQXd0MVdMblFVcW9Qc2JwZlJTRlUxMkxSanNMUExx?= =?utf-8?B?NXl4MlZ4UEZBT1lhK2ZXYy9TQWtaa0dDa3U2aEpReFVZMnYwV3ZCUHJCMjhM?= =?utf-8?B?ekNGL3NGd0ZpbUNIM1dCM0I4SjR0UUZqS0VsV3Z2STFXcWhIWUlUZFlRQWhD?= =?utf-8?B?NW5lbnhFbjBQclQxaTRRcU9ERnNhZmxvRnpqdGFJTHdsTWFhZnd0eGEzYStZ?= =?utf-8?B?cGZwV0ZnUmZyWkhaMFprazUrWEkydEZpUkJhMVAyR2c4U3RObzFlandmNjZ4?= =?utf-8?B?ZmJlL0tnc3B0TDFuNEpEVHBKYVBlTmlTbmVIMndkSGo3TmJNRHFxM0x4UFls?= =?utf-8?B?MkpJektBcVlJK2grREp1c1J4UTNJZlp6R3pSWFR2bysyNEo5Z3BoRmNCSGVL?= =?utf-8?B?Z0dkWXVtWVo3MUlCS0RHZGFFUG5PQlh0Z0FzZmx5TVp2OVQxa1A4b0wrVW9p?= =?utf-8?B?bk1ydEVTbFo2dFQzT21RZFRLUWdKdi8zUTV4UkNPRkRRcjJGZnArNzRrbm01?= =?utf-8?B?NXBZSExNdTVKd3hBYmZDRDdsQ0Q0V1RhdGhTdE1GbXUvVXhnZ2pOSlZ1cSsz?= =?utf-8?B?L2FVSGpuUXZ4RWFIR25sbzYxbmZpRUFPMlpXRnpGaklmTlc3d3kraU43TEZy?= =?utf-8?B?Rm8xYnczbU1VRXMwN04xcU15WUhFdS9XV1BrS3RPcTlxTVp4M3JGVEFvQUtY?= =?utf-8?B?TFlnZFAyTHQyLzVCalAyS1crQUtpTTRIQVBXYm45U3VRREt2T0xHU1V0Wlk5?= =?utf-8?B?S0RFOHM1YU5GdHdBem45OEZBRmhsK0hpYmhLNlV2NS9WUCtDc2ZVM1R2VWZT?= =?utf-8?B?OFhJR3J1QVRCUzBySFJONldZMXlyckZob2FkT3k3NjROZjJuZWdhVXFUNEph?= =?utf-8?B?MGhzRkJja09MSWtUc1F3dlQ4VmNZQ2lja0lObjNHZ2x3dHlCL0l4TjNHSFhD?= =?utf-8?B?TGh2ZWdSeVVkcVQrTEpQaHlxUlNtd3c2bnZNMmxOYThHd0MvdFZXSngvYjc1?= =?utf-8?B?K01zQ1VkbisrYzAzMmZWeENZcWF3Ry9SbERIam1pa01NalhVWXI5bmFvcEF4?= =?utf-8?B?WDQ4dnpiL3hRZDkzVkVzNkhrSCtJZUxiQkhpdDQxcEtOOXNqaWdVQWJLVmR0?= =?utf-8?B?SkYwb1lOUHQzWUdkV0VvQkFQREFrWVBZUDM3ZE1adnpOb0daMHJMeFB0Y0dk?= =?utf-8?Q?4jTYMT7+9ac0a244OhkOR7XM0=3D?= X-Microsoft-Antispam-Message-Info: 9GbMk61VM77q554xqpnBQLFD+gzR/u4tNR3GQqw0IhnaDvoRt73BT1jP+nqU45PZ92BkAXZGXC3hTETdqw0BcCro68N/KnQoY4ePSNCEIvC33rrWqb/8tJnkRNHNExQ3UI+416PjmZduJD2sxInu35MXbPLjHvurqSf9cQ6xlvjCnkak1oE74Wh1n2W1nWiS X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2777; 6:OpTpWz50kHif9T8+lOAC/ZyPpsIbTCFk5spKffqmTQjFCbxObo8W78VvU5KKNXEZPnvW1+p5DoaQNssgZhlF2+1I/RCdl3FS4f+1n+e7eC9o5r6HUUtfR/3C28K7M6k5yRUS5xbpVoZji4v81/c0D4Wy13BOT6QVuw+9JGhnUW+2OMahVT7ea05X807HPsL/kO7/XpCc5Ka/X3OdoXTuLprHkOOOKgUgLSamjVKmJJgJYQbFfctAEvtoWO6p7Bgu4sG2b1f1QGvjmd5YO489ugZ7E3Sqv5wwaXlFJQ6gT+jrSuj0gSe2Mhu/bwLUUdXLaR1GxbGhdf7iQuln8H0Q47Lp/sJ5qEKl5T5yP8jWsnfqbGL/D2+EP3X+dMoN9T7fiE01QsfJddFdhBGTNgpSy5UTiWBmtkPRi0R+fImpZe8VOko/GxSypMN3/ebsoX5/kasSdm8pu7z08uOfp0Bh9A==; 5:FHF/9HEh8YxUbp9dSNAqxSw02jVxv9rk/APpU7YSYeOA/ZrCPex87PXEGlei9JY+TvdRis98Ba5MPmHHOitUsSojouu2LebKwxK1N+uv1Fzidv+3OOVDlWXg9/f/5nXWsBdXmqqHPqyKV+RXkHXd/zajNpUD9KYBN1rn9P+aJlA=; 24:nTxqic5jJ7u5mvy0IFE1icK/t3SZh8/obVxS8JEPtTrPQGryNjSbS3tJCcql15e+Cx4gQgsHdpliQrq0ViO2Zj5H4NDgwYOilaSre2t5zCM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2777; 7:4M8TJpYGDuXjq59Yr5w/9PdcIiegRVh5JjzPdjnvtclHKr4d8EhCNzGJqtYwVL0OyHOuZmpx1pgbdxPXnzac/KtbDo7VDBjfz64WbTyRroDsNoBfUnehkWe1dSFjqPJNr21J20WWRS8mmHO5kV/GjoLFpJdYMERU0tq6IjYBH41DHohvudprbnO2WyhanYJIJfc6OBeNGhyw5zwWNlp3tDiutwUo2pAhrZp60keQKpAq3JjfPBha9u5sgNpypJMI X-MS-Office365-Filtering-Correlation-Id: 8845416d-b7c5-4d97-e8db-08d5a38f089e X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2018 11:41:45.3232 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8845416d-b7c5-4d97-e8db-08d5a38f089e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2777 Subject: Re: [dpdk-dev] [PATCH 2/8] bus/fslmc: support scanning and probing of QDMA devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 11:41:49 -0000 On Saturday 07 April 2018 08:46 PM, Nipun Gupta wrote: > Signed-off-by: Nipun Gupta > --- > drivers/bus/fslmc/fslmc_bus.c | 2 ++ > drivers/bus/fslmc/fslmc_vfio.c | 1 + > drivers/bus/fslmc/rte_fslmc.h | 2 ++ > 3 files changed, 5 insertions(+) > [...] Can you please explain, in the commit message, the relation between 'DPDMAI' and 'QDMA' devices? Your patch has both these tokens. > diff --git a/drivers/bus/fslmc/rte_fslmc.h b/drivers/bus/fslmc/rte_fslmc.h > index 69d0fec..a454ef5 100644 > --- a/drivers/bus/fslmc/rte_fslmc.h > +++ b/drivers/bus/fslmc/rte_fslmc.h > @@ -61,6 +61,7 @@ enum rte_dpaa2_dev_type { > DPAA2_IO, /**< DPIO type device */ > DPAA2_CI, /**< DPCI type device */ > DPAA2_MPORTAL, /**< DPMCP type device */ > + DPAA2_QDMA, /**< DPDMAI type device */ > /* Unknown device placeholder */ > DPAA2_UNKNOWN, > DPAA2_DEVTYPE_MAX, > @@ -91,6 +92,7 @@ struct rte_dpaa2_device { > union { > struct rte_eth_dev *eth_dev; /**< ethernet device */ > struct rte_cryptodev *cryptodev; /**< Crypto Device */ > + struct rte_rawdev *rawdev; /**< DPAA2 raw Device */ /'''''''^^^^^^ just a 'Raw device' please./ > }; > enum rte_dpaa2_dev_type dev_type; /**< Device Type */ > uint16_t object_id; /**< DPAA2 Object ID */ > Just the trivial issues noted above and after rebasing on master, please use: Acked-by: Shreyansh Jain