Re: [PATCH v6 11/17] net/r8169: implement Rx path

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 11/8/2024 12:11 PM, Howard Wang wrote:
> Add implementation for RX datapath.
> 
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
> ---
>  doc/guides/nics/features/r8169.ini |  12 +
>  doc/guides/nics/r8169.rst          |   8 +
>  drivers/net/r8169/r8169_compat.h   |  24 +
>  drivers/net/r8169/r8169_ethdev.c   |  76 ++-
>  drivers/net/r8169/r8169_ethdev.h   |  18 +
>  drivers/net/r8169/r8169_rxtx.c     | 790 ++++++++++++++++++++++++++++-
>  6 files changed, 925 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/nics/features/r8169.ini b/doc/guides/nics/features/r8169.ini
> index 54a5ee0170..1095b038d8 100644
> --- a/doc/guides/nics/features/r8169.ini
> +++ b/doc/guides/nics/features/r8169.ini
> @@ -8,6 +8,18 @@ Speed capabilities   = Y
>  Link speed configuration = Y
>  Link status          = Y
>  Link status event    = Y
> +Scattered Rx         = Y
> +Flow control         = Y
> +CRC offload          = Y
> +L3 checksum offload  = Y
> +L4 checksum offload  = Y
>

As far as I can see following features are not enabled, at least not in
this patch, can you please double check?

I can see they are fixed in later patches, but can you please fix here.

> +Packet type parsing  = Y
> +Rx descriptor status = Y
> +Basic stats          = Y
> +Extended stats       = Y
> +Stats per queue      = Y
> +FW version           = Y
> +Registers dump       = Y
>  Linux                = Y
>  x86-32               = Y
>  x86-64               = Y