From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00C2D45CDF; Mon, 11 Nov 2024 01:20:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C28064027C; Mon, 11 Nov 2024 01:20:52 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2056.outbound.protection.outlook.com [40.107.223.56]) by mails.dpdk.org (Postfix) with ESMTP id AAC8C40151 for <dev@dpdk.org>; Mon, 11 Nov 2024 01:20:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=h2IxetZTPNWp7S+vKJ8ZUV1EHNv5Umt0WZRvtRenUicerWeuT1BylIYIV9PI6mRp6xef+zEIxuEtX7sbC5SQaAxldoOgb6YoLmx4TfjFOVHKMo1yOmnJqa4GzrjTbrfqfpOUmVZ+QXaSN/8pmxV+PRJ+fM9z7JTKXY/nkjyOC7J6Q3Lt3K8R5ezaZrc+UynTPX9TlMNIovdZdA2PVStQoe8kus5rrR6jPwKgCy+ajgMwVzfyyNdd9GhAgggeFXGJxXguHDeCSHPrfUqeeXKf6iJi4RPNqDRvvtWHyMmOH7IQUM5fnJPo5lZlgZw2li7dbQUDySeG9sMFwlPycLnF4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SdoorlR++vjTNyL5C3ZmDbm5+yYZMqKXJfk68BQ/bJE=; b=TAWjU8XOBflOP3Q71PqHVGDe3p8/VBrnemLHQyG3fqo9qmkg8E0a1z6KyDrakPF03vvhqFCTWSNJHP//cLx/bPeqzPEsWloWsEG9f7aN51Zs2vP9kU+vCd+QBTXjmAGqHaq/uAgottMW8dOKKD0fXXYSCRWcgWojL49WYsn82YsYgWcgATD82WM2TALstKRVHhmOTrwNyRmlwRAnHXkIN75qsyELNXV/wwjt/ad7bWQWXeuHYk/323Hjj/jMaCX/ceBjpXEi3DH3g2bswcWgGeXFEkadLMVvFZe9zWbTzwYbfKkxjjJhU6JPHRLuZlMEErS29ohLPtu3VrCBDkrhVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SdoorlR++vjTNyL5C3ZmDbm5+yYZMqKXJfk68BQ/bJE=; b=3kJgxjzG8HTVBEws+pvltofzooxNyGMel9PD1L2Wua9TyC//MySdDtZ1LCT66aqEP/eaH7gTHWwvdFyxOHSDekQ2cC2xiW9vO79lGSo2kZCmrT8iv/cAq1C/4wej7doQVvRSl6Gf2CA4N/3kjQNBrrr86r73+qyHkYO0uINfuRo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26; Mon, 11 Nov 2024 00:20:49 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 00:20:49 +0000 Message-ID: <f2b92dc6-ae18-40df-92f7-263ba87e8e70@amd.com> Date: Mon, 11 Nov 2024 00:20:44 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 11/17] net/r8169: implement Rx path To: Howard Wang <howard_wang@realsil.com.cn>, dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241108121123.248797-1-howard_wang@realsil.com.cn> <20241108121123.248797-12-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <20241108121123.248797-12-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0671.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::11) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: da184bf7-f517-4af2-44ab-08dd01e6b1ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SDRzcHI4aGt3VlJvOUdrOWVjcGN2MFBMdTdreU5ZZWtmNE1GbC81WTJ5ak5R?= =?utf-8?B?NG03MTFxT1hlUzNhOXpCUFBPV3ZIdjlvaGphSkZZSmpHS2xOMGVqNldybG93?= =?utf-8?B?aTRTRG1DcnJheS96MmZlb3F1NFRUMlFBTUhHWEYvMlpwN3RrMGY0WEJhVVBz?= =?utf-8?B?aFdLeUsveWNNMi96dktlTXh4OUdhZGJPTWpwT0VsZWxGN3djZ2Q3U3hvNVlK?= =?utf-8?B?R2ZDdWd4Vjk4U3JyT1U2SkR0ajBQMkVHdXpadmFHRGVrdXQ0cXdLdVdLakVW?= =?utf-8?B?MGpjenhNRkNwQk1BOUN1Vzl5aFI5dDkxL3JSYkh4UmlMdzZnaDY0aS9LeFhF?= =?utf-8?B?TUZLeHEvS2V4VCsrL1Z2aFBEZ0FuQXBOMjRvZzZ3V0FmTHpYWnRnNHlhS3Bs?= =?utf-8?B?SUtDTDZYVDVxVkpHYi9VK0RVK1dwYW4yOHdCYkUwZ3kvbjRZbE41bE94cmkr?= =?utf-8?B?cFFkemNubzFqbHBad3dlNWJUM3FHQlg4Szk3emVnZGJodWhud0NTRlNON3dE?= =?utf-8?B?Vnp2ajU4SmJKSUVlTlowQkZ6TDdFVjBVRHFXcHdqQWVGTC81TjZQMFpIbVVB?= =?utf-8?B?L0h0emozL2xld1J4MTlwVG9QL3R1NTBpMjF6dVVjeUQya2lQcnNzeFdBeS9k?= =?utf-8?B?bEt2UFNJR2RQRDA4ZEpVNHdwZWNxTnNIWDZhb2FqZ3FpRVVkMHBNdmpOYkxL?= =?utf-8?B?TDFyWUVORndqRVJTMHU1dzZGRFJtUzlMaVdmcklvL1lpcnE4T2dvc08xTlFZ?= =?utf-8?B?M2RiMEpldVQwQUhVYkx6bHM5cjVXckVCMUFsNVVmN3BUYlVxL2N0eUQ5ZGhV?= =?utf-8?B?T1lwa281TUZJdW14c0c3RSttaHdUcHFiaGFPMnNVK09QUGEraGpWNG9SUlBh?= =?utf-8?B?SmpKZ2l3N3VTanN5L0NibWpDc1pqK0wzS0xsc01NTkU3eW1hK1REbkZBVGQx?= =?utf-8?B?TTlRVTJ0b09KM1ZsQXI0TGtpRENvQmpHeXVQRzdQWlkyYlBsQ0hMSkh0ckdF?= =?utf-8?B?dTQ5amUxSTFGYlZzTjlRZ1I5eTU2VGNCb2pRS1JCYkt2Ly8zNkFRQjhyUFZJ?= =?utf-8?B?WHhBRUxoTENwK09SMXIxK0d2YnNIcEFIS0dTNmVIbFJsZUdaTW9mNUhWUkpR?= =?utf-8?B?RVllc2p3Wm9vT2kvdDI3Z0hXMWZhTzVSSG9xc2Fud0pidU9GSCtJWU5wVUtX?= =?utf-8?B?cE1qc1J3VllFZ09aOFJudE5WcXBMc3duZG1GV2J0dmZsdEp6d2FScGcwWFdL?= =?utf-8?B?MW5KMGRYUDRZNVpnY0pGMS8zQXRMSlRDT2dRTTUwV0srR2t5cHVQVGZEekFC?= =?utf-8?B?RjdDYXVldFNRK0Npd2k1RXdGaXdkZm51WmpQaEtkdHlrai9sYy8xeXlHU21M?= =?utf-8?B?MGZSOVczOGlJT3A1emIwTnlDbWJkZlJRRVF5Rk1Ja01hSnJYRU9NSGMzVVJR?= =?utf-8?B?VU0vWmNaZExhTWl5dXZaWWNTV0hrdFVoRmtuK0NYRlJkaGZYK0NkSVVFTGRu?= =?utf-8?B?OW9XQjdsQW9GOEFQL25ZdFdGSER4QkUvL0dqR3VHN0NJWWErQ3VkUFRpbzNi?= =?utf-8?B?WmNDYU5Ibk5JQ0QxVVdlS2JtN1JiRy9LeWZUQ0I2WlVkQitjdnVEbXQ1NWM4?= =?utf-8?B?T3VjOWh4QThUNTlCZVNYU3o4RDZKK09mcVpSZkZDcDZnOHZXaGlmWUZ1Qjlp?= =?utf-8?B?NHdvUXFUR2p1WlZNQWNnTmlmMzdGUUJMWTdKY0FUOHU1ZTN2cXZsSnpBUTVV?= =?utf-8?Q?CKGo+GNyNHkFs4oucPZMdV813+D98bKVOGC9BRy?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmpCY2JxZ0hxV3MyS1RPN3hNU2xlN1ZWRFpxV1JiTEE3OGd5ZUZ3YzRFT09U?= =?utf-8?B?N1V0bjFuUGhlUll1RFNwNkdMT2k5M25WL0ZUOXpCRVZoWEpIRTRqTU9CdFJy?= =?utf-8?B?c2hoZDNnRG1TbXR6M3VPUkYxSm1OZ09sODdzWERQSHd0T2JwQXBGRHF0THgv?= =?utf-8?B?eTdFZEZxZ3pMTjZHNW5jYWZNekRZeS82ajFSaUsvbVZUeS9wdTRYU2YxOXFq?= =?utf-8?B?MG9kcVkvbDFYVnJyRTZtUlFESDM0czExUEQvOGR1SHdyM1BIbzJ3bWpQMDBu?= =?utf-8?B?QVdRQ2V0ME94c3FJY3dPdlNHSklHakFSZGIzS1oxMnlkK3lETXVjRG8zaUdR?= =?utf-8?B?ekI3WERGVklieU4zU1hIWXZPQTdKTmRFdFczcEVIK0g2eFc3MnFON1BjT21J?= =?utf-8?B?TTdRUm9EOHBEUXlGbytpanJ6Yk5QZGVQMnJKcGJ5YmdZYXNSKzl5NzVhbW5l?= =?utf-8?B?cERWOFVHaHdGT3Y3aU54NldvbU5VSWhZcmhqd1MxdVlzdGxwQ1ZMTlVYWkMy?= =?utf-8?B?ZHk1WjNrV0VGdXZPM2NYVnVIUHFxTVFEQjIwcUY1OWk2SEhEUmpzaytTVmhN?= =?utf-8?B?dkEwMVNaZG5BZmd6WjE2ZlhVN1UxM1RFckIyb0JwSnd6eFc0VHNvRkJUMEJ2?= =?utf-8?B?MUNsWG04Vm9hSVV0VlJOd3BCVzFldDlFZW45T3pEVklDeCtEN3RVdC9rdFFq?= =?utf-8?B?Z2FnWWpyTFlDQ1k1VStXRGlQN0t0c21MQ0M1aXBqYTZ4RUk3Z2pIeEZUWURv?= =?utf-8?B?dzVqS3FWUThvM21iZHUzUENxSGpQeGxIeEdKVUtodEFJV0FrenAreFlVSGtC?= =?utf-8?B?NDc0QWxidTJkbDVsWDZ0U2VLVG9qTFB5WWhRSzNQMTFabm1jcVBteTNVUGht?= =?utf-8?B?enREdlVmcUt0djZRbnhmWUwvOG9PbFgveE4wRGdOUVFXV0lBWEVsR3RTSThO?= =?utf-8?B?UFdHWVdLcUJGTHpzSmxQamFLQ1JrMld6cUJtelpSOWdjY0EzT3FvcGhWb3pj?= =?utf-8?B?UUh2MktzYjlJVncvalNyQXd2a1pQZFNUSWJvU3BsTDFQeGlnblArWndoTmly?= =?utf-8?B?c1NWUkd4bGNEc2djRVBzVHZZMDl3Q3FrN1dSZGY1UExUVm42S2NHT0JYYmo1?= =?utf-8?B?cmlKUnhLcTZhQ29ES20rZjdDZitmR2ZnSmM4M2ZBTnh4d1VpTDF3VzZLbFpS?= =?utf-8?B?cjJORVM1SXhRcDI5dnhZbnoyMXpudXp6aEZxdXU2UmV5ejF3SGhLWWIyT3VB?= =?utf-8?B?djBlNHB1ZThXd2MzSmpjOU1oUTVlUHplNnFITFMwV0VFcGFWY1gyZmFTQk5E?= =?utf-8?B?STl5MGlWVWtmYTJkejlaKy8xUGRxVUd6a25OK0lxVWZaMGpHUUhvcFMzY21k?= =?utf-8?B?eWtTTjVaSXIxVUZkbW1DZDNpeFJwWTZjVkE0UkZyUk1DajJUM04vcGRLM29o?= =?utf-8?B?WkVuWWhocDRkY2FUZVp4MFR5QTRIaEI0WEdhVkR0VVB5YWlzTk1XMjFVOWM2?= =?utf-8?B?OW1pei9QaHZLdWU4K2RsQUg4RFBZeDBBaUgza1RBWTR6ajlJa2NZN3dBdjZZ?= =?utf-8?B?NGVZOWFvRjZLNi9IeUJXKzdJbDl2VGhJbVZ1K3BlVmVTVXZVSU5QMnhqNGFZ?= =?utf-8?B?aGMzN1FYVDREbmZzMDI5V2ZJb2ZSWEtUVmJLZk9CNndwN0FZaVFweDZwTy9Z?= =?utf-8?B?eXo4Q1hCcDFZd0JTSFhiVlhVL044cndQOFVKM3hnRkkrWEFZbjdraVJUSTlB?= =?utf-8?B?MkROOFhoaVUyeHBXdDZKNWFUaDkxeGNQSVRsMHFKTkhNdzlJYkVYVWxKVlRk?= =?utf-8?B?bGl3aFZQbGZYRUIxdnZGRDlrbFA1KzRtc3VJOXVPYjYzUHBRODg5b3FvbU5P?= =?utf-8?B?QnU0dzQ5UVoreHFrNlljNStCNEluQjNpSEpmN3F2aCtCalZ3N3BhNEtzajJm?= =?utf-8?B?UHhzenU5czNqbnRjSHRka2I0UEo4a3ZaaVpRT3RpeE1La1VZWGxaUCtTSEJB?= =?utf-8?B?akkrVUtPZlphVzFzY1JSNjB1Z1RtRmJYSGJJNnUyeXBKbmR0cHYrUXA3YXI2?= =?utf-8?B?MExnUkVJTDdwTnZkd0pxVU9qQmJFMWRNZGVsSTdjTEltL3hUcnUxU0JoQzRt?= =?utf-8?Q?9qcQKVg3426rky2w+UQfvHttD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: da184bf7-f517-4af2-44ab-08dd01e6b1ab X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 00:20:49.3771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3qDbP8ElDWnbci8PZ0zBfo+e9ti3IxeyoaQNr/W/wq9khqq2dn8RVzz5nhg7Ud/k X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 11/8/2024 12:11 PM, Howard Wang wrote: > Add implementation for RX datapath. > > Signed-off-by: Howard Wang <howard_wang@realsil.com.cn> > --- > doc/guides/nics/features/r8169.ini | 12 + > doc/guides/nics/r8169.rst | 8 + > drivers/net/r8169/r8169_compat.h | 24 + > drivers/net/r8169/r8169_ethdev.c | 76 ++- > drivers/net/r8169/r8169_ethdev.h | 18 + > drivers/net/r8169/r8169_rxtx.c | 790 ++++++++++++++++++++++++++++- > 6 files changed, 925 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/nics/features/r8169.ini b/doc/guides/nics/features/r8169.ini > index 54a5ee0170..1095b038d8 100644 > --- a/doc/guides/nics/features/r8169.ini > +++ b/doc/guides/nics/features/r8169.ini > @@ -8,6 +8,18 @@ Speed capabilities = Y > Link speed configuration = Y > Link status = Y > Link status event = Y > +Scattered Rx = Y > +Flow control = Y > +CRC offload = Y > +L3 checksum offload = Y > +L4 checksum offload = Y > As far as I can see following features are not enabled, at least not in this patch, can you please double check? I can see they are fixed in later patches, but can you please fix here. > +Packet type parsing = Y > +Rx descriptor status = Y > +Basic stats = Y > +Extended stats = Y > +Stats per queue = Y > +FW version = Y > +Registers dump = Y > Linux = Y > x86-32 = Y > x86-64 = Y