From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCA57A0548; Mon, 27 Sep 2021 14:15:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C025B410E1; Mon, 27 Sep 2021 14:15:01 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 988C6410DA for ; Mon, 27 Sep 2021 14:14:59 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10119"; a="221261670" X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="221261670" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 05:14:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="537679634" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 27 Sep 2021 05:14:52 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 05:14:52 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 05:14:51 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 05:14:51 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 05:14:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SxfxIZGRneBeu89CjDT90RpLBNPdFV6y7ERj6LbetoxXQUkT7veV9aIKfNl/3RSsXEqd2f7ZMBqenDb9MG5m7JgQdKXhz4xTQM5OIcv7rjPCyJlxYkFldiC3OTvLNT7JLFzvEpOFEx7XsZtj3bTKRiRSUSPA/vZ0Ez93alQR9IDgejrDOAnGXpcfLCGTWAzS/xIWuMbR+qtoABRjc7Dz/+Y1Z+1S04xtfMGb4flxVYIAsMmiU1Kt2w+56pEVfV+BJVvGbpFcgLgVu2QqHXjCmpD6EtjqiqgWLYTmYTBjSM7aSt7FJUE/EQEfBJUr1u7SBZ4JReS78DMttvYlDx7SLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/p3Xve0cqViE0Py6WN/zSllyzPuZ8HDQDF3VWTmVbZ0=; b=J9ZXdGeQ5pYrlrjmieliFX3ID4yFcdoyqd/QWdVJcufZYaMwYKCkJ0X/Ed1jRffxsauxADDuYdRpORhtiJpVpwxTZyFn/XX2pD+DsSXgPPV/QIXLebJB7hiE+yQA7DYDyytfhOI34uhZEJIYQh4zFyofu44SA6ZaotCzu6QnKif1bjNN1fefzywMUt+DChNnIWAfBeNBh6IwC7efJJQWMgOYes9zIERp24UzanAILzm+1wACChYSwKBsE0xyqYBusBk5EnefKrM3oMc3RsYFgas3qvRd4dP/peT+EbLQnkL09drLRQYNNL2ntdwG4A6tLpufJKLplgoaf7CknTLG3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/p3Xve0cqViE0Py6WN/zSllyzPuZ8HDQDF3VWTmVbZ0=; b=owNJuabItEHp56mSNx2bacecLVUSlZN+Gi+NDOjaJxkQ4QTvVJ9MTqTELGma3Amki+Bg0w08qAY7mcfD3bah1E7iwCNeXDqznQlrbh1KDm6mIhMre/06T4AK3ebdv4EvNVYc4rmJoGEuDsR9EKcQvsjMPkOPHSBqJXyTuQAA8VY= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by MWHPR11MB1805.namprd11.prod.outlook.com (2603:10b6:300:114::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Mon, 27 Sep 2021 12:14:48 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4dcc:489e:1d86:47cb]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::4dcc:489e:1d86:47cb%9]) with mapi id 15.20.4544.022; Mon, 27 Sep 2021 12:14:48 +0000 To: "Ananyev, Konstantin" , Akhil Goyal , "Doherty, Declan" CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "Medvedkin, Vladimir" , "Richardson, Bruce" , "Zhang, Roy Fan" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "Sinha, Abhijit" , "Buckley, Daniel M" , "marchana@marvell.com" , "ktejasree@marvell.com" , "matan@nvidia.com" References: <20210713133542.3550525-1-radu.nicolau@intel.com> <20210917091747.1528262-1-radu.nicolau@intel.com> <20210917091747.1528262-3-radu.nicolau@intel.com> From: "Nicolau, Radu" Message-ID: Date: Mon, 27 Sep 2021 13:14:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB6PR0202CA0045.eurprd02.prod.outlook.com (2603:10a6:4:a5::31) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 Received: from [192.168.1.12] (109.255.186.106) by DB6PR0202CA0045.eurprd02.prod.outlook.com (2603:10a6:4:a5::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 12:14:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a6f5bae3-746c-42ca-bcec-08d981b0666a X-MS-TrafficTypeDiagnostic: MWHPR11MB1805: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KKgZ0m6y7cavpSzL4p7i19IwuKIT7SVrsjOTWSCSKAG147ywWQ0iwHwDUwBrUvR3dojw+mAYX0xwnssXyULqe815Q1VRUivNOHQD+cElO16pzZvUNvaYyvWd44y8e68kwg2pjOnFHoNwnKxN8IUBPiyMOq/TwPexJCQDWob21u2T1ZSxAFs7yEzqDO5Q6ziFk5Y3F0h0LoAlVOSdH70k7uBPBvFMdFLtBQl/NAlrW/RJrQEbNKW4mS49N4OAj2V6Ah6XreJZr3mnD0NaE+K6kdvxpEcbUkcaZDSBq5lvpF1ElLyeoAVUrzYBSeDloyfTRBiFuha91sMyrR7VnZZeetHgutqRowFNuN6MXA8wGmjC60HYW0RKEMyfMu2e2+0M0hA/Us4Y54aeb//gpGNrXjOm/Lp/2gW7tozIQLLnHYU2wfxkil+4K5caXzy/BLkf08xZjQ4fKgZzeAcYAXE+M6r/reQO+wvc+TUprXDB7cHO4+BCsNS7CmnsvHreT4bBZp10fFao7bvLCugr6kTBhHWgYbmwkWapUCOO6cQbvOFd5I7tRAwZsgFj16DZEK8rEAC6OaC1xe5xQrYvVRRj9e/jj0640WQP+LW8jj/sRvgEKSWCw0zoiTQ8hCZMgQp7+febII0wVKBNOUm6GzFVi124SiAvajrqdp1tyNS07gALSByufrhg6bXI1G9sfUOxYzSAPxhBztiHhwbb3Jb33cF2t4OGikE9DFzszQzmA2V3GC50YY5zJ4Z1TYQrU/Y6 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6486002)(86362001)(508600001)(66946007)(26005)(186003)(15650500001)(31696002)(83380400001)(55236004)(66556008)(5660300002)(53546011)(66476007)(16576012)(36756003)(8676002)(316002)(4326008)(2906002)(6636002)(31686004)(8936002)(54906003)(110136005)(38100700002)(2616005)(956004)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjZIcitYWEpFU2k0eGFLOVNlakxESjlEMTlTRFpwSFpFaVdCUGhqVXJBa2p6?= =?utf-8?B?QWZ2cUlRMi9KUXlTanJDOWVLNm1iT0d6TnhEajNEaEJnYVY1eGZjeHNyWVd3?= =?utf-8?B?c2ltd08vOWh5SzNCdDlyZUpaQVl3MjB6c3BlTHRNV2tqZXVlUUNUWGJBazBV?= =?utf-8?B?cXhWQ1Q3NmdiN0hqbUg0MXJNUS93VTkxNHprbytZd2cyQm45N05CR2xXVWNt?= =?utf-8?B?c3hkeEhuQk1sMStGbjR5YzcxNWRyZUhtZ1Q4cksrVHk1TGZaNndoK08yRzEx?= =?utf-8?B?anRXRlJ1YjR0cU1RVlZHQjc0TlpWVmJZRGV5S0ZZZlNGWEM4U3lMcXd3Y1F4?= =?utf-8?B?WTlNbXNORHIzSW9YVEtweVhDZGpaR2tFL1U2ZWR5dTNJcXhXUm03NldhNS91?= =?utf-8?B?a05zeWFZMk1GZWROMUFWbE1lRkp0TXl1R2IzQzY3QksxR0R6L080Y05UNkpX?= =?utf-8?B?bllROHFJUVRWRVJROUZaWE5qYVZKekRoVkJjUURkY21rcFM0SXVHcjRsM1dk?= =?utf-8?B?dGtlNDJlb25UM050Q3VDcUtHU3o2amJvVE96RUYxVHdKWXhrT2xza2ZvN3FD?= =?utf-8?B?NWYxZ1Q2eHpyOWZqRzdxS0hKY21tSDl1Um4wQmM0WjIyUm5sVUlOVHo5VFV4?= =?utf-8?B?TE5USm9XaXg5eDdDcDZvUCs2MzZ2QlVRUnFoN3JJNVI2NGhVYWkzZk9RQ0ZK?= =?utf-8?B?NWZwV1JvQ2JPcjBOODllUk84NURUN0ZoRFVCTGdOc3ZrR2t6NThpU3FTbmov?= =?utf-8?B?OHVNSzY3ck5KdVlORk1ySGZoNnF0OGxxWEwyRytHSWZ0VkE2QnZ3eHV6cFhG?= =?utf-8?B?VHVSTU9Tck9va2I1MzMyMFowa21jMDRkWUlWZitwR0ZCSjFDQTBMK3FtV05h?= =?utf-8?B?SVhmbFV4NENvcHYvdWpXOEZZMnBMaTR4OEwrREpDSlpvcVJsbU4xS3pMR1ow?= =?utf-8?B?WUZhRnJwYXN5ZE9vTFdnWHJlaFB1a1E1eFhHeHIyT2ZUYkF5OGxUZmhvbnRu?= =?utf-8?B?UnR2NG11UDNPVlJQTXZZbUhKUnJkdHhESFBZM0VWclYxT3lmMTNVY2x4SGpp?= =?utf-8?B?cUdMdXNOTVdaUk1McUVQalplWUJPM1FEU3d6b0Jkc2VJS1NoZFdzcGhYQkdp?= =?utf-8?B?NCthaERUc0h6RTM5OVhSVHh3NXR6bzlHb04wamVMVkZIaFFPcldxTEx5eVQ5?= =?utf-8?B?T2ZkZVlLVmxub2syRHFZd2pUVmYrNTUrUTR5eVEzWWNMUEM3a1Y4L09VVlpZ?= =?utf-8?B?T0U2a0pjcGdySGRvSjJ4TUptcnQ1VWk5dmlCTFNTdTJMN1E2N1A5dHpVelRG?= =?utf-8?B?RDErejFsZEFlbDhneG14M3dvYU4yVnJlYSttbFZGNHZIVGRwKytVWWxHOEJM?= =?utf-8?B?UHpGUEFCS1JGWkRKVGtlMkM0NFp1VzNFanZpV0FYL05rWmpsSWVUV0lqbGlP?= =?utf-8?B?cElOZEg0cFhpMCtKS0xTOW53M3cyVW5ZV0RlclBMWXY4c3IzVi9VZkozTVdm?= =?utf-8?B?b1Q0UWFybUZ2YVF3bDN6UGdNSTVuM2o4S2hVRFJjc09va0RRRTgyT1FoWFpR?= =?utf-8?B?dHVRWFRPR282cVhqajdOa1haaUkrZEZ2eWlyN0EzN3VkMDhzbVBwd01jSnBC?= =?utf-8?B?WjMrVllORGhkVnNoZnR0Y09DMXVvalI2Qy8ySG1JcUl2TW8yR3dVOEpKKy9n?= =?utf-8?B?T1hmRlkzbWVNVTBWNGpCMVd1NlRQVVRHTU9COUQvaGsydXM0V0Z1S2ppTnZh?= =?utf-8?Q?as0yV0pa87NeTbWhjktT9PgTClq6ByIC9/bKgWr?= X-MS-Exchange-CrossTenant-Network-Message-Id: a6f5bae3-746c-42ca-bcec-08d981b0666a X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 12:14:48.5021 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RUOVz3pIPODKlExNHuais1pogiCBoEiN6VBKxeL8XaJjSuIhTWUQztnrTlrRR8OvTBP6L8RzTDvS0Ekj/xXuOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1805 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 02/10] security: add UDP params for IPsec NAT-T X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/2021 1:43 PM, Ananyev, Konstantin wrote: >> Add support for specifying UDP port params for UDP encapsulation option. >> RFC3948 section-2.1 does not enforce using specific the UDP ports for >> UDP-Encapsulated ESP Header >> >> Signed-off-by: Declan Doherty >> Signed-off-by: Radu Nicolau >> Signed-off-by: Abhijit Sinha >> Signed-off-by: Daniel Martin Buckley >> Acked-by: Fan Zhang >> --- >> lib/security/rte_security.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h >> index 495a228915..84ba1b08f8 100644 >> --- a/lib/security/rte_security.h >> +++ b/lib/security/rte_security.h >> @@ -112,6 +112,12 @@ struct rte_security_ipsec_tunnel_param { >> }; >> }; >> >> +struct rte_security_ipsec_udp_param { >> + >> + uint16_t sport; >> + uint16_t dport; >> +}; > Would it be worth to have ability to access 32-bits at once. > Something like: > union rte_security_ipsec_udp_param { > uint32_t raw; > struct { > uint16_t sport, dport; > }; > }; > ? TBH I don't see any reason to access them as a 32b value... > >> + >> /** >> * IPsec Security Association option flags >> */ >> @@ -224,6 +230,8 @@ struct rte_security_ipsec_xform { >> /**< IPsec SA Mode - transport/tunnel */ >> struct rte_security_ipsec_tunnel_param tunnel; >> /**< Tunnel parameters, NULL for transport mode */ >> + struct rte_security_ipsec_udp_param udp; >> + /**< UDP parameters, ignored when udp_encap option not specified */ > Any reason to insert it into the middle of the xform struct? > Why not to the end? I can't see any good reason I guess it just looked better, I will move it at the end.