From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id F02EE2BE5 for ; Thu, 25 Jan 2018 13:19:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2018 04:19:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,412,1511856000"; d="scan'208";a="26260736" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.145]) ([10.237.220.145]) by orsmga001.jf.intel.com with ESMTP; 25 Jan 2018 04:19:24 -0800 To: dev@dpdk.org References: <1512067450-59203-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-3-git-send-email-jianfeng.tan@intel.com> <93ea032e-e2da-f087-567a-2397fad7ff02@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 25 Jan 2018 12:19:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <93ea032e-e2da-f087-567a-2397fad7ff02@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/3] eal: add synchronous multi-process communication X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 12:19:26 -0000 > > See above: it would be much more useful to return number of replies > received, rather than number of messages sent, as that's the number we > are most interested in. Otherwise, if we e.g. sent 5 messages but > received 1 reply, you're essentially not telling the user how far can he > index the reply pointer. Apologies, just noticed that rte_mp_reply has nb_messages in it. So if we are getting number of replies along with reply, this API should too switch to 0/-1 on success/failure respectively, as the number of sent messages also becomes meaningless to the user. -- Thanks, Anatoly