From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEB9DA0542; Tue, 31 May 2022 10:02:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 932EB400EF; Tue, 31 May 2022 10:02:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 22F15400D6 for ; Tue, 31 May 2022 10:02:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653984168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+w/oB/oanogrKcT/E/GKrPy0Jn5E92Ep0zP2Y8N5WSg=; b=Z7uAodib5ebJ7tBXxbxJH8y0j7e8eozOcGkdzF89/eqnvRSyhm/G/UQ0xon1KlKCcgVhn1 J9kTLkm3LvmDnGWgazvTcXZAD2umhq8exvEeWMG16D8Wljl50CAgYYC7gCPtG6SARdt6WR Ih74CjgFPRUC0ShFxLw+U/O0UwY53Q4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-580-qF93eQK6OqW7gNN6oEv7gA-1; Tue, 31 May 2022 04:02:43 -0400 X-MC-Unique: qF93eQK6OqW7gNN6oEv7gA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3A9C3C01DA0; Tue, 31 May 2022 08:02:42 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BDD52026D07; Tue, 31 May 2022 08:02:40 +0000 (UTC) Message-ID: Date: Tue, 31 May 2022 10:02:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v6 4/5] baseband/acc100: modify validation code for ACC101 To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: thomas@monjalon.net, ray.kinsella@intel.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, hernan.vargas@intel.com, david.marchand@redhat.com References: <1653350912-53876-1-git-send-email-nicolas.chautru@intel.com> <1653526523-68839-1-git-send-email-nicolas.chautru@intel.com> <1653526523-68839-5-git-send-email-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <1653526523-68839-5-git-send-email-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/26/22 02:55, Nicolas Chautru wrote: > The validation requirement is different for the two > devices. > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 47 ++++++++++++++++++++++++-------- > 1 file changed, 35 insertions(+), 12 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 6a2123b..a057edf 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -1295,6 +1295,21 @@ > RTE_BBDEV_TURBO_HALF_ITERATION_EVEN); > } > > +#ifdef RTE_LIBRTE_BBDEV_DEBUG > + > +static inline bool > +is_acc100(struct acc100_queue *q) > +{ > + return (q->d->device_variant == ACC100_VARIANT); > +} > + > +static inline bool > +validate_op_required(struct acc100_queue *q) > +{ > + return is_acc100(q); > +} > +#endif > + > /* Fill in a frame control word for LDPC decoding. */ > static inline void > acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw, > @@ -2182,8 +2197,10 @@ static inline uint32_t hq_index(uint32_t offset) > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validates turbo encoder parameters */ > static inline int > -validate_enc_op(struct rte_bbdev_enc_op *op) > +validate_enc_op(struct rte_bbdev_enc_op *op, struct acc100_queue *q) > { > + if (!validate_op_required(q)) > + return 0; This check should be done after the variables declarations as per the project coding style: " Local Variables ~~~~~~~~~~~~~~~ * Variables should be declared at the start of a block of code rather than in the middle. " > struct rte_bbdev_op_turbo_enc *turbo_enc = &op->turbo_enc; > struct rte_bbdev_op_enc_turbo_cb_params *cb = NULL; > struct rte_bbdev_op_enc_turbo_tb_params *tb = NULL; > @@ -2320,8 +2337,10 @@ static inline uint32_t hq_index(uint32_t offset) > } > /* Validates LDPC encoder parameters */ > static inline int > -validate_ldpc_enc_op(struct rte_bbdev_enc_op *op) > +validate_ldpc_enc_op(struct rte_bbdev_enc_op *op, struct acc100_queue *q) > { > + if (!validate_op_required(q)) > + return 0; > struct rte_bbdev_op_ldpc_enc *ldpc_enc = &op->ldpc_enc; > > if (op->mempool == NULL) { > @@ -2373,8 +2392,10 @@ static inline uint32_t hq_index(uint32_t offset) > > /* Validates LDPC decoder parameters */ > static inline int > -validate_ldpc_dec_op(struct rte_bbdev_dec_op *op) > +validate_ldpc_dec_op(struct rte_bbdev_dec_op *op, struct acc100_queue *q) > { > + if (!validate_op_required(q)) > + return 0; > struct rte_bbdev_op_ldpc_dec *ldpc_dec = &op->ldpc_dec; > > if (op->mempool == NULL) { > @@ -2429,7 +2450,7 @@ static inline uint32_t hq_index(uint32_t offset) > > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validate op structure */ > - if (validate_enc_op(op) == -1) { > + if (validate_enc_op(op, q) == -1) { > rte_bbdev_log(ERR, "Turbo encoder validation failed"); > return -EINVAL; > } > @@ -2483,7 +2504,7 @@ static inline uint32_t hq_index(uint32_t offset) > > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validate op structure */ > - if (validate_ldpc_enc_op(ops[0]) == -1) { > + if (validate_ldpc_enc_op(ops[0], q) == -1) { > rte_bbdev_log(ERR, "LDPC encoder validation failed"); > return -EINVAL; > } > @@ -2545,7 +2566,7 @@ static inline uint32_t hq_index(uint32_t offset) > > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validate op structure */ > - if (validate_ldpc_enc_op(op) == -1) { > + if (validate_ldpc_enc_op(op, q) == -1) { > rte_bbdev_log(ERR, "LDPC encoder validation failed"); > return -EINVAL; > } > @@ -2602,7 +2623,7 @@ static inline uint32_t hq_index(uint32_t offset) > > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validate op structure */ > - if (validate_enc_op(op) == -1) { > + if (validate_enc_op(op, q) == -1) { > rte_bbdev_log(ERR, "Turbo encoder validation failed"); > return -EINVAL; > } > @@ -2675,8 +2696,10 @@ static inline uint32_t hq_index(uint32_t offset) > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validates turbo decoder parameters */ > static inline int > -validate_dec_op(struct rte_bbdev_dec_op *op) > +validate_dec_op(struct rte_bbdev_dec_op *op, struct acc100_queue *q) > { > + if (!validate_op_required(q)) > + return 0; > struct rte_bbdev_op_turbo_dec *turbo_dec = &op->turbo_dec; > struct rte_bbdev_op_dec_turbo_cb_params *cb = NULL; > struct rte_bbdev_op_dec_turbo_tb_params *tb = NULL; > @@ -2822,7 +2845,7 @@ static inline uint32_t hq_index(uint32_t offset) > > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validate op structure */ > - if (validate_dec_op(op) == -1) { > + if (validate_dec_op(op, q) == -1) { > rte_bbdev_log(ERR, "Turbo decoder validation failed"); > return -EINVAL; > } > @@ -3047,7 +3070,7 @@ static inline uint32_t hq_index(uint32_t offset) > > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validate op structure */ > - if (validate_ldpc_dec_op(op) == -1) { > + if (validate_ldpc_dec_op(op, q) == -1) { > rte_bbdev_log(ERR, "LDPC decoder validation failed"); > return -EINVAL; > } > @@ -3151,7 +3174,7 @@ static inline uint32_t hq_index(uint32_t offset) > > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validate op structure */ > - if (validate_ldpc_dec_op(op) == -1) { > + if (validate_ldpc_dec_op(op, q) == -1) { > rte_bbdev_log(ERR, "LDPC decoder validation failed"); > return -EINVAL; > } > @@ -3241,7 +3264,7 @@ static inline uint32_t hq_index(uint32_t offset) > > #ifdef RTE_LIBRTE_BBDEV_DEBUG > /* Validate op structure */ > - if (validate_dec_op(op) == -1) { > + if (validate_dec_op(op, q) == -1) { > rte_bbdev_log(ERR, "Turbo decoder validation failed"); > return -EINVAL; > }