From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 2F6A12BDC
 for <dev@dpdk.org>; Wed, 13 Jul 2016 22:19:39 +0200 (CEST)
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
 (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 61F2A1F591;
 Wed, 13 Jul 2016 20:19:38 +0000 (UTC)
Received: from [10.36.7.127] (vpn1-7-127.ams2.redhat.com [10.36.7.127])
 by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u6DKJZfB032757
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Wed, 13 Jul 2016 16:19:36 -0400
To: Jan Viktorin <viktorin@rehivetech.com>
References: <20160713092419.14425-1-viktorin@rehivetech.com>
 <7046512f-49fa-30b4-9238-318617cc04be@redhat.com>
 <20160713194214.19622a67@jvn>
Cc: dev@dpdk.org, Jianfeng Tan <jianfeng.tan@intel.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 Huawei Xie <huawei.xie@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <f2e1a049-bdc1-6b3e-9f98-e2da6b04dd8f@redhat.com>
Date: Wed, 13 Jul 2016 22:19:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <20160713194214.19622a67@jvn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.30]); Wed, 13 Jul 2016 20:19:38 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] virtio: fix missing curly braces
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jul 2016 20:19:39 -0000



On 07/13/2016 07:42 PM, Jan Viktorin wrote:
> On Wed, 13 Jul 2016 11:27:18 +0200
> Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
>
>> Hi Jan,
>>
>> On 07/13/2016 11:24 AM, Jan Viktorin wrote:
>>> GCC 6 is complaining and seems to be correct here.
>>>
>>> virtio_user_ethdev.c:345:2: error:
>>> 	this ‘if’ clause does not guard... [-Werror=misleading-indentation]
>>>    if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1)
>>>    ^~
>>>
>>> virtio_user_ethdev.c:348:3: note:
>>> 	...this statement, but the latter is misleadingly indented
>>> 	as if it is guarded by the ‘if’
>>>     if (ret < 0) {
>>>
>>> Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
>>> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
>>> ---
>>>
>> I already fixed it yesterday:
>> http://dpdk.org/dev/patchwork/patch/14780/
>
> Sorry, I didn't find it quickly. My fault. Thanks.
Oh no problem! Better having two fixes than none :)

Thanks,
Maxime