From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id A11BF2B9E; Tue, 28 Nov 2017 12:49:20 +0100 (CET) Received: from pure.maildistiller.com (unknown [10.110.50.29]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id 2F00C205AA; Tue, 28 Nov 2017 11:49:20 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us3.ppe-hosted.com (unknown [10.110.49.251]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id ADBDC4004D; Tue, 28 Nov 2017 11:49:19 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 67E51B8005B; Tue, 28 Nov 2017 11:49:18 +0000 (UTC) Received: from [192.168.239.128] (193.34.186.16) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 28 Nov 2017 11:49:08 +0000 To: Ferruh Yigit , CC: Andy Moreton , References: <1510819481-6809-1-git-send-email-arybchenko@solarflare.com> <1510819481-6809-16-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: Date: Tue, 28 Nov 2017 14:49:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [193.34.186.16] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23496.003 X-TM-AS-Result: No--11.313100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1511869760-Nf89w6dE6OZd Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 15/53] net/sfc/base: fix PreFAST issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 11:49:21 -0000 On 11/27/2017 10:58 PM, Ferruh Yigit wrote: > On 11/16/2017 12:04 AM, Andrew Rybchenko wrote: >> From: Andy Moreton >> > PREfast seems a static analysis tool. Can you please give more detail about > fixed issue itself. "fix PREfast issue" is not informative about what has been > fixed. > > If you can send the details I can amend the commit. Add missing annotation that function return value should not be ignored. Fix alignment. Thanks, Andrew. > > Thanks, > ferruh > >> Fixes: 19b64c6ac35f ("net/sfc/base: import libefx base") >> Cc: stable@dpdk.org >> >> Signed-off-by: Andy Moreton >> Signed-off-by: Andrew Rybchenko >> --- >> drivers/net/sfc/base/efx.h | 12 ++++++------ >> drivers/net/sfc/base/efx_phy.c | 2 +- >> 2 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h >> index 834eea0..ca0f945 100644 >> --- a/drivers/net/sfc/base/efx.h >> +++ b/drivers/net/sfc/base/efx.h >> @@ -913,13 +913,13 @@ efx_phy_media_type_get( >> __in efx_nic_t *enp, >> __out efx_phy_media_type_t *typep); >> >> -extern efx_rc_t >> +extern __checkReturn efx_rc_t >> efx_phy_module_get_info( >> - __in efx_nic_t *enp, >> - __in uint8_t dev_addr, >> - __in uint8_t offset, >> - __in uint8_t len, >> - __out_bcount(len) uint8_t *data); >> + __in efx_nic_t *enp, >> + __in uint8_t dev_addr, >> + __in uint8_t offset, >> + __in uint8_t len, >> + __out_bcount(len) uint8_t *data); >> >> #if EFSYS_OPT_PHY_STATS >> >> diff --git a/drivers/net/sfc/base/efx_phy.c b/drivers/net/sfc/base/efx_phy.c >> index 752cd52..c81a91c 100644 >> --- a/drivers/net/sfc/base/efx_phy.c >> +++ b/drivers/net/sfc/base/efx_phy.c >> @@ -296,7 +296,7 @@ efx_phy_media_type_get( >> *typep = epp->ep_fixed_port_type; >> } >> >> - __checkReturn efx_rc_t >> + __checkReturn efx_rc_t >> efx_phy_module_get_info( >> __in efx_nic_t *enp, >> __in uint8_t dev_addr, >>