From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com
Subject: Re: [PATCH v2] net/nfp: add the feature of RSS based on VXLAN inner layer
Date: Fri, 14 Oct 2022 10:40:09 +0100 [thread overview]
Message-ID: <f30b3426-d573-dfda-64a3-e0fb1b6bc5a3@amd.com> (raw)
In-Reply-To: <1665738548-20974-1-git-send-email-chaoyong.he@corigine.com>
On 10/14/2022 10:09 AM, Chaoyong He wrote:
> diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
> index e131021..d938e01 100644
> --- a/drivers/net/nfp/nfp_ethdev.c
> +++ b/drivers/net/nfp/nfp_ethdev.c
> @@ -33,7 +33,6 @@
> #include "nfpcore/nfp_nsp.h"
>
> #include "nfp_common.h"
> -#include "nfp_ctrl.h"
> #include "nfp_rxtx.h"
> #include "nfp_logs.h"
> #include "nfp_cpp_bridge.h"
> @@ -138,6 +137,10 @@
>
> update |= NFP_NET_CFG_UPDATE_GEN | NFP_NET_CFG_UPDATE_RING;
>
> + /* Enable vxlan */
> + new_ctrl |= NFP_NET_CFG_CTRL_VXLAN;
> + update |= NFP_NET_CFG_UPDATE_VXLAN;
> +
> if (hw->cap & NFP_NET_CFG_CTRL_RINGCFG)
> new_ctrl |= NFP_NET_CFG_CTRL_RINGCFG;
Hi Chaoyong,
Thanks for the update.
Although practically you don't need to include 'nfp_ctrl.h' since it is
included by 'nfp_common.h',
'nfp_ethdev.c' uses symbols from 'nfp_ctrl.h'.
What do you think to explicitly include a header when source file uses
symbols from that header as a principal?
This helps to document what is required externally for source file
clearly, also protects against changes, like you may move 'nfp_ctrl.h'
include out of 'nfp_common.h' in the future.
According above, would you be OK to include 'nfp_ctrl.h' in
'nfp_common.h' (as already done), but not remove 'nfp_ctrl.h' from files
that use symbols from it?
next prev parent reply other threads:[~2022-10-14 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 9:09 Chaoyong He
2022-10-14 9:40 ` Ferruh Yigit [this message]
2022-10-14 9:41 ` Ferruh Yigit
2022-10-15 7:22 ` [PATCH v3] " Chaoyong He
2022-10-17 12:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f30b3426-d573-dfda-64a3-e0fb1b6bc5a3@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).