From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D77A71B520 for ; Thu, 4 Oct 2018 17:36:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 08:36:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,340,1534834800"; d="scan'208";a="262856811" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga005.jf.intel.com with ESMTP; 04 Oct 2018 08:36:44 -0700 To: Andrew Rybchenko , Rahul Lakkireddy , dev@dpdk.org Cc: indranil@chelsio.com, nirranjan@chelsio.com References: <1537777765-16798-1-git-send-email-rahul.lakkireddy@chelsio.com> <569a7ac3-b725-0607-c3c7-4a8656e3d687@solarflare.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Thu, 4 Oct 2018 16:36:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <569a7ac3-b725-0607-c3c7-4a8656e3d687@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: add action to swap source and destination MAC to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 15:36:47 -0000 On 9/24/2018 9:32 AM, Andrew Rybchenko wrote: > On 9/24/18 11:29 AM, wrote: >> This action is useful for offloading loopback mode, where the hardware >> will swap source and destination MAC addresses in the outermost Ethernet >> header before looping back the packet. This action can be used in >> conjunction with other rewrite actions to achieve MAC layer transparent >> NAT where the MAC addresses are swapped before either the source or >> destination MAC address is rewritten and NAT is performed. >> >> Must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. >> Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error should be returned by the >> PMDs. >> >> Original work by Shagun Agrawal >> >> Signed-off-by: Rahul Lakkireddy > > Acked-by: Andrew Rybchenko Same here, can you please rebase the patch and keep the ack?