From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3C5A4373A; Thu, 21 Dec 2023 06:58:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAF09406B8; Thu, 21 Dec 2023 06:58:58 +0100 (CET) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2046.outbound.protection.outlook.com [40.107.247.46]) by mails.dpdk.org (Postfix) with ESMTP id DC314400D6; Thu, 21 Dec 2023 06:58:57 +0100 (CET) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=N1TMfRMtTsihruI1OVEBWzuowI0WVc1dnI9fo9pp8uLs9/tXU6/KqA1Hvk4rlW2zDXsaDJVdE4ZUFmV0nl2H5K4YEJzsO1M4WduE18zQUhm7inHI5b0vu9MhC6EHtOBjl+XpI+rX5fyQjAFE6eVyPow0cOshCO29mEIA0w0dzVK1CSVsgxIu5RqqYEULQDbaPyqaioenB0ziaDxJCGQrWn6ETN0F7PCn4eo7EV+XR2QJ8RrCKNOyoQh33/VzZow6TP9GNBLOVxtC08lfv2fT2oWTiE7pSF5vAoU0XNWR9o4A/a2WrKCRbee3n5LgBuUOPZh10Jms98IRtTmKCnv4+Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SV3ad587leBJRGbRDimL4fy0zcQF8lcarPSEVMf+60g=; b=j+Sed5tRVkDNlw0JnfwfH92+ZVYp9WPWzz0X3zurLOgKw7FSieo0CEA76cE7gcuxvaB0u4fm915NDbnbcx5cr+JP+gzBZv20osqI4IeLL5ccpzrkWVCluf+Xpv2rRzOh1f4o/H3RAQB2r9ZOQKUO1uE+A1TMFuZuiJ5Flz5jwJeg/DE3NeNw8ftte+Esy5RAVodRsx/BJgoGI78JaCtY3G9fZBRb0lE1buhO6MeBJz0RLPRjGg7pTyLL4wSmecv/SbjPDsplRyc0i4VGgM+ISFylA2eTvRxJJqcQgI4qIdj8T0hIw0dWD5crWBNrTU4dGIvWpiOlQnSjWPv1GYCJqA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SV3ad587leBJRGbRDimL4fy0zcQF8lcarPSEVMf+60g=; b=dO1D7fRn3qfd8Zn9notYn05QU8/ZD9fXpHFCYTha2rrWG3vnA3H38IuYgG3jXBo4SlVuB3fLR3aC3r6ZG6g9iwdvCM3sQuO/zHhUWsLZWvLUHI2yckebWDsaarRvvq1IfuGCivF/fYh4aw7blnplOpdK+33VwDbGRYReyYuB4Do= Received: from AS8P189CA0035.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::17) by AM8PR08MB5763.eurprd08.prod.outlook.com (2603:10a6:20b:1d7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.20; Thu, 21 Dec 2023 05:58:56 +0000 Received: from AMS0EPF00000195.eurprd05.prod.outlook.com (2603:10a6:20b:458:cafe::9f) by AS8P189CA0035.outlook.office365.com (2603:10a6:20b:458::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.19 via Frontend Transport; Thu, 21 Dec 2023 05:58:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF00000195.mail.protection.outlook.com (10.167.16.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Thu, 21 Dec 2023 05:58:55 +0000 Received: ("Tessian outbound 8289ea11ec17:v228"); Thu, 21 Dec 2023 05:58:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 316409b1d01fef33 X-CR-MTA-TID: 64aa7808 Received: from 5f9b62f4531d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7FE8CBD3-5A8D-42D7-BC7B-90653FCF1399.1; Thu, 21 Dec 2023 05:58:45 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5f9b62f4531d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Dec 2023 05:58:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UCtBVlv1qccrX4uYMGuvaypvrl78IAYWRqFvdT6/JAaBSHW9L2GCkoaxPvU9g0nKGCtII+T94AGoFQS2L0On0+/softf8Ls3J1E7VAUFL0BUhwq6NeZQ5/3qBr8QIe5VmnbNvNy/rs1Fg9W+bXUHMe3BjnpnZqciFLcJUYTHsZHgT43qnMNsQCHsjfShny7/6k4hDkLL9ia9AJCdG0c4KzYx9weF70IJXgw0UgP0lLA/BsM7eY/sno+xXrbcWRNaRjs9g84d5XdD1XuK680SkVn/1nc++eE2RrbxJO5f4LKWdgSNENhoz/8r/bwb6VP2+juGc7+t7/Uu6gJvA4CaoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SV3ad587leBJRGbRDimL4fy0zcQF8lcarPSEVMf+60g=; b=FJwZn3Nez4fBmb8XPfJ7LChV0CSba2xetHIVuBiQ08jgaIbTC05yZxmhhq50wUtmPO6zFKwijG7g85iHkvrIUNORscg7NuWU/62C7wouuXjG9WojoGaW4V0feRqP5n2Ib1JIuHSceU8b9ehc8WdN7kTlILeB98fr17vyy02NxW5cy0SfdALQD54TbmN+5MJzKvlKq3H4Vin2vFTNSANzVzzfKfMolD14zBoUnJACURXAlb+HLXm8h14zt/7UB8EMUDqItv2pIrulJ1jCLOR2Wo+TTopp1uTQKNKe+TDxHup6P4y50i+vMFZhbt6U7XosSXgXZ6+NCsCKYad3mmnm0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SV3ad587leBJRGbRDimL4fy0zcQF8lcarPSEVMf+60g=; b=dO1D7fRn3qfd8Zn9notYn05QU8/ZD9fXpHFCYTha2rrWG3vnA3H38IuYgG3jXBo4SlVuB3fLR3aC3r6ZG6g9iwdvCM3sQuO/zHhUWsLZWvLUHI2yckebWDsaarRvvq1IfuGCivF/fYh4aw7blnplOpdK+33VwDbGRYReyYuB4Do= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) by VI1PR08MB5472.eurprd08.prod.outlook.com (2603:10a6:803:13b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.20; Thu, 21 Dec 2023 05:58:39 +0000 Received: from AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::715e:6aad:437c:9e22]) by AS8PR08MB7080.eurprd08.prod.outlook.com ([fe80::715e:6aad:437c:9e22%3]) with mapi id 15.20.7113.019; Thu, 21 Dec 2023 05:58:39 +0000 Message-ID: Date: Thu, 21 Dec 2023 13:58:25 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/13] hash: remove some dead code To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, stable@dpdk.org, Tyler Retzlaff , Yipeng Wang , Sameh Gobriel , Vladimir Medvedkin , Ray Kinsella , Dharmik Thakkar References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231220153607.718606-1-david.marchand@redhat.com> <20231220153607.718606-2-david.marchand@redhat.com> Content-Language: en-US From: Ruifeng Wang In-Reply-To: <20231220153607.718606-2-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SG3P274CA0008.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::20) To AS8PR08MB7080.eurprd08.prod.outlook.com (2603:10a6:20b:401::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB7080:EE_|VI1PR08MB5472:EE_|AMS0EPF00000195:EE_|AM8PR08MB5763:EE_ X-MS-Office365-Filtering-Correlation-Id: 86bfd27d-4ebf-46c7-4099-08dc01e9eaca X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NWnqMQMggTL4DCKRdUT0OfGFYVZthJQBaldw/7yLx0cULr9YQNlatENTLbkPjABJmKxBaGnZ7iUbu6n0xNomxNR/g4EQuNsnnWZ+uWHGSiknaFLDzqGTpnqCLE+xtDNnl+lTurQvA7aY3fXyDFTuCT27A22hlcqiuv9OOABeWg7/JidulR2DQ+FCn/3UJ8GL4NJfUKUsFl3/kpB46/I+BMUVJyNYimf9wco0k2Nau8H7VdCxikCAnD0JGW/asdfxTlu07ICZVGoBm3rudbd/QAdygMiGQFND1p5grE4vaguN1DtKuk6NsVnvtUXh3omuZCC6aJKamJdz5LC1n3AbvZ/tgJNYDMCQQgk26UbGztcHwkWW4MnqJUZdRAkWDGQ4JjqqCpKmtjaCjLHKBTx521wlel2nJr93momPgec1a5SSqEuuoyzgOPprH4P9L8QSOt+9SBZmo0VzmjRYEdJs2z9io8Jd6W9MqF6S3vHUQ9cN3BjSKtaPz7Ad6PjbLa1Qt9YHY2biZT6kZMsfuMU5B6tj4cY9ldXtIgBdx5U++PzKxZqPx+/UTMDSTsgoDlIoDhJK3J9WNENV87xnKwveFbhl8VGKvk8DB34L/LLRHR5X6kZuROg7n/RSrPvqULQYyFbIpWM9ETzY34blWA9s/w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB7080.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39850400004)(136003)(396003)(366004)(376002)(346002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(66556008)(66946007)(26005)(54906003)(66476007)(2616005)(478600001)(31686004)(8676002)(83380400001)(4326008)(8936002)(6666004)(316002)(6486002)(53546011)(36756003)(6506007)(6512007)(31696002)(7416002)(5660300002)(2906002)(38100700002)(41300700001)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5472 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000195.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6ba76658-dad7-4bda-014a-08dc01e9e0c1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gl3zAgNkRQN3VvNSJKWbZ7qP7jFoV8peKnyob/m9C3NY3hD6SUSDjExbJerViwD5GV1OLLvcp4AEX6Ug7/C5hYJ+VYTmS1j07ulFH51MjbzyntKcCdDvrgWcIufHbEPyN69tHRLf6CeP09Yzwtgvs8sNTpTBpplcxmnGb3IgwO3ydFMWdPNrk9vaDluYbo+3fVhJj78DclfiuialvMpf1L6kvFEGD8maD1UTGHUwUCdzgkSwfa+SYHo/5tSLIJ1Wg2aPjEq37Lm9v9K5sydgPIu6RkQ4FO3SgSMm15XIGhLZhTp3hKPuzDYH1OTpvN7JeaIsJdMZKLOQFybOsjuIPcGgYKGy4Ak3jRbOoTV7PWUZNdbi0C1B2AKd6dRKCFagD3FgmKS3Jl9WwDfpJ9NwFZhDxt/z2w0XxRwJNfGFrXQjb0cmFLkbOInOnxz4uEiMb124YoZfVV/8TFy/y64zvPoYcYggNm6vYUA/9wegmFk5QieZ07oP0wOLY/x2AyFvz+RRR7TtK/eNgxE8hiVf4GHUX9/88fgHKay1w4Eo091vfzFLpopwoxSy6b2UzIwHHtBn6tQ+8ZV4mYLEVaqZ7/oclFZ3gMwO1bFZv8phG3Xga00Y7VAytlu1TzzGuGkCKejQD5anf+8wJlaEuQn8op0r4QhFe1SpfleYpsgSrPGK8jxgYBGf7XL3RyeggkI4ODOv08KhPQRgc44zrywNXHs7kuBkT7TD5Tp+ypA0n7c7qbxH7pdfd8tsjcpl13rApTp6+qOMIC1uQJuTLn5g+g== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(396003)(136003)(346002)(39860400002)(230922051799003)(451199024)(64100799003)(82310400011)(1800799012)(186009)(46966006)(40470700004)(36840700001)(47076005)(5660300002)(2906002)(86362001)(31696002)(82740400003)(81166007)(356005)(41300700001)(36860700001)(70586007)(70206006)(40480700001)(2616005)(54906003)(26005)(336012)(316002)(6666004)(53546011)(36756003)(6512007)(6506007)(6486002)(31686004)(478600001)(40460700003)(8936002)(450100002)(8676002)(83380400001)(4326008)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 05:58:55.7117 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86bfd27d-4ebf-46c7-4099-08dc01e9eaca X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000195.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5763 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/12/20 11:35 PM, David Marchand wrote: > This macro is not used. > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > Reviewed-by: Stephen Hemminger > Reviewed-by: Tyler Retzlaff > --- > lib/hash/rte_cuckoo_hash.h | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/lib/hash/rte_cuckoo_hash.h b/lib/hash/rte_cuckoo_hash.h > index f7afc4dd79..8ea793c66e 100644 > --- a/lib/hash/rte_cuckoo_hash.h > +++ b/lib/hash/rte_cuckoo_hash.h > @@ -29,17 +29,6 @@ > #define RETURN_IF_TRUE(cond, retval) > #endif > > -#if defined(RTE_LIBRTE_HASH_DEBUG) > -#define ERR_IF_TRUE(cond, fmt, args...) do { \ > - if (cond) { \ > - RTE_LOG(ERR, HASH, fmt, ##args); \ > - return; \ > - } \ > -} while (0) > -#else > -#define ERR_IF_TRUE(cond, fmt, args...) > -#endif > - > #include > #include > Reviewed-by: Ruifeng Wang IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.