From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 03129A0C49;
	Thu,  8 Jul 2021 10:07:55 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B84CA4069C;
	Thu,  8 Jul 2021 10:07:55 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id DE7CB40687
 for <dev@dpdk.org>; Thu,  8 Jul 2021 10:07:54 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7963D7F514;
 Thu,  8 Jul 2021 11:07:54 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7963D7F514
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1625731674;
 bh=Rteg+3qECYsr+i7GWZvLiVWNWI+lFeweYm6974zvjdI=;
 h=Subject:To:References:From:Date:In-Reply-To;
 b=QnD3vlzCMEEAReNrLXBCMPol2G69A8dJZaTadZ46yc9j3fn/gT9pfmdnWclw5TEs4
 KExDBPqjp2MfHDL+nWLoPTTP44oaVVtJ0W82hcayrdYlhaLxDWkjG0ktlzqF0VDzH0
 NsNun/b4eGEU+1XeKyoGQMNCYA1JblQ+6bqGQHws=
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
References: <20210706095545.10776-1-jiawenwu@trustnetic.com>
 <20210706095545.10776-15-jiawenwu@trustnetic.com>
 <95f0f8d2-21f5-42c5-4c22-f811b5526f8d@oktetlabs.ru>
 <001f01d773bf$c175ce70$44616b50$@trustnetic.com>
 <e0d45353-7a5b-77b6-7fd5-81f63f182d24@oktetlabs.ru>
 <002001d773cd$de938a20$9bba9e60$@trustnetic.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <f35d2dab-6c3e-1372-cb27-9b8fce8b40aa@oktetlabs.ru>
Date: Thu, 8 Jul 2021 11:07:54 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <002001d773cd$de938a20$9bba9e60$@trustnetic.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v7 14/19] net/ngbe: add device start and stop
 operations
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/8/21 10:50 AM, Jiawen Wu wrote:
> On July 8, 2021 3:37 PM, Andrew Rybchenko wrote:
>> On 7/8/21 9:09 AM, Jiawen Wu wrote:
>>> On July 7, 2021 10:05 PM, Andrew Rybchenko wrote:
>>>> On 7/6/21 12:55 PM, Jiawen Wu wrote:
>>>>> Setup MSI-X interrupt, complete PHY configuration and set device
>>>>> link speed to start device. Disable interrupt, stop hardware and
>>>>> clear queues to stop device.
>>>>>
>>>>> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
>>>>
>>>> WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see
>>>> Documentation/timers/timers-howto.rst
>>>> #242: FILE: drivers/net/ngbe/base/ngbe_phy_mvl.c:70:
>>>> +                       msleep(1);
>>>>
>>>> Any comments?
>>>>
>>>
>>> This depends on the design of the hardware.
>>
>> Isn't is a problem if sleep will be longer in fact?
> 
> I thought about replacing it with 'msec_delay', but it is working right now.
> And 'msleep(1)' is also well used in the kernel driver, so I haven't changed it yet.

OK, I see.