From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CE66A0556; Mon, 17 Oct 2022 09:42:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5AB0440143; Mon, 17 Oct 2022 09:42:41 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 097C7400D7 for ; Mon, 17 Oct 2022 09:42:40 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3C95C5A; Mon, 17 Oct 2022 10:42:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3C95C5A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1665992559; bh=6JCYgkHKIPa7leO3RlYzHJuXrm6PGODsOum6P8URjqk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YLyOnb/yx5g5n7Dt5wNYLuxeg4DsRZMrp4pD7g+GF00J/ktp9Dv4xK3UJ5I4fQlCh UW/0vQuNGju9+CzvYnyruwvD2tgaCCCCKZlcuAujRU4yyWORcd3qpIjtpu7pHcHYmY PrtDOWCGNhD8wNVjcLIB8mF+jxvGdFBYeASYsGZs= Message-ID: Date: Mon, 17 Oct 2022 10:42:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v13 0/5] support error handling mode Content-Language: en-US To: Chengwen Feng , thomas@monjalon.net, ferruh.yigit@xilinx.com, ferruh.yigit@amd.com Cc: dev@dpdk.org, kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com, ajit.khaparde@broadcom.com, mdr@ashroe.eu References: <20220128124831.427-1-kalesh-anakkur.purayil@broadcom.com> <20221013124227.40123-1-fengchengwen@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20221013124227.40123-1-fengchengwen@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/13/22 15:42, Chengwen Feng wrote: > This patchset introduce error handling mode concept, the supported modes > are as follows: > > 1) PASSIVE: passive error handling, after the PMD detect that a reset > is required, the PMD reports RTE_ETH_EVENT_INTR_RESET event, and > application invoke rte_eth_dev_reset to recover the port. > > 2) PROACTIVE: proactive error handling, after the PMD detect that a reset > is required, the PMD reports RTE_ETH_EVENT_ERR_RECOVERING event, and do > recovery internally, finally, reports the recovery result event. > > Chengwen Feng (2): > ethdev: add error handling mode to device info > net/hns3: support proactive error handling mode > > Kalesh AP (3): > ethdev: support proactive error handling mode > app/testpmd: support error handling mode event > net/bnxt: support proactive error handling mode > > --- > v13: Address comments from Andrew (rework part of rst). > v12: Address comments from Andrew. > v11: Fix clang-static fail due wrong experimental placement. > v10: Accurately describe the recovery success scenario so that > addressed comments from Ferruh. > v9: Introduce error handling mode concept. > Addressed comments from Thomas and Ray. > v8: Addressed comments from Thomas and Ferruh. > Also introduced RECOVER_FAIL event. > Add hns3 driver patch. > v7: Addressed comments from Thomas and Andrew. > v6: Addressed comments from Asaf Penso. > 1. Updated 20.11 release notes with the new events added. > 2. updated testpmd parse_event_printing_config function. > v5: Addressed comments from Ophir Munk. > 1. Renamed the new event name to RTE_ETH_EVENT_ERR_RECOVERING. > 2. Fixed testpmd logs. > 3. Documented the new recovery events. > v4: Addressed comments from Thomas Monjalon > 1. Added doxygen comments about new events. > V3: Fixed a typo in commit log. > V2: Added a new event RTE_ETH_EVENT_RESET instead of using the > RTE_ETH_EVENT_INTR_RESET to notify applications about device reset. > > app/test-pmd/config.c | 15 +++++ > app/test-pmd/parameters.c | 10 +++- > app/test-pmd/testpmd.c | 8 ++- > doc/guides/prog_guide/poll_mode_drv.rst | 41 +++++++++++++ > doc/guides/rel_notes/release_22_11.rst | 12 ++++ > drivers/net/bnxt/bnxt_cpr.c | 4 ++ > drivers/net/bnxt/bnxt_ethdev.c | 13 ++++- > drivers/net/e1000/igb_ethdev.c | 2 + > drivers/net/ena/ena_ethdev.c | 2 + > drivers/net/hns3/hns3_common.c | 2 + > drivers/net/hns3/hns3_intr.c | 24 ++++++++ > drivers/net/iavf/iavf_ethdev.c | 2 + > drivers/net/ixgbe/ixgbe_ethdev.c | 2 + > drivers/net/txgbe/txgbe_ethdev_vf.c | 2 + > lib/ethdev/rte_ethdev.h | 77 +++++++++++++++++++++++++ > 15 files changed, 212 insertions(+), 4 deletions(-) > Applied to dpdk-next-net/main, thanks.