From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E73EE45C59; Sun, 3 Nov 2024 03:23:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8F52402A5; Sun, 3 Nov 2024 03:23:40 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2073.outbound.protection.outlook.com [40.107.100.73]) by mails.dpdk.org (Postfix) with ESMTP id C638B4026B for ; Sun, 3 Nov 2024 03:23:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ELMDvCjya9FuRlA+ZXU/7SQHKHyDSrcSWuPesBuuN9Xz/veS3fTN/4FGODiJ8gbOQwjbwdRMv/s5FfV3P+zUhwjK8GkaYyMahpKGKuJmpyBgxioSC2zqLrvnNPiPRexcUtE8NCHOdly2TlwXlxJ14ydGZ51NvwadicB7KdshSfmvDHJRFTHisoa1n6/FIx0CZ5lonSwqHZYyQDvsNkejvk5FoNcXKb/y2b655JMG85oG04OIFPx17QttRqT3hyI5FdT9l4dVtKCH5XQMMGXJ3Yy3prnemlAr5ro7oTa9wU8QGVcQ4oaP+Zb2nmPUsmyRnl5BIRFM9ueHXkYA8nxpOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lJsfUV5pLg4gRqYXbFvq3V1LpMf4ecWPeASzsyeYCD0=; b=CihXvvUmsOqu/0nd7P9g3VaxBLuAVMq0m0d9FRCHtwBigUlvgf3BsICMBFbkv9sCKiOhrHWrR22i7Vxc03bQ9C/bgnYF56mVsJIXrETygvUJVEu76Th6fyybLWePIc5F1YKVGJyGIAOqGgcntXnoSt9VGKFtfzdotB4325g5VNSVGo/xBcuelrpCkdysdj3BUD5Ln6NQbjYL/mmroPSvkx4fFdVmjPicVADxJ1G3M77I/3M98CVU5OcuhyWIJ98sq7tYGXUcD+UUK8YU3hIPRL6MFhyiIb9/2omslwYyEfrRTssvnx+GlB84ry0MowepZ8/pcThApumIAgk4pjl8fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lJsfUV5pLg4gRqYXbFvq3V1LpMf4ecWPeASzsyeYCD0=; b=yAU/FFhnlfplMZWZZ6aCdEMSK6OFgjUKLUkebYnvLprKE1prQYE7dKyTQv5B6RDBxEBvdH4cWt//fMeMCD0NNFqv6UzmdBIXZTKseTPkdBgyfsoBkVo52jzeEqdybqlG5LIVD+94WB7YZplzazc+RhyqDbJGkwKoxuliAzJms4U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SJ2PR12MB8925.namprd12.prod.outlook.com (2603:10b6:a03:542::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.29; Sun, 3 Nov 2024 02:23:36 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8114.015; Sun, 3 Nov 2024 02:23:36 +0000 Message-ID: Date: Sun, 3 Nov 2024 02:23:31 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/18] modify code as suggested by the maintainer To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241028073112.107535-1-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241028073112.107535-1-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0013.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::20) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SJ2PR12MB8925:EE_ X-MS-Office365-Filtering-Correlation-Id: 18ca2079-1b25-4863-373a-08dcfbae85b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QmhhSDRXQks3VU1SN2p0VDBXbjZOSzhOZE9vbEViOE43MTBGRW1COGhqK2Rx?= =?utf-8?B?VzYrYS9KVkd5WTNINm9HZlJHN2lpanBpeFUzeXRlQ0VQdGw1blZlZVNXalV2?= =?utf-8?B?QTBoU1B5V2JFMmhzd2hzSGQvN3R1MmNxRXZOOGEyYkNrN1kwV09TVURUTHpa?= =?utf-8?B?ZjBYbXBoM1I3MTRwS3cwT2ZGNHJTa1hNYWZKaG9hSGtUUXpNSFBEQ0tOWkRr?= =?utf-8?B?N0t0Ynl1MWx6TWlRa1pYV3pCNDNab1ZBWTR3QTloVzR2VTN3Tm5TRlJ2UHk3?= =?utf-8?B?c0Qyc1REbzZURTE1eDdLMnNuRDNrcUN6OGo2cFlSN2M0bHJwa3hwaStOV2lh?= =?utf-8?B?a21DTnZjNzFsZWQ3VFVEK3l6SDZhOFVzU2JmbGk0bms1aUlKcjlVRkh5R1I5?= =?utf-8?B?NlgyZHZLZHFzU241S1VmVm9ROVFOekViYnVFM2RQWk0xOGQ1M1MxcUJFakFQ?= =?utf-8?B?RE9tNGNZeGtva3lPRmZwVmpWeFFKQ2NtREg4VXZneTJiejg0MmV3eFpsdWVE?= =?utf-8?B?YnJTeDJhR1FIQ1RyS3E1THBSRGRQQjk4cVlBbE96emhwT0VoWmhuM05ZelFU?= =?utf-8?B?ZzU5dGxmNWFhTG4wdGxtcklGcElsYTJaRFdIOS91VU9mRythZlZpK0tvU2dB?= =?utf-8?B?aXZOSklUMWRrWDBETHdXNDRBcFVyaDFOejRzL2ZCVkQwdHVUM3RRSHR6L0R3?= =?utf-8?B?eDE3T2ZEbE54bjRhSkdMUGZVNHZpeXBRWmcvRXdYOXo0WjZDN2U3Z0JLUmJR?= =?utf-8?B?TXc0eTMrTkJ2eG9kUjIxRC9sWjluTWJudjByVVhJK2hGdFVKeGJYWEpaN0NO?= =?utf-8?B?eVJUS0JmLzZwdTh6cU9iei9yRFNZNkZEUE1JRDVFSjNZaW8wUlE1cUd5K2s3?= =?utf-8?B?U0hwcUpPSDZXc0lPTE1DUU1BMjBvcHZCWHZhVVRmazRONFd6anh2OUl0ajYx?= =?utf-8?B?ZDRSQUVNK2pzcjdCZlZzNkp4MCtlV081aGt5ZUZ1U1YyVHNSanM0eFNZOGt6?= =?utf-8?B?ZllZN0EzeVd2bEkwQ0tLTlkxMkFrM1VnYnhVSUNBdzRhUVZMOVpVZzBjY1M2?= =?utf-8?B?b1h5dVBib0tvNnBZUnFFb3Bid2FyUlgyM2pwSnVlUjQvbzBjODhOYVV3VGZB?= =?utf-8?B?QU5KVlVQT2NKVEljaGVlNnNraldNSFpkNnlhNEgvd3cxeUNkWTRieXNJZlV1?= =?utf-8?B?aXFZejhWdkwzbWdxRFp4NVlLMWdmR3VYOFo3M3hMbDFXc05DZWlYZmdrcWZj?= =?utf-8?B?L0RselY1S3NDWFExNHNJSEo2Q0NiR1FOTWtNOWd3QlZiMElwTVRpREVWbFZr?= =?utf-8?B?M3FoSHJVbFNlUmRlczdGazRwdmdvaCtBcjZML2lDQmFkYkRNMXcrYnd0aU42?= =?utf-8?B?T01LL1BWR1JTbDkybWU0YndVZk1hemNZRUgycWJ0MEp1LzhIM3NEbERrc09x?= =?utf-8?B?MDRVVHc3amdNZDlRNnRhT0xMaWVqNXNmT3VlNEpjMXhTVThHRldaeXlsRUZ4?= =?utf-8?B?RVhDRitsRlM1T1NRcDQzRE5NK1RrSmRvL3VPcUJJamVKR25xbCt4b2lhUTRt?= =?utf-8?B?NDZacWMvcDArWUVEMXJWUXRCWGZGK0tsZ3JKWlJYZjdxb2JnWlZGUEVSUGVX?= =?utf-8?B?Uk9OQ3M4ZmVLTzRGeDZOT0pYZytNOTlpL3NmSjlTRkFLSGp2T3ZjYmtwbjBr?= =?utf-8?B?YU0zUndlWXM4WjBmeW9LNG01Z3ArYVBXdU5MQndML3FJK3NlL1N4bUNoTWVP?= =?utf-8?Q?lzg9XbwHvOkKAdceAI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnBCWEx5OUJ0OVYvK3RhVzJ0NlRrdGFMakZ4UW4yd1JhVDE3Mld0b1RQOU4y?= =?utf-8?B?dkMrTnpoNnBzUFc3UjQ3QTJLRmpBSStUYnpEUXZMZkNNQlRRQkRwYkpOUnpx?= =?utf-8?B?WUNMMy9tYTJvS1BDSUxjSFY1YUlwR1krOEhmbEFwY0hOM0hocHhGYUJ6enRt?= =?utf-8?B?dlRJQ3ErSitDUUttT2lqR29hOFYwUE5URzVzV3UyUjljRXpqOExadG1TQzFq?= =?utf-8?B?RUpUd21FZmxsQlhKSGRDVCtVUGE1MlFlYXk0UEEwOHBGaWZjM3Fia0Exdm9G?= =?utf-8?B?MEhzTzBXYUUyL3o0Wm4vN1FxenJrSGhueGFwM0hobDVGR1BwUk8zRVErcnB4?= =?utf-8?B?NDdqTEN5TUZseFhEcmNCTnFYbFV2OGdScXNwbURyVXlyU3lRWUk3YWJGbEtD?= =?utf-8?B?YjMxWG0xc3N3L29UTndtV0x2USsrSVNackNsT0Ezc2FBRVhScG5rdDMvbjVL?= =?utf-8?B?RjR5Tm1OM0hnU3FUK0Fac2lycytMckdpdHlNcEdrcTgyUDZaVTI5cHFKQnVr?= =?utf-8?B?dWtNVlh0R0FOVWZSSDBKMTJTQWtMWjdsd1haNHRHdGdaWEFXMWtNQWlSNWIr?= =?utf-8?B?N2N2MlorMDY4aDlvKzNKMExjMUw0eU8xdDY3QlcvbjFTM2pwL2lvaVNNNUYz?= =?utf-8?B?K2tsYWZiZlVuaDV6K1hoZzNvc1o1dWRqTWhxbzVsVXk1bXJMdURMVjF2N1J4?= =?utf-8?B?dGcvdVN3QnJibUFDK1JHVDFUVnJtOWlubVRXaHBzYVpWY0J1Z0g2OWNJQm92?= =?utf-8?B?dERWRU9tc3hqa2U5K1pJOTh0YzRtQTRZMVVvdFlWc0FLV1BJaUtCWEhDZ2tG?= =?utf-8?B?WlJqdXY0NTRuVXM3L1k0Q2FVOWtuV3NyTFhRdU5QSE9qa09scGJwcFBMR2Vw?= =?utf-8?B?dTRQTXYxNVJzZDlQdUJueGQ1dmVzL1MydVdUOEV5MXNjNXBkOVI3NVRSd1RD?= =?utf-8?B?V3BlOURhaGt6R0d6ckp5K1F1cTQ5cnROSnY3Z1kxTkRwWHRBQzVidlRpdngv?= =?utf-8?B?UElITTlNKzdobGE3NFF6dng3ZWk0ZUpwZURDRVAvSmJVQW55aFNGZXR6Szd0?= =?utf-8?B?U3d3cVVSTENNMThaTjlTK0FFNUkyZDJTaXpBV2w3TCtxZ280S2N4UkxjME9k?= =?utf-8?B?eGpVMU45WmZMbVJFOUN1eGFoc3QrMHFLNXVxWGtWS0VSYTI2Vk9mNnlQbVJF?= =?utf-8?B?QkROMkhTSTR2dGpzcGxTMFc0TGtmU1ZYNTUyK3FaUTIxTjVHSlp4T0FCTktY?= =?utf-8?B?azUwdFVFT1ZsbG1CY2V5RWRNZlNuZGpnR3RQbEJhRzB4d3p6Q2VzRzJ4R0RZ?= =?utf-8?B?RkFRSXFzZEMwSDZpVkJTeSs4eFIrcEJRS2labGhidVhCN3YzZ1VYa2NSZHpo?= =?utf-8?B?ODFIM20wUVF5dEhXR0VuTVZEaWJLSmhydnhZbGRTWTZDNjdaWXFOVXJWTE1j?= =?utf-8?B?WUVkRUFPRjU2TnVEQ2tHbndiUFZjSHVzUTcxZ1VrN0JGZWpBTVQzSEhHRElR?= =?utf-8?B?cXVkK3FBRTBGbFRiRXJ1dFhCUFhJOFZRdDNZQmdGUi8wTEhlYVgvNDZZMUZ6?= =?utf-8?B?SzVlQmhkUGlpbWlJTlFVZ2tBWVlXa2JUQzU2ZGpFOGFkRXB6dEp0MVArdE5P?= =?utf-8?B?NnZndFlqWGhWWml6cWZGQlA2czh0STk2eUFNd21zYi90OGdqc2lSZkx3S2oz?= =?utf-8?B?MTFmS1B0a3pHYjlnMzl6MFhJYW81eGhKRE50akhEbUI0OEN4ZW01RFpQQi9I?= =?utf-8?B?S0VuSFlTck1rcUVkejJIZmlsd1JFcTExd1MrZjJtWjkyaVd5aGtpL1d6UFd5?= =?utf-8?B?UE5qZ1FhVzJjMnRQNDNFTUlBMVcyZEVoSm1VeDV3dWdrYkl0QWJJcW5WdXR2?= =?utf-8?B?V1kwRmF6eVRuMzVsbTBOMVg5a3hnNG9zdzhtSFVCeGJJZW1QN0pmWkJzUlZ1?= =?utf-8?B?OXJlZGFFY3Y3dHBpVlFyRUVjNnRDbTFaVXlnQnFhYjE5YmpPNFlEcTR0S01r?= =?utf-8?B?YjJjSFk3RU5GQ0ExTG43azZBYVVFTDlXc0tvVzkzZkZrb1krZmxkd25hMG90?= =?utf-8?B?RDJiOUJhcUVObE1kd3g0RnhhM0haOWpyNnVKMVZHU0pBQjZJMElsU2djRjAw?= =?utf-8?Q?3/K+tTlxsZPyfw1PuzTEKbiF2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18ca2079-1b25-4863-373a-08dcfbae85b9 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2024 02:23:36.8141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HR9B5RPkp22L5CcxUTUnu8lYL65Yvejt8D/sn3OaEWx4xboR73dV2ii2Xm2L/ilo X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8925 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/28/2024 7:30 AM, Howard Wang wrote: > Fix some warning issues. > > Howard Wang (18): > net/r8169: add PMD driver skeleton > net/r8169: add logging structure > net/r8169: add hardware registers access routines > net/r8169: implement core logic for Tx/Rx > net/r8169: add support for hw config > net/r8169: add phy registers access routines > net/r8169: add support for hardware operations > net/r8169: add support for phy configuration > net/r8169: add support for hw initialization > net/r8169: add link status and interrupt management > net/r8169: implement Rx path > net/r8169: implement Tx path > net/r8169: implement device statistics > net/r8169: implement promisc and allmulti modes > net/r8169: implement MTU configuration > net/r8169: add support for getting fw version > net/r8169: add driver_start and driver_stop > doc/guides/nics: add documents for r8169 pmd > Hi Howard, Thanks for restructuring the patch series, it looks better now, I put some comments. Btw, there are many "Avoid CamelCase" checkpatch warning, if this code is not shared (but developed for DPDK), can you please address the warnings?