[dpdk-dev] [PATCH] examples/vmdq: fix the output of pools/queues

DPDK patches and discussions
 help / color / mirror / Atom feed

* [dpdk-dev] [PATCH] examples/vmdq: fix the output of pools/queues
@ 2020-02-26  7:57 Junyu Jiang
  2020-02-26  8:35 ` [dpdk-dev] [PATCH v2] " Junyu Jiang
  0 siblings, 1 reply; 8+ messages in thread
From: Junyu Jiang @ 2020-02-26  7:57 UTC (permalink / raw)
  To: dev; +Cc: Xiaoyun Li, Junyu Jiang, stable

To match the pools/queues configuration, the pools/queues output
should start from VMDQ base queue. This patch fixed the issue.

Fixes: 6bb97df521aa ("examples/vmdq: new app")
Cc: stable@dpdk.org

Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
---
 examples/vmdq/main.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c
index 011110920..592f9bc62 100644
--- a/examples/vmdq/main.c
+++ b/examples/vmdq/main.c
@@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m, unsigned dst_port)
 static void
 sighup_handler(int signum)
 {
-	unsigned q;
-	for (q = 0; q < num_queues; q++) {
-		if (q % (num_queues/num_pools) == 0)
-			printf("\nPool %u: ", q/(num_queues/num_pools));
+	unsigned q = vmdq_queue_base;;
+	for (; q < num_queues; q++) {
+		if (q % (num_vmdq_queues / num_pools) == 0)
+			printf("\nPool %u: ", (q - vmdq_queue_base) /
+			       (num_vmdq_queues / num_pools));
 		printf("%lu ", rxPackets[q]);
 	}
 	printf("\nFinished handling signal %d\n", signum);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v2] examples/vmdq: fix the output of pools/queues
  2020-02-26  7:57 [dpdk-dev] [PATCH] examples/vmdq: fix the output of pools/queues Junyu Jiang
@ 2020-02-26  8:35 ` Junyu Jiang
  2020-03-02  2:35   ` Yang, Qiming
                     ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Junyu Jiang @ 2020-02-26  8:35 UTC (permalink / raw)
  To: dev; +Cc: Xiaoyun Li, Junyu Jiang, stable

To match the pools/queues configuration, the pools/queues output
should start from VMDQ base queue. This patch fixed the issue.

Fixes: 6bb97df521aa ("examples/vmdq: new app")
Cc: stable@dpdk.org

Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
---
 examples/vmdq/main.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c
index 011110920..dcba3a708 100644
--- a/examples/vmdq/main.c
+++ b/examples/vmdq/main.c
@@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m, unsigned dst_port)
 static void
 sighup_handler(int signum)
 {
-	unsigned q;
-	for (q = 0; q < num_queues; q++) {
-		if (q % (num_queues/num_pools) == 0)
-			printf("\nPool %u: ", q/(num_queues/num_pools));
+	unsigned int q = vmdq_queue_base;
+	for (; q < num_queues; q++) {
+		if (q % (num_vmdq_queues / num_pools) == 0)
+			printf("\nPool %u: ", (q - vmdq_queue_base) /
+			       (num_vmdq_queues / num_pools));
 		printf("%lu ", rxPackets[q]);
 	}
 	printf("\nFinished handling signal %d\n", signum);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] examples/vmdq: fix the output of pools/queues
  2020-02-26  8:35 ` [dpdk-dev] [PATCH v2] " Junyu Jiang
@ 2020-03-02  2:35   ` Yang, Qiming
  2020-03-02  3:10   ` Li, Xiaoyun
  2020-03-02  6:41   ` [dpdk-dev] [PATCH v3] " Junyu Jiang
  2 siblings, 0 replies; 8+ messages in thread
From: Yang, Qiming @ 2020-03-02  2:35 UTC (permalink / raw)
  To: Jiang, JunyuX, dev; +Cc: Li, Xiaoyun, Jiang, JunyuX, stable



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junyu Jiang
> Sent: Wednesday, February 26, 2020 16:35
> To: dev@dpdk.org
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Jiang, JunyuX
> <junyux.jiang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] examples/vmdq: fix the output of
> pools/queues
> 
> To match the pools/queues configuration, the pools/queues output should
> start from VMDQ base queue. This patch fixed the issue.
> 
> Fixes: 6bb97df521aa ("examples/vmdq: new app")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  examples/vmdq/main.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index
> 011110920..dcba3a708 100644
> --- a/examples/vmdq/main.c
> +++ b/examples/vmdq/main.c
> @@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m,
> unsigned dst_port)  static void  sighup_handler(int signum)  {
> -	unsigned q;
> -	for (q = 0; q < num_queues; q++) {
> -		if (q % (num_queues/num_pools) == 0)
> -			printf("\nPool %u: ", q/(num_queues/num_pools));
> +	unsigned int q = vmdq_queue_base;
> +	for (; q < num_queues; q++) {
> +		if (q % (num_vmdq_queues / num_pools) == 0)

What's the different between num_vmdq_queues and num_queues?

> +			printf("\nPool %u: ", (q - vmdq_queue_base) /
> +			       (num_vmdq_queues / num_pools));
>  		printf("%lu ", rxPackets[q]);
>  	}
>  	printf("\nFinished handling signal %d\n", signum);
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] examples/vmdq: fix the output of pools/queues
  2020-02-26  8:35 ` [dpdk-dev] [PATCH v2] " Junyu Jiang
  2020-03-02  2:35   ` Yang, Qiming
@ 2020-03-02  3:10   ` Li, Xiaoyun
  2020-03-02  6:41   ` [dpdk-dev] [PATCH v3] " Junyu Jiang
  2 siblings, 0 replies; 8+ messages in thread
From: Li, Xiaoyun @ 2020-03-02  3:10 UTC (permalink / raw)
  To: Jiang, JunyuX, dev; +Cc: stable

Hi

> -----Original Message-----
> From: Jiang, JunyuX
> Sent: Wednesday, February 26, 2020 16:35
> To: dev@dpdk.org
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Jiang, JunyuX <junyux.jiang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v2] examples/vmdq: fix the output of pools/queues
> 
> To match the pools/queues configuration, the pools/queues output should start
> from VMDQ base queue. This patch fixed the issue.
> 
> Fixes: 6bb97df521aa ("examples/vmdq: new app")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  examples/vmdq/main.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index
> 011110920..dcba3a708 100644
> --- a/examples/vmdq/main.c
> +++ b/examples/vmdq/main.c
> @@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m, unsigned
> dst_port)  static void  sighup_handler(int signum)  {
> -	unsigned q;
> -	for (q = 0; q < num_queues; q++) {
> -		if (q % (num_queues/num_pools) == 0)
> -			printf("\nPool %u: ", q/(num_queues/num_pools));
> +	unsigned int q = vmdq_queue_base;
> +	for (; q < num_queues; q++) {
> +		if (q % (num_vmdq_queues / num_pools) == 0)

 In your logic, this should be if ((q - vmdq_queue_base) % (num_vmdq_queues / num_pools) == 0)

> +			printf("\nPool %u: ", (q - vmdq_queue_base) /
> +			       (num_vmdq_queues / num_pools));
>  		printf("%lu ", rxPackets[q]);
>  	}
>  	printf("\nFinished handling signal %d\n", signum);
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v3] examples/vmdq: fix the output of pools/queues
  2020-02-26  8:35 ` [dpdk-dev] [PATCH v2] " Junyu Jiang
  2020-03-02  2:35   ` Yang, Qiming
  2020-03-02  3:10   ` Li, Xiaoyun
@ 2020-03-02  6:41   ` Junyu Jiang
  2020-03-02  7:19     ` Li, Xiaoyun
  2 siblings, 1 reply; 8+ messages in thread
From: Junyu Jiang @ 2020-03-02  6:41 UTC (permalink / raw)
  To: dev; +Cc: Xiaoyun Li, Qiming Yang, Junyu Jiang, stable

To match the pools/queues configuration, the pools/queues output
should start from VMDQ base queue. This patch fixed the issue.

Fixes: 6bb97df521aa ("examples/vmdq: new app")
Cc: stable@dpdk.org

Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
---
 examples/vmdq/main.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c
index 011110920..5ab3427c0 100644
--- a/examples/vmdq/main.c
+++ b/examples/vmdq/main.c
@@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m, unsigned dst_port)
 static void
 sighup_handler(int signum)
 {
-	unsigned q;
-	for (q = 0; q < num_queues; q++) {
-		if (q % (num_queues/num_pools) == 0)
-			printf("\nPool %u: ", q/(num_queues/num_pools));
+	unsigned int q = vmdq_queue_base;
+	for (; q < num_queues; q++) {
+		if ((q - vmdq_queue_base) % (num_vmdq_queues / num_pools) == 0)
+			printf("\nPool %u: ", (q - vmdq_queue_base) /
+			       (num_vmdq_queues / num_pools));
 		printf("%lu ", rxPackets[q]);
 	}
 	printf("\nFinished handling signal %d\n", signum);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v3] examples/vmdq: fix the output of pools/queues
  2020-03-02  6:41   ` [dpdk-dev] [PATCH v3] " Junyu Jiang
@ 2020-03-02  7:19     ` Li, Xiaoyun
  2020-03-30  2:21       ` [dpdk-dev] [dpdk-stable] " Han, YingyaX
  0 siblings, 1 reply; 8+ messages in thread
From: Li, Xiaoyun @ 2020-03-02  7:19 UTC (permalink / raw)
  To: Jiang, JunyuX, dev; +Cc: Yang, Qiming, stable

Hi
> -----Original Message-----
> From: Jiang, JunyuX
> Sent: Monday, March 2, 2020 14:41
> To: dev@dpdk.org
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> Jiang, JunyuX <junyux.jiang@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] examples/vmdq: fix the output of pools/queues
> 
> To match the pools/queues configuration, the pools/queues output should start
> from VMDQ base queue. This patch fixed the issue.
> 
> Fixes: 6bb97df521aa ("examples/vmdq: new app")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  examples/vmdq/main.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index
> 011110920..5ab3427c0 100644
> --- a/examples/vmdq/main.c
> +++ b/examples/vmdq/main.c
> @@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m, unsigned
> dst_port)  static void  sighup_handler(int signum)  {
> -	unsigned q;
> -	for (q = 0; q < num_queues; q++) {
> -		if (q % (num_queues/num_pools) == 0)
> -			printf("\nPool %u: ", q/(num_queues/num_pools));
> +	unsigned int q = vmdq_queue_base;
> +	for (; q < num_queues; q++) {
> +		if ((q - vmdq_queue_base) % (num_vmdq_queues / num_pools)
> == 0)
> +			printf("\nPool %u: ", (q - vmdq_queue_base) /
> +			       (num_vmdq_queues / num_pools));
>  		printf("%lu ", rxPackets[q]);
>  	}
>  	printf("\nFinished handling signal %d\n", signum);
> --
> 2.17.1

Acked-by: Xiaoyun Li <Xiaoyun.li@intel.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v3] examples/vmdq: fix the output of pools/queues
  2020-03-02  7:19     ` Li, Xiaoyun
@ 2020-03-30  2:21       ` Han, YingyaX
  2020-03-31 14:35         ` Ferruh Yigit
  0 siblings, 1 reply; 8+ messages in thread
From: Han, YingyaX @ 2020-03-30  2:21 UTC (permalink / raw)
  To: Li, Xiaoyun, Jiang, JunyuX, dev; +Cc: Yang, Qiming, stable

Tested-by: Han,YingyaX <yingyax.han@intel.com>

BRs,
Yingya
-----Original Message-----
From: stable <stable-bounces@dpdk.org> On Behalf Of Li, Xiaoyun
Sent: Monday, March 2, 2020 3:19 PM
To: Jiang, JunyuX <junyux.jiang@intel.com>; dev@dpdk.org
Cc: Yang, Qiming <qiming.yang@intel.com>; stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3] examples/vmdq: fix the output of pools/queues

Hi
> -----Original Message-----
> From: Jiang, JunyuX
> Sent: Monday, March 2, 2020 14:41
> To: dev@dpdk.org
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Yang, Qiming 
> <qiming.yang@intel.com>; Jiang, JunyuX <junyux.jiang@intel.com>; 
> stable@dpdk.org
> Subject: [PATCH v3] examples/vmdq: fix the output of pools/queues
> 
> To match the pools/queues configuration, the pools/queues output 
> should start from VMDQ base queue. This patch fixed the issue.
> 
> Fixes: 6bb97df521aa ("examples/vmdq: new app")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
> ---
>  examples/vmdq/main.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index
> 011110920..5ab3427c0 100644
> --- a/examples/vmdq/main.c
> +++ b/examples/vmdq/main.c
> @@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m, unsigned
> dst_port)  static void  sighup_handler(int signum)  {
> -	unsigned q;
> -	for (q = 0; q < num_queues; q++) {
> -		if (q % (num_queues/num_pools) == 0)
> -			printf("\nPool %u: ", q/(num_queues/num_pools));
> +	unsigned int q = vmdq_queue_base;
> +	for (; q < num_queues; q++) {
> +		if ((q - vmdq_queue_base) % (num_vmdq_queues / num_pools)
> == 0)
> +			printf("\nPool %u: ", (q - vmdq_queue_base) /
> +			       (num_vmdq_queues / num_pools));
>  		printf("%lu ", rxPackets[q]);
>  	}
>  	printf("\nFinished handling signal %d\n", signum);
> --
> 2.17.1

Acked-by: Xiaoyun Li <Xiaoyun.li@intel.com>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH v3] examples/vmdq: fix the output of pools/queues
  2020-03-30  2:21       ` [dpdk-dev] [dpdk-stable] " Han, YingyaX
@ 2020-03-31 14:35         ` Ferruh Yigit
  0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2020-03-31 14:35 UTC (permalink / raw)
  To: Han, YingyaX, Li, Xiaoyun, Jiang, JunyuX, dev; +Cc: Yang, Qiming, stable

On 3/30/2020 3:21 AM, Han, YingyaX wrote:
> Tested-by: Han,YingyaX <yingyax.han@intel.com>
> 
> BRs,
> Yingya
> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of Li, Xiaoyun
> Sent: Monday, March 2, 2020 3:19 PM
> To: Jiang, JunyuX <junyux.jiang@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v3] examples/vmdq: fix the output of pools/queues
> 
> Hi
>> -----Original Message-----
>> From: Jiang, JunyuX
>> Sent: Monday, March 2, 2020 14:41
>> To: dev@dpdk.org
>> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>; Yang, Qiming 
>> <qiming.yang@intel.com>; Jiang, JunyuX <junyux.jiang@intel.com>; 
>> stable@dpdk.org
>> Subject: [PATCH v3] examples/vmdq: fix the output of pools/queues
>>
>> To match the pools/queues configuration, the pools/queues output 
>> should start from VMDQ base queue. This patch fixed the issue.
>>
>> Fixes: 6bb97df521aa ("examples/vmdq: new app")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
>> ---
>>  examples/vmdq/main.c | 9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index
>> 011110920..5ab3427c0 100644
>> --- a/examples/vmdq/main.c
>> +++ b/examples/vmdq/main.c
>> @@ -441,10 +441,11 @@ update_mac_address(struct rte_mbuf *m, unsigned
>> dst_port)  static void  sighup_handler(int signum)  {
>> -	unsigned q;
>> -	for (q = 0; q < num_queues; q++) {
>> -		if (q % (num_queues/num_pools) == 0)
>> -			printf("\nPool %u: ", q/(num_queues/num_pools));
>> +	unsigned int q = vmdq_queue_base;
>> +	for (; q < num_queues; q++) {
>> +		if ((q - vmdq_queue_base) % (num_vmdq_queues / num_pools)
>> == 0)
>> +			printf("\nPool %u: ", (q - vmdq_queue_base) /
>> +			       (num_vmdq_queues / num_pools));
>>  		printf("%lu ", rxPackets[q]);
>>  	}
>>  	printf("\nFinished handling signal %d\n", signum);
>> --
>> 2.17.1
> 
> Acked-by: Xiaoyun Li <Xiaoyun.li@intel.com>
> 

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2020-03-31 14:36 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26  7:57 [dpdk-dev] [PATCH] examples/vmdq: fix the output of pools/queues Junyu Jiang
2020-02-26  8:35 ` [dpdk-dev] [PATCH v2] " Junyu Jiang
2020-03-02  2:35   ` Yang, Qiming
2020-03-02  3:10   ` Li, Xiaoyun
2020-03-02  6:41   ` [dpdk-dev] [PATCH v3] " Junyu Jiang
2020-03-02  7:19     ` Li, Xiaoyun
2020-03-30  2:21       ` [dpdk-dev] [dpdk-stable] " Han, YingyaX
2020-03-31 14:35         ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).