DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ranjit Menon <ranjit.menon@intel.com>
To: Tal Shnaiderman <talshn@nvidia.com>, dev@dpdk.org
Cc: thomas@monjalon.net, pallavi.kadam@intel.com,
	dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com,
	dmitrym@microsoft.com, olivier.matz@6wind.com,
	arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [PATCH] mempool/ring: build on Windows
Date: Thu, 24 Sep 2020 14:09:45 -0700	[thread overview]
Message-ID: <f39c8061-2645-562d-edd0-cc4916ecd228@intel.com> (raw)
In-Reply-To: <20200916104204.10432-1-talshn@nvidia.com>

On 9/16/2020 3:42 AM, Tal Shnaiderman wrote:
> Build the ring mempool handler for Windows OS.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
>   drivers/mempool/bucket/meson.build    | 5 +++++
>   drivers/mempool/meson.build           | 4 ----
>   drivers/mempool/octeontx/meson.build  | 5 +++++
>   drivers/mempool/octeontx2/meson.build | 5 +++++
>   drivers/mempool/stack/meson.build     | 5 +++++
>   5 files changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mempool/bucket/meson.build b/drivers/mempool/bucket/meson.build
> index 618d791283..61de2dc9b9 100644
> --- a/drivers/mempool/bucket/meson.build
> +++ b/drivers/mempool/bucket/meson.build
> @@ -6,4 +6,9 @@
>   # This software was jointly developed between OKTET Labs (under contract
>   # for Solarflare) and Solarflare Communications, Inc.
>   
> +if is_windows
> +	build = false
> +	reason = 'not supported on Windows'
> +endif
> +
>   sources = files('rte_mempool_bucket.c')
> diff --git a/drivers/mempool/meson.build b/drivers/mempool/meson.build
> index c9609f1453..7520e489f4 100644
> --- a/drivers/mempool/meson.build
> +++ b/drivers/mempool/meson.build
> @@ -1,10 +1,6 @@
>   # SPDX-License-Identifier: BSD-3-Clause
>   # Copyright(c) 2017 Intel Corporation
>   
> -if is_windows
> -	subdir_done()
> -endif
> -
>   drivers = ['bucket', 'dpaa', 'dpaa2', 'octeontx', 'octeontx2', 'ring', 'stack']
>   std_deps = ['mempool']
>   config_flag_fmt = 'RTE_LIBRTE_@0@_MEMPOOL'
> diff --git a/drivers/mempool/octeontx/meson.build b/drivers/mempool/octeontx/meson.build
> index 3baaf7db25..b5695a9329 100644
> --- a/drivers/mempool/octeontx/meson.build
> +++ b/drivers/mempool/octeontx/meson.build
> @@ -1,6 +1,11 @@
>   # SPDX-License-Identifier: BSD-3-Clause
>   # Copyright(c) 2017 Cavium, Inc
>   
> +if is_windows
> +	build = false
> +	reason = 'not supported on Windows'
> +endif
> +
>   sources = files('octeontx_fpavf.c',
>   		'rte_mempool_octeontx.c'
>   )
> diff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build
> index 9fde40f0e9..0226f76d4b 100644
> --- a/drivers/mempool/octeontx2/meson.build
> +++ b/drivers/mempool/octeontx2/meson.build
> @@ -2,6 +2,11 @@
>   # Copyright(C) 2019 Marvell International Ltd.
>   #
>   
> +if is_windows
> +	build = false
> +	reason = 'not supported on Windows'
> +endif
> +
>   sources = files('otx2_mempool_ops.c',
>   		'otx2_mempool.c',
>   		'otx2_mempool_irq.c',
> diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build
> index 580dde79eb..8425772a42 100644
> --- a/drivers/mempool/stack/meson.build
> +++ b/drivers/mempool/stack/meson.build
> @@ -1,6 +1,11 @@
>   # SPDX-License-Identifier: BSD-3-Clause
>   # Copyright(c) 2017-2019 Intel Corporation
>   
> +if is_windows
> +	build = false
> +	reason = 'not supported on Windows'
> +endif
> +
>   sources = files('rte_mempool_stack.c')
>   
>   deps += ['stack']

Acked-by: Ranjit Menon <ranjit.menon@intel.com



  reply	other threads:[~2020-09-24 21:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 10:42 Tal Shnaiderman
2020-09-24 21:09 ` Ranjit Menon [this message]
2020-10-05  7:58   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f39c8061-2645-562d-edd0-cc4916ecd228@intel.com \
    --to=ranjit.menon@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=olivier.matz@6wind.com \
    --cc=pallavi.kadam@intel.com \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).