From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, john.mcnamara@intel.com, zhihong.wang@intel.com,
qian.q.xu@intel.com, yu.y.liu@intel.com, lei.a.yao@intel.com,
maxime.coquelin@redhat.com
Subject: Re: [dpdk-dev] [PATCH] Revert "mem: allocate in reverse to reduce fragmentation"
Date: Thu, 26 Jul 2018 10:30:28 +0100 [thread overview]
Message-ID: <f39d6c72-ae6a-9832-01fd-bf9f5d211e28@intel.com> (raw)
In-Reply-To: <23947652.nx9p32IzIJ@xps>
On 26-Jul-18 10:18 AM, Thomas Monjalon wrote:
> 24/07/2018 14:21, Anatoly Burakov:
>> This reverts commit 179f916e88e4a0fdd5ad4d20e226771d3d271c41.
>>
>> A few regressions with virtio/vhost have been discovered, due to the
>> strong dependency of virtio/vhost on the underlying memory layout.
>> Specifically, virtio/vhost share all memory pages starting from the
>> beginning of the segment, while the patch above made it so that the
>> memory is always allocated from the top of VA space, not from the
>> bottom.
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Applied with this fun title:
> mem: revert reversed allocation
>
Next time i'll submit a patch which will revert reverted reverse
allocation :)
--
Thanks,
Anatoly
prev parent reply other threads:[~2018-07-26 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 12:21 Anatoly Burakov
2018-07-26 9:18 ` Thomas Monjalon
2018-07-26 9:30 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f39d6c72-ae6a-9832-01fd-bf9f5d211e28@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=lei.a.yao@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=qian.q.xu@intel.com \
--cc=thomas@monjalon.net \
--cc=yu.y.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).