From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id A605B1B6CD;
Fri, 22 Mar 2019 18:03:22 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
[10.5.11.14])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 958D530821F9;
Fri, 22 Mar 2019 17:03:21 +0000 (UTC)
Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B51C5D9CC;
Fri, 22 Mar 2019 17:03:16 +0000 (UTC)
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com,
ramirose@gmail.com, arybchenko@solarflare.com, ferruh.yigit@intel.com,
stable@dpdk.org
References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com>
<1553261824-1881-1-git-send-email-david.marchand@redhat.com>
<1553261824-1881-2-git-send-email-david.marchand@redhat.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <f39da0da-0170-9dbe-f67c-882aec819cbd@redhat.com>
Date: Fri, 22 Mar 2019 18:03:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <1553261824-1881-2-git-send-email-david.marchand@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.47]); Fri, 22 Mar 2019 17:03:21 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when
showing statistics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Mar 2019 17:03:23 -0000
On 3/22/19 2:37 PM, David Marchand wrote:
> Having the standard stats and the rx burst stats on the same line gives a
> really long line and is not consistent with the rest.
>
> Before:
> RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
> TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
>
> After:
> RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0
> RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
> TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> Changelog since v2:
> - Cc'd stable
>
> ---
> app/test-pmd/testpmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 216be47..40199c1 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1459,7 +1459,7 @@ struct extmem_param {
> "TX Port=%2d/Queue=%2d %s\n",
> fwd_top_stats_border, fs->rx_port, fs->rx_queue,
> fs->tx_port, fs->tx_queue, fwd_top_stats_border);
> - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u",
> + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n",
> fs->rx_packets, fs->tx_packets, fs->fwd_dropped);
>
> /* if checksum mode */
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id EED97A00E6
for <public@inbox.dpdk.org>; Fri, 22 Mar 2019 18:03:26 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C13B21B6DF;
Fri, 22 Mar 2019 18:03:23 +0100 (CET)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id A605B1B6CD;
Fri, 22 Mar 2019 18:03:22 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
[10.5.11.14])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 958D530821F9;
Fri, 22 Mar 2019 17:03:21 +0000 (UTC)
Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B51C5D9CC;
Fri, 22 Mar 2019 17:03:16 +0000 (UTC)
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com,
ramirose@gmail.com, arybchenko@solarflare.com, ferruh.yigit@intel.com,
stable@dpdk.org
References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com>
<1553261824-1881-1-git-send-email-david.marchand@redhat.com>
<1553261824-1881-2-git-send-email-david.marchand@redhat.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <f39da0da-0170-9dbe-f67c-882aec819cbd@redhat.com>
Date: Fri, 22 Mar 2019 18:03:15 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <1553261824-1881-2-git-send-email-david.marchand@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.47]); Fri, 22 Mar 2019 17:03:21 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when
showing statistics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190322170315.Of2Ug3Ut-2cY1lt4BDYY9s9unc98fkHh4AeWq1p1NVI@z>
On 3/22/19 2:37 PM, David Marchand wrote:
> Having the standard stats and the rx burst stats on the same line gives a
> really long line and is not consistent with the rest.
>
> Before:
> RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
> TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others]
>
> After:
> RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0
> RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
> TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others]
>
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> Changelog since v2:
> - Cc'd stable
>
> ---
> app/test-pmd/testpmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 216be47..40199c1 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1459,7 +1459,7 @@ struct extmem_param {
> "TX Port=%2d/Queue=%2d %s\n",
> fwd_top_stats_border, fs->rx_port, fs->rx_queue,
> fs->tx_port, fs->tx_queue, fwd_top_stats_border);
> - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u",
> + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n",
> fs->rx_packets, fs->tx_packets, fs->fwd_dropped);
>
> /* if checksum mode */
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>