From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A501645552; Wed, 3 Jul 2024 04:52:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 748884025E; Wed, 3 Jul 2024 04:52:29 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id A9A544003C for ; Wed, 3 Jul 2024 04:52:26 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WDPMq1GgdzZhK7; Wed, 3 Jul 2024 10:47:51 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id 3A8D2180AA9; Wed, 3 Jul 2024 10:52:24 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 3 Jul 2024 10:52:23 +0800 Message-ID: Date: Wed, 3 Jul 2024 10:52:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v5 1/2] power: introduce PM QoS API on CPU wide To: zhoumin , CC: , , , , , , , , References: <20240320105529.5626-1-lihuisong@huawei.com> <20240702035010.4874-1-lihuisong@huawei.com> <20240702035010.4874-2-lihuisong@huawei.com> <702fd523-cb50-22cb-190d-c649e5442309@loongson.cn> From: "lihuisong (C)" In-Reply-To: <702fd523-cb50-22cb-190d-c649e5442309@loongson.cn> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600004.china.huawei.com (7.193.23.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi 在 2024/7/3 9:32, zhoumin 写道: > Hi Huisong, > > I knew that this patchset was based on the *dpdk-next-net* repository > in our previous communication. However, maybe it's better to rebase > this pactchset on the *dpdk* repository. Because the CI system is not > smart enough to recognize the patchset as a change for the > *dpdk-next-net* repository. I personally feel this patchset is more > likely a change for the *dpdk* repository because it modified the > `lib` directory which is the infrastructure of DPDK instead of a > feature for *dpdk-next-net*. > Generally, the 'dpdk-next-net' repo is ahead of 'dpdk' repo. And we make some development based on 'dpdk-next-net' repo. I found that there are some patches also happen to the same issue that CI applt patch failed. So I think the reason why this series trigger warning should be analyzed and resolved. > > On Tue, July 2, 2024 at 11:50AM, Huisong Li wrote: >> The deeper the idle state, the lower the power consumption, but the >> longer >> the resume time. Some service are delay sensitive and very except the >> low >> resume time, like interrupt packet receiving mode. >> >> And the "/sys/devices/system/cpu/cpuX/power/pm_qos_resume_latency_us" >> sysfs >> interface is used to set and get the resume latency limit on the cpuX >> for >> userspace. Each cpuidle governor in Linux select which idle state to >> enter >> based on this CPU resume latency in their idle task. >> >> The per-CPU PM QoS API can be used to control this CPU's idle state >> selection and limit just enter the shallowest idle state to low the >> delay >> after sleep by setting strict resume latency (zero value). >> >> Signed-off-by: Huisong Li >> Acked-by: Morten Brørup >> --- >>   doc/guides/prog_guide/power_man.rst    |  24 ++++++ >>   doc/guides/rel_notes/release_24_07.rst |   4 + >>   lib/power/meson.build                  |   2 + >>   lib/power/rte_power_qos.c              | 114 +++++++++++++++++++++++++ >>   lib/power/rte_power_qos.h              |  73 ++++++++++++++++ >>   lib/power/version.map                  |   2 + >>   6 files changed, 219 insertions(+) >>   create mode 100644 lib/power/rte_power_qos.c >>   create mode 100644 lib/power/rte_power_qos.h > > > .