From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 813EE4567F; Mon, 22 Jul 2024 12:54:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51193402DD; Mon, 22 Jul 2024 12:54:50 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mails.dpdk.org (Postfix) with ESMTP id 8DA7E4027F for ; Mon, 22 Jul 2024 12:49:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721645384; x=1753181384; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=rQs2W5gaKX96YeGp3RVCFsXycJ5CQ3AipQDHYh8Eqmw=; b=JVP6fN1RTjPLpjxDvhTP/GjxLmLjMFxNwAauZjJgT0+YfMpEyC5CPv4G 4VCsOr7Eoso0umXxCcRJX9w8nVSAS0rZdv3+nmBROEFhPXnX/8yuIWPbG C3OWpOOYU71tBUrNt9RIL81Z7fk48rQiRBOz703crX0hz5ThbCM8UfJkL WSXrb2/9OOlXEFW7UKPa/pILyZJmWRmkC6k11o1WYLeRz1uoW/7bQGks4 DjLRDkYwbY2bGPD0P74pnENHquZnN3tsH3Bd9A5/twLpCZDHdM9PIP/hH ypSmIc+Nai1YM+6rkAO4n98r1v47ybpMgby69N6Q2Fan28N7ZyH4yPlqj Q==; X-CSE-ConnectionGUID: /J0pzmUTSPicBzaJpzexag== X-CSE-MsgGUID: 3aNl30J9Ti240ZVKGLGo+w== X-IronPort-AV: E=McAfee;i="6700,10204,11140"; a="29823148" X-IronPort-AV: E=Sophos;i="6.09,227,1716274800"; d="scan'208,217";a="29823148" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2024 03:49:43 -0700 X-CSE-ConnectionGUID: 5Kx0Cu6lQ1SYC5c5X7iSwQ== X-CSE-MsgGUID: z+W8o1A5RB++Gck8bRRK3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,227,1716274800"; d="scan'208,217";a="56406650" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Jul 2024 03:49:43 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 22 Jul 2024 03:49:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 22 Jul 2024 03:49:43 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.46) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 22 Jul 2024 03:49:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rooflE7qywJKhMTq5E8qcZsLmyYkbWSQSGGJrOGefiUOdY1lgcMIwKPZLDF/jOABKUs56NT0r75xdHEW0CulM8N5gomstm77UwVGDPhe4jT5hIwcEQ2KaYonkBjYMTF+vjyfTjecCJBuYKqrtvnH+ICFV/wGfOeHwVb7ClDbZAOK7hBKpaVsXRHv1AM+vuAO20MGIYB/OccMcYuqaTUjh0IgfZmoW02aTOlhqn2UcIXeUqdax+PbdiLtAjtAr+XDtogEmeGnw7KAXziV/eYYH6Bi/1+2GEVz97PHMdtrCGivmMaKtg5kM3G/VSXpcHF9BoiWeyfg3Spjkkeq3ti4yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G/4Saif1JojpGRXugI8sTBuO+Fzaa0QZ9wPQuZbGs+o=; b=JM6RztfCEDQKRy+ukSZsuHhXp0qkzUNsmRS1iY1RSuQZtwMoFo9wcq0B4zejoXXXKrZOOYH1NUvJ+z2fEKSnIZTWBimc9MOoylTC5pc1WUv2Xh+f43PR0ISHYG94qUNuKmwOXLmRNVNyKz3C/pzY7D1iZiBKoHrOAS5rqpm0UUv+s/rs5Mw3p213E78ZrtJfKp9MIu5ful059M9+8M7Z0upSKPn4Zamt5lDTWkpjd44mZKydXEp0aidpTZU3AmPMYvgDymyMDglz7bF1Sw6Wg7iXW9b+oKXdOgxR377DbxdGAcaY/tJWVxO3FVQ1uc/hZmJ2kxTDrZuMZo0R+LlbcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from LV3PR11MB8579.namprd11.prod.outlook.com (2603:10b6:408:1b6::7) by PH7PR11MB6772.namprd11.prod.outlook.com (2603:10b6:510:1b6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Mon, 22 Jul 2024 10:49:40 +0000 Received: from LV3PR11MB8579.namprd11.prod.outlook.com ([fe80::ec3c:7b9a:2442:1ce4]) by LV3PR11MB8579.namprd11.prod.outlook.com ([fe80::ec3c:7b9a:2442:1ce4%4]) with mapi id 15.20.7784.016; Mon, 22 Jul 2024 10:49:40 +0000 Content-Type: multipart/alternative; boundary="------------OYGonepF6gKeEa2U1c89uW0I" Message-ID: Date: Mon, 22 Jul 2024 11:49:36 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] test/power: removed function pointer validations To: Sivaprasad Tummala , , , , , , CC: References: <20240220153326.6236-1-sivaprasad.tummala@amd.com> <20240720165030.246294-1-sivaprasad.tummala@amd.com> <20240720165030.246294-4-sivaprasad.tummala@amd.com> Content-Language: en-US From: "Hunt, David" In-Reply-To: <20240720165030.246294-4-sivaprasad.tummala@amd.com> X-ClientProxiedBy: DU2PR04CA0217.eurprd04.prod.outlook.com (2603:10a6:10:2b1::12) To LV3PR11MB8579.namprd11.prod.outlook.com (2603:10b6:408:1b6::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR11MB8579:EE_|PH7PR11MB6772:EE_ X-MS-Office365-Filtering-Correlation-Id: fb6eb2b6-9efe-4a65-bdc4-08dcaa3bfca5 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dVUzd2FKbE4rYVhWNVBTZ0RwRmcwYlJEcTNTdmpUemVjMHQraW9ucUZqQzAv?= =?utf-8?B?RjYrOGpReExsaS9mcHRmZVhpODNBUWZTTmNVV0t4NFlneUR3MlBnN29Uc3VS?= =?utf-8?B?WEZ2Z1RvWjFaSU9KRzRyMS9YUExjV2dEbmRjMEV4Q2tkdnlDc2R1R2ozRXBH?= =?utf-8?B?VVlxaElseFlQZnA4V05kaTgwelNKUCtJemFod2pWdHdPSmtWRXNjUGdTN1Rz?= =?utf-8?B?MncremNLd21DVVFXUG5Mc2gyeTFQbk93cHYzeWNsQXduZU1SKy96K0FydGFJ?= =?utf-8?B?dHRPc2NBRCt0WEd0V0hJN1llY1NuUCs5alNwRDR2Z3piSDhHZHhLOUVNMDI5?= =?utf-8?B?VU5RK3BXalk5S0htbm1BTEFsQlN3eFBYMnE4ZHc3bnpNMkw1c3pHaU1LYlo1?= =?utf-8?B?dmlENWpVMWhwMmRTaWx3OVc0eTBzN2tFT1JWcnAzKzA3dWRWT1FuRDgyT2tH?= =?utf-8?B?aGlzTk5Wd1dkcWZHdTM2bDVXdXNCaXYybzhkbGQ1OXZTSnpzcHkzODhWaHIz?= =?utf-8?B?TVRTTkJBT2NudnJMdHJ0ZGxRNUwxNTBWNnU4RzZidGtrM0NZNzJpSEx6cGZ6?= =?utf-8?B?UDYzV00wZzExQ05wZVMxWVVLL0toOUtYU2NiMzZhZlhITFRSZnUrb3laTE04?= =?utf-8?B?Sm5DbXdUTmRkRFdhRkZPem9DMHNSdnRsa25tczM3QWl5ajFURFFnV1lkd25h?= =?utf-8?B?OG1VTHU3TDZSSmI2dDVGOCttRSswRVhNVFhlQVQwdEgzRHV0Tml4eFo1Zmly?= =?utf-8?B?M2JlbWtvOEFQU1VxMkZqdFU5YUt6ZVJwZStRSEVxSXpyS0F5K2pmWDQ0cDhp?= =?utf-8?B?WUZVaExtZTRyOUIyZTV5REw4MHJNT2Jnc3NhYkVrTkoxK1lPYnN2ZFJNRS83?= =?utf-8?B?K2xOeVpEREZDZFlYODBEN0dkczh0cjRkb0RoRnBEUGJsdkhTNVpvZ3duZ0FM?= =?utf-8?B?ZW1ab3RHRFZTR0xYMERoRUZNdDJjMWs0MXhNZDgvUVFEcUhvQUhVQWQyK25v?= =?utf-8?B?TFRGWHdtUU03MS9yRSs1SHJKQXgrRjVQS1ViUFlwR1ArWVhxdUM1VFZ4VFg2?= =?utf-8?B?ZXgvQ3NSRGFJTXNqTHdUcEcyYWdYZXdGaDJDc0NzZHEzbHRCM1lNNytHVFpr?= =?utf-8?B?cnI1T0FlLy9CZll2RVFrZ3pFNlVFUzBnZWpSYS9GY0V4Qkh6L1pVaEdDRXIy?= =?utf-8?B?Wk04bCt3RTRnUFNuVktGTXJLQTZSd3k2b0lQbDNWaWwvT0tpSGh2Z3dzcXRu?= =?utf-8?B?aGlBakhWT3lIUHdHbTkySllKemw5QlRCRVNxcCs0TGx6YmRLRUlnZGZLTXhJ?= =?utf-8?B?dVF1UlAwWGl6bUY3RUJpaVRKa2t4NEw4aERiYS9tL0dzNG9QSktuR3lyS3JV?= =?utf-8?B?RjUvR0s5ais1NDdsc0xnQW1FMHphcDVkTlhtSnUzcFNKM1N4S3dGZ0NyQ3l0?= =?utf-8?B?Z2J4Tm1IY2lyc1NLTWs3OWVlb3V5RElma0UyRHZxdkUyWEpvaFhSWVZTL29v?= =?utf-8?B?ekJLSmNrUENSUTZQR0huSStObExUSERQOSs2dEpUOWlDUjMvek42UDFGZWhX?= =?utf-8?B?VmRIQ2lSR0pZaGpSZEFmRlF1dnp6aG8zMFJhTzloY05ETFYzSmloQVBiQ2dS?= =?utf-8?B?ODltVU1vL0M3NUI3c0dHVVhtckwvRmtZSHRKRjBZNkJtZkhaSEdXSmJIU2Yx?= =?utf-8?B?VDZpRkh6N3FVTVJLbEhFK0d3TFVPamlYR2VmMHI3b1VKMm5WNzlMTzFFdUJM?= =?utf-8?B?bXczeUs1TW0rcG1haWIrK2hXb3M1U1Z6NnZMT2NJSFJYWUhlbUU2ODhPNTR2?= =?utf-8?B?V2ZoM2hyd1VUWFhJOWl2dz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV3PR11MB8579.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjhWQWhIbWNLbUgzeE1BMEdOK29oSmxPWktFRHl0TUxIMTBNMExiUWI1MDNu?= =?utf-8?B?bEtDWUJydkxZdCtqNEJQTWwyQlp6NndaQ3h2cHg4UmJpZ3FyQmFxaXNIQzAv?= =?utf-8?B?SUh5ZEdyYzVNM3hOWGJQMjdvR0RFR3lWZThKNEhFWGg5VFNWSmMrU0QrNnpT?= =?utf-8?B?WEVFaGQwOVpiTTBYU1lHdVhoUjF1c0RhMnREYU1wNDJXaGh4TWVIaHNNOFBa?= =?utf-8?B?Nzl1MkJlOGNqUXdkUTRUcHZBZmZZZUN4bUF3QURnejdxVCtNUVJ2c0J3UUs1?= =?utf-8?B?S29wdTd6NDd1K0xMOWJRc043SnZwRVgvZXhVQ3hBSXVCWlYzOEdZc3VLeVBD?= =?utf-8?B?dnRVL250WTNyVHFQbkpUK29mclU5UmcvWmxOK25TSU1TMm9xY01QV0tJZkxZ?= =?utf-8?B?SmRDWjU0WWhhcHYwM2ErSGZKTVNYUVVTdWVqdit3U01jd2dkNms3SFFDUHdV?= =?utf-8?B?V3BZVEppclh4VW5ORmNCcFN3RkVDcTd6ZFRFZlNneVBsN0hKT1d0dVZzaVYr?= =?utf-8?B?NTdHM2JlTEI4emRsQ1JIMi9lZldXQ0hrWDc1blhmb3REYzV5SjBNMEdnR21X?= =?utf-8?B?STZOR294ZnZoSlVCZjFXTkRZSVVNRVZMOVVnTzNWaGhqSFREMnZBNzFGWkRa?= =?utf-8?B?SVZKNFl4dlAzNU9mcWtzeUxCdFhEY2cwdWNwOHpVYXZkVWk0RnowZEp5aStR?= =?utf-8?B?R2ZYbE9LVFYwdVVlOFdLNTNaZEFrODNoME9FK29TeVdZZG5qQXhDYnZSemdP?= =?utf-8?B?dmh5VWo3dkdXTEFFdTNLeEQwOGFFcmh4ODFUR1A4TU9NOXoxbFh2SGtsRUpI?= =?utf-8?B?OVFVdHYrUFE4Mmt5YVJLNGV4U2p2M2dYeEVTYmRnWWFFN05pUlJkRWprYmxT?= =?utf-8?B?Y1VvdDFCSXZvWDhFVGJsRTEvbU1nTmV3VXZPTGdqUzgwTC9FakJWR1gwVGg2?= =?utf-8?B?Q0ZIeHFTdUt4UlRGK1FQcXpwWG1DM0pqYTRUWTVYMTJINEp6WUtIT2J3NWpa?= =?utf-8?B?M0VMeC9XamlaaDJZeDlKR3ZNMm5WbU5oekVpdVZvRkJVUkNvMW9SQTl3ZTls?= =?utf-8?B?dUwzWHNKUGxpMi9JS3pCSU1HRk1sVjhHUFlkcENTd044Y2JSQnJnV05nRnN0?= =?utf-8?B?R1JUNHZvZng4YUJMYlU3Y0cvT2piTVhwVmpBOTJMMkZtNG5yeW5nZzlKR05G?= =?utf-8?B?bkl4OXQ4OGFkbklKY1g2cit5S01JY0s1VXVXSW9kc1F6TWNWTnl4dTl2bUlw?= =?utf-8?B?MFNvbzZSQzVIbHJnWmkrS21LbzZudzlLd05XN21mbUorck1idGkrTUd0OXcz?= =?utf-8?B?MUsxeWVmai84aEpuME8wOHMzcXFYUFBUci9uMUhyZ3VZQm1jV3JqUFR4NVpC?= =?utf-8?B?cWpiU0x1UlRoWUxoeFpocEFIcWJJSDUrSXRsSHRqRzlHY3BuZXNpSUI0ZXpW?= =?utf-8?B?U1NCQTJOL2x1Mkc2bEkvTlNWK0p5RzUyd1BlbU1xYkdUS01UQy9PWnJQbVdl?= =?utf-8?B?OHFMWUhEOEVva2dqME5Oak5nOTJqVkVOSkQyUEtEQWRncGNPRTFFMmpGVUk3?= =?utf-8?B?NWZLVFg0dmJySHA5dEJNL3R3UXBXamdUSS9pVDhQcFZPWWFPdUsrbnRZMlhM?= =?utf-8?B?OWNITWpjcWNybVliekVBTS9jeE4rVi85TzYxTVNtRFFXSnh0MFQvYnVlMjhy?= =?utf-8?B?SWZjbXhLZVBmOVM0a1dkbENyaW9SNjc5TkNJampJRUhiaDJCOWg5TTNkTHpP?= =?utf-8?B?RzM4KytGTTNheVU4ZzZWc25WMjhjRWZsbDNtUEJpdEJhT0JTVzVCclZ6aGJo?= =?utf-8?B?UFdDOFd4NEFYRmc3UWVNY3h6K0JhU2VhaWRONnJSdm9LMFZyN3hRWEVNQlBL?= =?utf-8?B?Vlk3QWpnY0Z3RUpuL1gxK0pSTlo2RURlNmVMTERaYUN5bTRYdldZU3lZWGV3?= =?utf-8?B?bGlMaElOcEtzekx5eUdhckFCd3VMVWZvcm85aW1ZTXJVWEgyZDlyU3hDRWIy?= =?utf-8?B?clRrQVpEcmdPMXF2SndXbWZqbldXRGVHODB5cXQvcWY5QlpwSUZnY2xiSURn?= =?utf-8?B?ZWoxYmliNWk2a0NQWWpKRVc4ZVJyUWt4cUE2MFpEb0pZSW5PbHdEMDRWK1d4?= =?utf-8?Q?XtXazBjOJiNmwOEjR9kvxWmNz?= X-MS-Exchange-CrossTenant-Network-Message-Id: fb6eb2b6-9efe-4a65-bdc4-08dcaa3bfca5 X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8579.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2024 10:49:39.9936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Mz639w9Bm2917SUWOhA4JaV3HRb/BqAg+lXirD2/vwgLztpR1LKhHFXe4/2bWLPq3bmeozrnzyqwnDnI0uHoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6772 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------OYGonepF6gKeEa2U1c89uW0I Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 20/07/2024 17:50, Sivaprasad Tummala wrote: > After refactoring the power library, power management operations are now > consistently supported regardless of the operating environment, making > function pointer checks unnecessary and thus removed from applications. > > Signed-off-by: Sivaprasad Tummala > --- > app/test/test_power.c | 95 ----------------------------------- > app/test/test_power_cpufreq.c | 52 ------------------- > app/test/test_power_kvm_vm.c | 36 ------------- > 3 files changed, 183 deletions(-) > Hi Sivaprasad,     Nice work on the patch-set. There's just four function pointer checks remaining that my compiler is complaining about. They are in examples/l3fwd-power/main.c (lines 443, 452, 1350, 1353). It would be nice to have these removed as well, seeing as the functions are now inlines and don't need these checks. I'm running the patch set through some tests here, will keep you posted on progress. Rgds, Dave. ---snip--- --------------OYGonepF6gKeEa2U1c89uW0I Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit


On 20/07/2024 17:50, Sivaprasad Tummala wrote:
After refactoring the power library, power management operations are now
consistently supported regardless of the operating environment, making
function pointer checks unnecessary and thus removed from applications.

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 app/test/test_power.c         | 95 -----------------------------------
 app/test/test_power_cpufreq.c | 52 -------------------
 app/test/test_power_kvm_vm.c  | 36 -------------
 3 files changed, 183 deletions(-)


Hi Sivaprasad,

    Nice work on the patch-set.

There's just four function pointer checks remaining that my compiler is complaining about. They are in examples/l3fwd-power/main.c (lines 443, 452, 1350, 1353). It would be nice to have these removed as well, seeing as the functions are now inlines and don't need these checks.

I'm running the patch set through some tests here, will keep you posted on progress.

Rgds,
Dave.


---snip--- --------------OYGonepF6gKeEa2U1c89uW0I--