From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <andy@warmcat.com>
Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82])
 by dpdk.org (Postfix) with ESMTP id 4F77E3237
 for <dev@dpdk.org>; Thu, 17 May 2018 16:06:03 +0200 (CEST)
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
References: <152656480225.46638.3271983577765861155.stgit@localhost.localdomain>
 <152656493702.46638.10712692446180001555.stgit@localhost.localdomain>
 <20180517135519.GC22288@bricha3-MOBL.ger.corp.intel.com>
From: Andy Green <andy@warmcat.com>
Message-ID: <f3e7039a-d186-f9f2-3277-c4c9139b0685@warmcat.com>
Date: Thu, 17 May 2018 21:59:41 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
In-Reply-To: <20180517135519.GC22288@bricha3-MOBL.ger.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change
 eth-dev-ops API to return int
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 May 2018 14:06:03 -0000



On 05/17/2018 09:55 PM, Bruce Richardson wrote:
> On Thu, May 17, 2018 at 09:48:57PM +0800, Andy Green wrote:
>> Signed-off-by: Andy Green <andy@warmcat.com>
>> ---
> 
> What's the reason for this change of type?

I was asked to do it on the list... the original patch I sent was 
triggered by gcc8 warnings and just casted it away.  But the comment was 
that as an int, it could return negative error codes, so better to 
change them all.

It thereby became something in the way of a refactor rather than a gcc 8 
fix any more.

-Andy