From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78066A04C2; Fri, 15 Nov 2019 09:11:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E86CB2C30; Fri, 15 Nov 2019 09:11:46 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 945CB374 for ; Fri, 15 Nov 2019 09:11:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573805504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp:autocrypt:autocrypt; bh=s3WcHtR1sqFQOwdBnqbT0xiDltOvEUfSqEVGLx+Dwr0=; b=NskwbxoqfdTYmEYT/zN1hL+LAyrWFyj1S4IrbLfv1Z6Taemj8GbmwIDpXCzS7/U9YkVBrV yNUX0IlI/4+qlmeq9bOlUdARPxYEwUjfNmSCMcj/mkwa8HJY2xuyyHqyF6Oi2h6nqFOk6J JAt91EhgyrBHYTbvPlSampuLJ+zFflc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-y_NEKyPuO1ecqTwvV2YnAA-1; Fri, 15 Nov 2019 03:11:41 -0500 Received: by mail-wm1-f70.google.com with SMTP id f11so6529860wmc.8 for ; Fri, 15 Nov 2019 00:11:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0p7uqhtc6Tun6jVi9e3NTsvmY8CanaWom4sqH2MzqcE=; b=Z2Hgydg+lRsXCdUmIcR+TIdcyn5hsbwTDJ+4CC7uFtPG8VSS1CZFlwwwubGaI+k9d2 tnVNIz9JsIXkED8k/6+r9+Kmw6+RtYL3Jk+5VSLwSo0yF1L8x5ZjFz2YfwnHC/OqamZ7 ISZ10sCEnn4NjKXRcTfhY80JyeVXQgiOJJ8JltQpxoPVUIxCwtyyI+HdVAxGskkNeApm Ptb6CjBphlm/GH1L68hcAGLeQuVfZPn5gTBfWUdSmtinkUqKGf+VR3TCfl5Y/gVk7DwT yI0xnDMxger1atcHoENLq/i5f3d46vMWtx+qqGhYsBfM1Z58q47eOYoX6+aI4dNG0e6/ SQPA== X-Gm-Message-State: APjAAAW9cLBUSClsMLaMPvXIeBcXqjDlntxFPpb9/vhhy7khsKZTNZuB gPpBXLKgbaz+oJJGmvNwu6VYoGX2EXN1ytSn481uar+Eb2f/4qDxyNldvEhhi6voKvwrL3CvO6C B/CY= X-Received: by 2002:a1c:3d08:: with SMTP id k8mr12378266wma.119.1573805500114; Fri, 15 Nov 2019 00:11:40 -0800 (PST) X-Google-Smtp-Source: APXvYqxj3ieDkqvMIcMminW8SNYb8lQBZqOebFrqkjqC1hpw0+2sVDKXsxTkfuMpIIaonzOZ1YFRnw== X-Received: by 2002:a1c:3d08:: with SMTP id k8mr12378246wma.119.1573805499869; Fri, 15 Nov 2019 00:11:39 -0800 (PST) Received: from dmarchan.remote.csb (lfbn-1-8944-244.w193-250.abo.wanadoo.fr. [193.250.84.244]) by smtp.gmail.com with ESMTPSA id y8sm8487313wmi.9.2019.11.15.00.11.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2019 00:11:38 -0800 (PST) From: David Marchand To: Krzysztof Kanas Cc: dev , dpdk stable , Kevin Traynor References: <20190902075251.2917-1-kkanas@marvell.com> <1573590662-31370-1-git-send-email-david.marchand@redhat.com> Openpgp: preference=signencrypt Autocrypt: addr=david.marchand@redhat.com; prefer-encrypt=mutual; keydata= xsFNBF2IycABEADRro66p9FwjHhl4X07u9gSDNGnMqYTW1H7GXxrwcKjIAf8BWjlyxo4Xt7u xR85q7DBu+GC6M7W2F5M7zlSJXZVAQKzruHfK5L889XEqVsi5cjv134JolRkHJSfPgB4VD4S NKBwvkiHlDPBuqFi6JWlm3acRK5e7cZ4TocLm1c72lumMQNn8b4FZMxMlxMlUF0FqAI7AvtW NBFQxzTyTG4zH1oKGbQPIyNzX4hQmFbH/oh2yTLoRQnAoLhvVU1XhkYpB/MlkFUqkVCUPcEt V7VZpSXR7abbQKXAFPUnBJAfVMRfzX9BEHknSQlkgTRABDWFvRldFeB6knoVSGhFKqBU949x MoOqJ0EH+ztfsl6tifDbD/F/nH8i22nIlWgmAFkJCh2r4QoYKHDYGAOwHG7DhuDa9jMmADK+ w3TIcXQ9bJn8KH4a4AZ7APLx1+AEBY+mFVl92gmxn6NtVzvqOEJ2cH2kZZ0w4Jo2+M0kblEp g/ivXvvL5gYdyERjrLa6PZCOCjcTBHroN3ifYzNN0e27HY+NrxvzLxZ6kD4mtBUlJ2iNZHDg 3lQtq0FWNdYDU7HLeNx9WTqweMMqJ4VCPBQSfRM5wPD9SwYhteMgQ8fDAKT1c84KBz9Ze7z/ Da+TROxGMsgAfvIKND80U603gKht5uaoDMO1ETtjH/rEeDFT/wARAQABzSpEYXZpZCBNYXJj aGFuZCA8ZGF2aWQubWFyY2hhbmRAcmVkaGF0LmNvbT7CwXkEEwECACMFAl2IycACGwMHCwkI BwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRCLvkA5AaSbSCUUEACrBIh3zvNo3/j311mLWEfl TOHjtWiB7LFc3uRqgA/JIsFr6Xms+F5v7iD9CUi/NQQ2XdMll8rBIgyDTC6zgjoAAoj4en9t vRQrcjeSyV0nF94PnT793Mb6rj4D9PTJW5y2TILh0ZowJlS+BpeDF3h3CQgk82XkDp0Dc6rA WyUP3X8NMEydJeAdBf425f+msi8RB/FNuquDKYSZHhqjEtJhdOiNVbr9owZh8l4wcr6ituyJ 3PhuX4wTM/oMJl8tG7vkL2Atw+KdBttj/tkjLK8m/m9KV6cIhsHdZbASE5EmACS2ZHRwbR5N ECN1OzU3kLk/O3bQRSxqCfTEjRxKyTEgBgqCQNsWryGhdipvDrDBR9YqT5if0hpZv+KKFNY5 3+BRnBkDlpUxaGmC5NpnW6zUqSia803AfFzHqVlRSQRX1xjsGjMRT9AdkqoRm5allKwQ55Zu 2Vf2V4YhQY1WS+O8WrrgO8ydOyMPUNmzSfSS/RlrIZWtIKg+5bfnIwyuc20asJhQOgfE2WVX ML2hjkmtxAe690NGC/ZebP0aHvNa7ttOW0+iGI1sWonl0IlqboYjIuFtqLItiSgPtwdwZIlg pVbjisZmLoR/WxpOk0rKnJ6+qL//vxv4G/5a48XF4zT6ZFHq5Nz91i2SL6dRTwq0GGjLxKev FKtF8ioKbKfyd87BTQRdiMnAARAAs5hpkWtPOrIY4W9PR9yFVjwitwmnpPjBCPLEMbmsvhL1 4b/ibMmFy0QIA3A3L/5wIMgVb7ZvrH7tcJWD/Kvoro8AKpBPAEZ5/wl2yybsHVLu7vimiGgP GA19scZmzh+uBVwE1NbWokyv/YzX5fORH5y9rtaS4A+mvwP4fqbND/VlJIVA06/YczeSdf5b J6pp24arYLNtkcWpi8hxIM3EIIH7nNw5ynVVBbBqp9j6HclLraTZ6Iyuqx4gl4L5A1Fd1q0E d1t5g61vfrX/XhiIhjRHGsWzwxnKIgffceL9O0qJOTt6FoFBQAAHDoINLwbLyEkO4hEPCWN3 lCT31iBOu/Lv/Btveef12pIVUemsKJ5Ww8ocoE1rgweBPJ3UGuU2bSrb2+IbgtygfRXwsR/6 B9sDFOnLAftM8cXvVtiVNXtnHGTph8UmtyG0T9D9PZlc+cB/qcy4m3bAVN7uP1zcQTc9NQkv RxJFJjPdbosE2gbnn3YgRGnnJSdKA73Vv6xzpdXFWAPV3RCllfSCwNuJFGrg+/nmF1phcy96 Ukvpk/FwPHrXjzaymooPv9/fkugCCaaMQEeBrxmhYvhotaqjqKBMtbPe4jDA5BCh5jB8P2OX X7KIoOOJX2Yvqt0g1Tqq/ikVHci2SCjBkkCeXSpiN0r+66aS1aqT9PXObusCw+UAEQEAAcLB XwQYAQIACQUCXYjJwAIbDAAKCRCLvkA5AaSbSGqEEADG1VLG5L7OZlIlufsIpSEmv4Kq0VMj +vJX8h+dmwqkbUO0ZQ4M4WxYTYPRPjyfz/9tGsseb+UB1M2bnish5dF1cgBrH5dXh38HFp+S GfTM4fFnREmrABDDEh46WNurYOPEk2LpyNg40VRk3lfz5tr7uFjfzNIU/ac02jZJgwFAr16d el5ym9McOnr0otM3/HLZ3Ef0YvXbvE7Pgi6CfEzfGlLdwF+cxidmla1Ipf/PU0pCYN8p3ya8 q7npdDaeoK2L3fXB8x9vJz23LxaYFAJpHgsNxoZBY9Y5TNMh04u2ftc7k/IPf1D5WlMgh5QW eVJkZd3YMipvpg9hBmMHvTiznEFNLNlug9Y4lOAwX8EIkl33hOIj3Mr7/MBuUx9Ycj0j7onh bvv1x6jQE8mh4dc1+7QySLTrex7i3oiIRYXMSACKDxd6KvaXvU/DQc62Gn/8Tk7V3s8Owzc+ ZgtrCZgF2h1kfAsydxIHrKONEo6VKMc6bmRK3m342CMkYenDTX5w8M5Ka/V0B5xu6Lxk7CdX 792qyCLYe8mHdvckssNSrDlDwqlZRlgWcm5YxFnctAE8ejgy7guHV4qJp8sP+J8Qu0eInVeR 2Dd8hjZiaUyPWicKLpARW3MOIvi40U+UIU8Mt04errXhbsuQZ5TTtMLULorXG7qJQbsKMFf0 jnmGuw== Message-ID: Date: Fri, 15 Nov 2019 09:11:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-MC-Unique: y_NEKyPuO1ecqTwvV2YnAA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v4] test: optimise fd closing in forked test process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 14, 2019 at 8:32 PM Kevin Traynor wrote: > > On 12/11/2019 20:31, David Marchand wrote: > > From: Krzysztof Kanas > > > > Caught while investigating timeouts on a ARM64 server. > > > > Stracing a test process running the eal_flags_autotest, we can see that > > the fork helper is checking all possible file descriptors from > > getdtablesize() to 2, and close the existing ones. > > We can do better by inspecting this forked process /proc/self/fd > > directory. > > > > Besides, checking file descriptors via /proc/self/fd only makes sense f= or > > Linux. This code was a noop on FreeBSD. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Krzysztof Kanas > > Signed-off-by: David Marchand Tested-by: Krzysztof Kanas > Seems to be an improvement on what is existing. > > Acked-by: Kevin Traynor > Applied, thanks. -- David Marchand