* [PATCH] eventdev/eth_rx: fix return of rx adapter instance get
@ 2023-01-03 13:09 Shijith Thotton
2023-01-17 15:19 ` Jerin Jacob
2023-02-07 7:17 ` Jerin Jacob
0 siblings, 2 replies; 3+ messages in thread
From: Shijith Thotton @ 2023-01-03 13:09 UTC (permalink / raw)
To: ganapati.kundapura, jerinj
Cc: pbhagavatula, Shijith Thotton, dev, stable, Naga Harish K S V
The API to get rx adapter instance is returning error for event devices
with internal port capability and eth_rx_adapter_instance_get op
undefined. But as the Rx adapter is internally maintaining the queue
information needed to find the instance id, event devices can opt out
from defining the op. Modified code to match this logic.
Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API")
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
lib/eventdev/rte_event_eth_rx_adapter.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index cf7bbd4d69..170823a03c 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -3415,14 +3415,10 @@ rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id,
if (!rte_event_eth_rx_adapter_caps_get(rx_adapter->eventdev_id,
eth_dev_id,
&caps)) {
- if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) {
- ret = rxa_dev_instance_get(rx_adapter) ?
- rxa_dev_instance_get(rx_adapter)
- (eth_dev_id,
- rx_queue_id,
- rxa_inst_id)
- : -EINVAL;
- }
+ if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT &&
+ rxa_dev_instance_get(rx_adapter))
+ ret = rxa_dev_instance_get(rx_adapter)(eth_dev_id, rx_queue_id,
+ rxa_inst_id);
}
/* return if entry found */
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] eventdev/eth_rx: fix return of rx adapter instance get
2023-01-03 13:09 [PATCH] eventdev/eth_rx: fix return of rx adapter instance get Shijith Thotton
@ 2023-01-17 15:19 ` Jerin Jacob
2023-02-07 7:17 ` Jerin Jacob
1 sibling, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2023-01-17 15:19 UTC (permalink / raw)
To: Shijith Thotton
Cc: ganapati.kundapura, jerinj, pbhagavatula, dev, stable, Naga Harish K S V
On Tue, Jan 3, 2023 at 6:39 PM Shijith Thotton <sthotton@marvell.com> wrote:
>
> The API to get rx adapter instance is returning error for event devices
> with internal port capability and eth_rx_adapter_instance_get op
> undefined. But as the Rx adapter is internally maintaining the queue
> information needed to find the instance id, event devices can opt out
> from defining the op. Modified code to match this logic.
>
> Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API")
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
@Naga Harish K, S V (rx_adapter maintainer) please review this patch.
> ---
> lib/eventdev/rte_event_eth_rx_adapter.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index cf7bbd4d69..170823a03c 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -3415,14 +3415,10 @@ rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id,
> if (!rte_event_eth_rx_adapter_caps_get(rx_adapter->eventdev_id,
> eth_dev_id,
> &caps)) {
> - if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) {
> - ret = rxa_dev_instance_get(rx_adapter) ?
> - rxa_dev_instance_get(rx_adapter)
> - (eth_dev_id,
> - rx_queue_id,
> - rxa_inst_id)
> - : -EINVAL;
> - }
> + if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT &&
> + rxa_dev_instance_get(rx_adapter))
> + ret = rxa_dev_instance_get(rx_adapter)(eth_dev_id, rx_queue_id,
> + rxa_inst_id);
> }
>
> /* return if entry found */
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] eventdev/eth_rx: fix return of rx adapter instance get
2023-01-03 13:09 [PATCH] eventdev/eth_rx: fix return of rx adapter instance get Shijith Thotton
2023-01-17 15:19 ` Jerin Jacob
@ 2023-02-07 7:17 ` Jerin Jacob
1 sibling, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2023-02-07 7:17 UTC (permalink / raw)
To: Shijith Thotton
Cc: ganapati.kundapura, jerinj, pbhagavatula, dev, stable, Naga Harish K S V
On Tue, Jan 3, 2023 at 6:39 PM Shijith Thotton <sthotton@marvell.com> wrote:
>
> The API to get rx adapter instance is returning error for event devices
> with internal port capability and eth_rx_adapter_instance_get op
> undefined. But as the Rx adapter is internally maintaining the queue
> information needed to find the instance id, event devices can opt out
> from defining the op. Modified code to match this logic.
>
> Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API")
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Updated the git commit as follows and applied to
dpdk-next-net-eventdev/for-main. Thanks
eventdev/eth_rx: fix return adapter instance get
The API to get rx adapter instance is returning error for event devices
with internal port capability and eth_rx_adapter_instance_get op
undefined. But as the Rx adapter is internally maintaining the queue
information needed to find the instance id, event devices can opt out
from defining the op. Modified code to match this logic.
Fixes: a1793ee8aba0 ("eventdev/eth_rx: add adapter instance get API")
Cc: stable@dpdk.org
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> ---
> lib/eventdev/rte_event_eth_rx_adapter.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index cf7bbd4d69..170823a03c 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -3415,14 +3415,10 @@ rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id,
> if (!rte_event_eth_rx_adapter_caps_get(rx_adapter->eventdev_id,
> eth_dev_id,
> &caps)) {
> - if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) {
> - ret = rxa_dev_instance_get(rx_adapter) ?
> - rxa_dev_instance_get(rx_adapter)
> - (eth_dev_id,
> - rx_queue_id,
> - rxa_inst_id)
> - : -EINVAL;
> - }
> + if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT &&
> + rxa_dev_instance_get(rx_adapter))
> + ret = rxa_dev_instance_get(rx_adapter)(eth_dev_id, rx_queue_id,
> + rxa_inst_id);
> }
>
> /* return if entry found */
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-07 7:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-03 13:09 [PATCH] eventdev/eth_rx: fix return of rx adapter instance get Shijith Thotton
2023-01-17 15:19 ` Jerin Jacob
2023-02-07 7:17 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).