From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E4CDE2B82; Wed, 18 Oct 2017 22:47:31 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 18 Oct 2017 13:47:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,398,1503385200"; d="scan'208";a="164217127" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.226.176]) ([10.241.226.176]) by fmsmga005.fm.intel.com with ESMTP; 18 Oct 2017 13:47:29 -0700 To: Shijith Thotton Cc: Thomas Monjalon , dev@dpdk.org, Jianfeng Tan , Jingjing Wu , Gregory Etelson , Harish Patil , George Prekas , stable@dpdk.org References: <20171017201436.65270-1-ferruh.yigit@intel.com> <20171018062743.GA26930@localhost.localdomain> From: Ferruh Yigit Message-ID: Date: Wed, 18 Oct 2017 13:47:29 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171018062743.GA26930@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 20:47:32 -0000 On 10/17/2017 11:27 PM, Shijith Thotton wrote: > On Tue, Oct 17, 2017 at 09:14:36PM +0100, Ferruh Yigit wrote: >> This reverts commit 6b9ed026a8704b9e5ee5da7997617ef7cc82e114. >> This reverts commit 5f6ff30dc5075c49069d684bab229aef7ff0fdc3. >> This reverts commit b58eedfc7dd57eef6d12e2c654a52c834f36084a. >> >> There were bug reports about terminated application may leave device in >> undesired state: >> http://dpdk.org/ml/archives/dev/2016-November/049745.html >> http://dpdk.org/ml/archives/dev/2016-November/050932.html >> >> And a proposal to fix: >> http://dpdk.org/ml/archives/dev/2016-December/051844.html >> >> Later another proposal triggered the discussion: >> http://dpdk.org/ml/archives/dev/2017-May/066317.html >> >> Finally a fix patch pushed into v17.08: >> Commit: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") >> >> Later a regression report sent related to the pushed patch: >> http://dpdk.org/ml/archives/dev/2017-September/075236.html >> >> And a fix for regression integrated into v17.11-rc1: >> http://dpdk.org/ml/archives/dev/2017-October/079166.html >> Commit: 5f6ff30dc507 ("igb_uio: fix interrupt enablement after FLR in VM") >> Commit: 6b9ed026a870 ("igb_uio: fix build with kernel <= 3.17") >> >> Even after the fix qede PMD reported to be broken: >> http://dpdk.org/ml/archives/dev/2017-October/079359.html >> >> So this patch reverts original fix and related commits. The related >> igb_uio code part turns back to v17.05 base. >> >> Cc: Jianfeng Tan >> Cc: Jingjing Wu >> Cc: Shijith Thotton >> Cc: Gregory Etelson >> Cc: Harish Patil >> Cc: George Prekas >> >> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ferruh Yigit >> --- >> It would be nice to solve this issue in LTS release, but being close to >> the release and the error report without details makes it hard to work >> more on this issue. >> >> Thanks everyone who spent effort for this, hopefully we can continue to >> work on next release cycle. >> >> Jingjing, there is a i40e commit, was part of igb_uio fix patchset, is >> it generic, or needs to be reverted with this patch? >> Commit: 8cacf78469a7 ("net/i40e: fix VF initialization error") > > Hi Ferruh, > > Please consider this patch as part of revert. > Commit: 9ed3f38770c6 ("net/liquidio: remove FLR request to PF driver") Hi Shijith, Sure, I will add this on next version of the patch. > > Here I have removed extra FLR requests inside driver during init and close. > They are required now, as we remove resets in igb_uio. > > Thanks, > Shijith > > [...] >