DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Nicolau, Radu" <radu.nicolau@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: add security statistics
Date: Mon, 9 Sep 2019 12:00:52 +0100	[thread overview]
Message-ID: <f42a9154-c7af-2754-14c2-1a9985830962@intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258019195D348@irsmsx105.ger.corp.intel.com>

Hi,

On 9/8/2019 12:45 PM, Ananyev, Konstantin wrote:
> Hi Radu,
>
>> Update IXGBE PMD with support for IPsec statistics.
> The proposed approach - have a new hash table per device,
> plus parse  each packet on RX and TX and do hash lookup
> seems way too heavy to put it into PMD.

It is indeed heavy, but it's disabled by default and it only uses the 
heavy section when the app is enabling per-session statistics

> Wonder why we need to do that?
> If HW doesn't provide such statistic info, why not to leave it
> to the upper layer to collect/maintain?
> In many cases SW will already have that infrastructure
> and I don't see to put all these heavy-weight operations
> into ixgbe rx/tx path.

The reason is to use the rte_security API consistently and take 
advantage of the hardware backed statistics when they are available.

>
> Konstantin

  reply	other threads:[~2019-09-09 11:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 16:41 Radu Nicolau
2019-09-08 11:45 ` Ananyev, Konstantin
2019-09-09 11:00   ` Nicolau, Radu [this message]
2019-09-10 13:02     ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f42a9154-c7af-2754-14c2-1a9985830962@intel.com \
    --to=radu.nicolau@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).