From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A83D42C04; Thu, 1 Jun 2023 16:39:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D3F140DDC; Thu, 1 Jun 2023 16:39:34 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2043.outbound.protection.outlook.com [40.107.93.43]) by mails.dpdk.org (Postfix) with ESMTP id E3931406BA for ; Thu, 1 Jun 2023 16:39:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vjur5zJhnVn/ZKSOqW/c5rvMDOOlqjWBSCowYC3rsyrmD2JQt1JzOeIZFja+oVLk6DAcGAv1G+ZeK9xHAvUUnbYrqZ1tKkSAWj1ph1+UDE6eAB0Pzb+AVh+DLJw+otog4W2EOeSKuUliD/s+DeN5nlR18fOb/eY71FcROIBrSpUs1SLJKMDJwoCR2GwXoug9Zx0YpSa/f4gXRkQgEWyH5H+myzONGEgYbuSttgr99x6ygjxj8xLzZV3Bi7lDQDCAHYwNy6yikSgc0kvF55btROsjvAiasUNUlHmrTsAXuTVMAtUgy+sYUwoYzzAhYPvrrEyodFeBGejHQeyCdlocIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VoS5TVY70l8C4KfliMiL5m2jt0UnvkdvcAU/lUODVVI=; b=T0Y2SFycVjdL/8fcu+41nkQgAL/Ut/xBC2lINkvuXPaUMePuu30NK4EDZd3XhkMikyAGNcAqPnU1sTeXXAvAc8fQUG/kGi9KHOrMTwigQDmMw0RuoaKnMfFufZqPzju7dnPqTfNEY+pYkCvHslq6NV6Znb76NP/tvDtf69Xk9A+2c0O2zRPLDYMgYXjy0uWqH9fESiiulWndOhLZC2UAhiaGGG/kx32GAZlw4W1PjUSYwpQrKhlEASWWauxZRH3yWHT42vDieGL5BKFjOlr0Ht4zrWpaKCxql+q/vqdL+JwY9pGNGeTL5SA2I1UvstBYRWoWg6bR6LgVB1UETe0mMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VoS5TVY70l8C4KfliMiL5m2jt0UnvkdvcAU/lUODVVI=; b=mAZ6jezme5mxyM86BEGN0oTPKR/tR1tOql8kDaNdMsmK6tR/YoiPIuxrrEJ6c5sXh3gVchbi9gvm/J4f4jkWPbQjUjIT++x/Tgvy7eklwqFEm3AP8+wToypENqzzM9Ld7EV6+5MsMu5OXln9kL2oGdNOBfaLCnJw3OIo2c2DLdw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB7870.namprd12.prod.outlook.com (2603:10b6:510:27b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Thu, 1 Jun 2023 14:39:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6433.022; Thu, 1 Jun 2023 14:39:29 +0000 Message-ID: Date: Thu, 1 Jun 2023 15:39:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 01/10] ethdev: support telemetry query MAC addresses Content-Language: en-US To: Jie Hai , Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org, liudongdong3@huawei.com References: <20230530090510.56812-1-haijie1@huawei.com> <20230530090510.56812-2-haijie1@huawei.com> From: Ferruh Yigit In-Reply-To: <20230530090510.56812-2-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0047.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB7870:EE_ X-MS-Office365-Filtering-Correlation-Id: cc48d002-d475-4e86-e1b9-08db62ae01a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FTSyIm8f2clBbCEPIYdawZEnWVL8uYf99+N5cY8p0hOFjm/HlxuywONp/OmWueL5pXKgJQmKrLCvedH9UqNoGcLeHh8Vi/QZ8I8p0ywxFUDwsEMMIFeInaXzuUo9WErUJMpVLk8wHcfD3P2HB+nY9EFXQxcPV5hidqlm53y5aoq1ler4rrmLyH/YZaIbGOInIXf8HsBBd181BWDDF/OSb33pgJRDBUfD2IuWsiVVJEBS7UogkqhzNY3+4mTHJH7xX9EhPC/s4hA8H/omQeRnfrxSlwr6c5xsDouGEEdJqk6lhN8wtu0h6ytZmvRhhrnIb7cr6JP3uVLLOxC5bf7ywS/M/MLH7npAVh5Ab6xjiamzf++FE2dNN+4ebWhSbcBCcpfr6tNF24eQ9yYOutxhFOFItXv+ge+KP3XqaiW6tzHIGuGH4zShMp1pSUkkK4Xn8U0OopgLcHTyoou/yYTCGuQ+It6y2Ibyqr4TU/JeVQWP8iu9PVOgZfgdIna+xF+EVjuu6Sty4Z/xk9wP7FC+6rFDjZLRQXYhc4dZCtc2ITqNY9/9WQR1yjOhcJI+oUAhhptTpxe1Obkf3bAmV0ylvPm+PJ8g0Bh5fKjP0gxgfOlT8vORBTP+Zocrw+HE/WHxKejSsWPS3n25nwfxNyYYhg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(366004)(39860400002)(376002)(346002)(396003)(451199021)(26005)(38100700002)(41300700001)(31686004)(6486002)(6666004)(186003)(83380400001)(6506007)(6512007)(53546011)(2616005)(110136005)(478600001)(66946007)(66476007)(316002)(4326008)(5660300002)(44832011)(31696002)(2906002)(8676002)(66556008)(4744005)(36756003)(86362001)(8936002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1MyWnRxQ09JRE5VeUMyVVJCQ1lESVgwYit2VEl5NDBraUxhSko0d2VnUmc1?= =?utf-8?B?eElKV0tpMWpLUHVOMFB2dXNxaHBzVEFPYkNjVHAxTS9EN2p0eWFCRmUwYkt5?= =?utf-8?B?cURIakU4R0lyRnNIOUNtTlpyY0RZRTlJaFJWWDAvdUs5VHhRWitJMU1PMzU2?= =?utf-8?B?WWpNWWtNYXQ2SXRwN3FERTJCNG40d24wcnNpSTZTTnAzRHA3b1RkZ0JneW44?= =?utf-8?B?MzBpcDdtY29CSHFyZXFwTDZDOFRyRzZXeFRpMExVK01IU3FNd3o1aFpjUytI?= =?utf-8?B?TEgvZ0Z6NWRnOWJVQ0h2Q2VPVnExSnFvTXgzaC9uZVBnOHJFdThCNG8vK1ZW?= =?utf-8?B?Q3ZLYWhuYzVvUVBwYUFNZ2J2ZjJ6MGM3UXA4VkdQMnh3NjlxaXhlK0dlYjJN?= =?utf-8?B?NFZqdW9tTlhkNkwzcTVBWmQwZXIzRGNOODdFUlRQemNwRW9EUm8wVGhWVllv?= =?utf-8?B?VE91Z04zK1pYY0ZRbnlxSEFTblJQMkpwNktZNDhRZU9kNW5kWFRFM21sTUdI?= =?utf-8?B?SzYrRmIwek1saVpDRWRGMlJVb1N1UDVRRFR4Yk1PNmRNclJZNmJNczNpWTdr?= =?utf-8?B?Y2gyaGs2MTdLL0I4R04zNHhhS0lJMkRHTHY1TjFEc2FWZlVublIyYXlUSGd6?= =?utf-8?B?NmtwMVU4alM3YWZlc3ZKalhBZ29ueGo0dEpBTXdlYWovVjRxM0h3U2M1SmRM?= =?utf-8?B?bG84Yys1bmxPZjlpb0ZwQ1QrdVF0SVZxTTJSVEROZWs1azBXRStGWEQ4alpQ?= =?utf-8?B?Zno3a1lLeS8yVUlBRzRGZFhSd2tmNlVlUkVSODN2eXZCcFZaYStuQy9sZVRV?= =?utf-8?B?aitGVzBZVXVXWjRaZFNmN0lOd0wrcGVCLzBwOFppMUpEUnlQcHZQWHd0Y2Ur?= =?utf-8?B?M0tWUDIwenNpWURQVUJkWW1qdVgvcGVOSllyNUVKNWF6N1BsS29YSzRUVFVW?= =?utf-8?B?VkNVNnpMNGZEWnB0cURsQVBXNEMvMjJYaVJXMjdEUllaT1BUQkYzY0U5UDht?= =?utf-8?B?Z0FxZC9ESnNCRDJsODdNTExRNXJVMmpUYXc0K2tKaVY2UENHTTU4cnBVb2s3?= =?utf-8?B?dDQvV1U5OUtmeUVMa0VVZTYyT29xeHJoRjRXNkNUQzgybm5hRzE4VndvZU5P?= =?utf-8?B?TzBJZFNGSFd1NG1sQnUwTnV4bUxpQy9NNFF2N1dUdXNDYXhLdFB1VHJDeERU?= =?utf-8?B?d2dEMkw2M3NlMU5jdEszNnFiMzdzV1VCMTcweWw4NWwwbkI1ZzBac2lIbGtN?= =?utf-8?B?dWFZTVUvL0JlZVhrWDY5NXdNQVd5c1owUmpsSGxaTGt4U0h2R1UwTVBpOVZJ?= =?utf-8?B?UXIvM1NvR01jcWcvL0QrT3VUY1NZaFh2SW5iTCsxcENVM3FOZHo5WHlDWnRu?= =?utf-8?B?bmozVTNVUVV0TU9rZ3ZlTWZlTm5VSlZkTU1yZmhZd2hhMDZnOEgzenk2dTBo?= =?utf-8?B?NURGcW81a0VHVFB0ZEFhd1BmTGozek9sdmRCckRqQ2tIb3QwMkhvYWNROU9G?= =?utf-8?B?U3RTNzFsU2M1ai9KQk85bXRtL293akNka0ZzaHAwTjZQUklmcTF4Y3d2cFlw?= =?utf-8?B?ai9tTEhBcEdTWHBmRDJBRXo3RC9nWHRPcUxmUWs2dGFxTzhzcGtUbmtsajlF?= =?utf-8?B?U2R2MW0rMHJ5RHJ1SG1od3VjQyszbWg0SC90UkdNNjVwVXp0eHArcUtaWUh0?= =?utf-8?B?V2N0R0pMWUROeDFJRVVTdGVWK2JPQ05EMnhPcUV3dzcxZ2JVMTc0cDVVZXJV?= =?utf-8?B?UXZtV1gwL2N5Um9Balk2NDgyVnFaNDBOWm41N2dpQmJGQkRuSDBpSGl3UTBQ?= =?utf-8?B?L3B5S1NoUkZzQkFuVXM1MVZsaURxbTAxbGVpZ1RoMnZYM0hQSkc2MEYyUCtV?= =?utf-8?B?bTM5MkRJeVA4Z3IrSVJjd3J3T3UyeEY3T3VDOSs1MERrZTFBbjQzSGJFM2hy?= =?utf-8?B?Tm5yaXMyb3B6bW0yOXdoUEhlaDZFdjRVSStYUDNYR3VUdDB0VEdDUWNuQ2l3?= =?utf-8?B?b01RM3d3aklYVWNIYlc2V2VGc1BaNWFzbXplRGZJZXhFVDVwUDA4d245anJT?= =?utf-8?B?QVVLdHI5MFpVTEcrQ3JXL3hJaDhqRUtzVzdhcmQ2aE5FQTgvYnlXWVVvS2Jq?= =?utf-8?Q?ZozaVbJ5wMpyi5yjWH+Gfn5Uu?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc48d002-d475-4e86-e1b9-08db62ae01a8 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 14:39:29.7452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N1X/vjm8Bw3fvgaKv0erpt811VMoNgls8+yd8MnyR0M4bvpSpT5Sh9HHAGk1aDwC X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7870 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/30/2023 10:05 AM, Jie Hai wrote: > +static int > +eth_dev_handle_port_macs(const char *cmd __rte_unused, > + const char *params, > + struct rte_tel_data *d) > +{ > + char mac_addr[RTE_ETHER_ADDR_FMT_SIZE]; > + struct rte_eth_dev_info dev_info; > + struct rte_eth_dev *eth_dev; > + unsigned long port_id; > + char *end_param; > + uint32_t i; > + int ret; > + > + if (params == NULL || strlen(params) == 0 || !isdigit(*params)) > + return -EINVAL; > + > + port_id = strtoul(params, &end_param, 0); > + if (*end_param != '\0') > + RTE_ETHDEV_LOG(NOTICE, > + "Extra parameters passed to ethdev telemetry command, ignoring"); > + > + if (port_id >= UINT16_MAX) > + return -EINVAL; > + Above part is common in many telemetry handle functions, what about extracting it as a function?