From: Ferruh Yigit <ferruh.yigit@intel.com>
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/enic: fix memory leak with oversized Tx packets
Date: Fri, 3 Feb 2017 22:52:06 +0000 [thread overview]
Message-ID: <f452caef-7535-f769-4b81-3454c273510e@intel.com> (raw)
In-Reply-To: <20170203011840.9715-1-johndale@cisco.com>
On 2/3/2017 1:18 AM, John Daley wrote:
> If a packet send is attempted with a packet larger than the NIC
> is capabile of processing (9208) it will be dropped with no
> completion descriptor returned or completion index update, which
> will lead to an mbuf leak and eventual hang.
>
> Drop and count oversized Tx packets in the Tx burst function and
> dereference/free the mbuf without sending it to the NIC.
>
> Since the maximum Rx and Tx packet sizes are different on enic
> and are now both being used, make the define ENIC_DEFAULT_MAX_PKT_SIZE
> be 2 defines, one for Rx and one for Tx.
>
> Fixes: fefed3d1e62c ("enic: new driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: John Daley <johndale@cisco.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-02-03 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 1:18 John Daley
2017-02-03 22:52 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f452caef-7535-f769-4b81-3454c273510e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).