From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id E1E79282
 for <dev@dpdk.org>; Tue,  3 Jan 2017 13:24:46 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga101.jf.intel.com with ESMTP; 03 Jan 2017 04:24:45 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,451,1477983600"; d="scan'208";a="25553207"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by orsmga002.jf.intel.com with ESMTP; 03 Jan 2017 04:24:43 -0800
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Jan Blunck <jblunck@infradead.org>
References: <1482332986-7599-1-git-send-email-jblunck@infradead.org>
 <1482508691-11408-1-git-send-email-jblunck@infradead.org>
 <3218207.eTF77IRQHx@xps13>
Cc: dev@dpdk.org, shreyansh.jain@nxp.com, david.marchand@6wind.com,
 stephen@networkplumber.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <f45a07fb-b77e-dccc-399c-d8c65f1c849b@intel.com>
Date: Tue, 3 Jan 2017 12:24:43 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <3218207.eTF77IRQHx@xps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v5 00/20] Decouple ethdev from PCI device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2017 12:24:47 -0000

On 12/25/2016 10:33 PM, Thomas Monjalon wrote:
> 2016-12-23 16:57, Jan Blunck:
>> This repost addresses the review comments of Thomas Monjalon to completely
>> remove the ethdev helper to further decrease the coupling of the ethdev and
>> the eal layers. This required me to squash together all patches using the
>> rte_eth_dev_to_pci() helper into "Decouple from PCI device" patch. As
>> discussed privately I'll keep the PCI information in rte_eth_dev_info
>> untouched.
> 
> Applied with some trivial fixes, thanks
> 

Getting following build error for mlx5 [1], it is mainly because verbs.h
also using container_of macro.

[1]
In file included from
.../x86_64-native-linuxapp-gcc/include/rte_mbuf.h:57:0,
                 from .../x86_64-native-linuxapp-gcc/include/rte_ether.h:52,
                 from .../drivers/net/mlx5/mlx5_trigger.c:38:
/usr/include/infiniband/verbs.h: In function ‘verbs_get_device’:
.../x86_64-native-linuxapp-gcc/include/rte_common.h:350:40: error:
initialization discards ‘const’ qualifier from pointer target type
[-Werror=discarded-qualifiers]
    typeof(((type *)0)->member) *_ptr = (ptr); \
                                        ^