From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5EFA32C35 for ; Fri, 7 Apr 2017 15:15:12 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 771B0C04B953; Fri, 7 Apr 2017 13:15:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 771B0C04B953 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=tredaelli@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 771B0C04B953 Received: from [10.32.176.62] (dhcp-176-62.mxp.redhat.com [10.32.176.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A52118B2E; Fri, 7 Apr 2017 13:15:10 +0000 (UTC) To: Remy Horton , Markos Chandras , dev@dpdk.org References: <20170216161731.4590-1-mchandras@suse.de> <122cf48a-70ed-9ccd-463c-f77acfd3d6a9@intel.com> Cc: Nirmoy Das From: "Timothy M. Redaelli" X-Clacks-Overhead: GNU Terry Pratchett Message-ID: Date: Fri, 7 Apr 2017 15:15:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <122cf48a-70ed-9ccd-463c-f77acfd3d6a9@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 07 Apr 2017 13:15:11 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 13:15:12 -0000 On 02/17/2017 05:11 PM, remy.horton at intel.com (Remy Horton) wrote: > > On 16/02/2017 16:17, Markos Chandras wrote: >> The librte_ethtool library depends on librte_pmd_ixgbe if that >> pmd driver is enabled so we need to link against it when we compile >> the ethtool application. It fixes the following build problem: > > For some reason this is not an issue with my Fedora box, so I'm guessing > SUSE is stricter with sub-depenencies of libraries. Does this affect any > of the OpenSUSE Linux distributions? Hi, I found that the issue is only present if you compile *without* .git directory present. If you have .git directoy RTE_DEVEL_BUILD is set to y (see mk/rte.var.mk) and this adds -rpath=$(RTE_SDK_BIN)/lib (see mk/rte.app.mk) that "hides" the problem, since the linker finds "librte_pmd_ixgbe.so" inside the $(RTE_SDK_BIN)/lib directory. So if you want to replicate it, you can delete the .git directory, use a snapshot (for example http://dpdk.org/browse/dpdk/snapshot/master.tar.xz or http://dpdk.org/browse/dpdk/snapshot/dpdk-17.05-rc1.tar.xz) or export RTE_DEVEL_BUILD=n. I confirm that this commit fixes the problem. Obliviously the problem is *only* present while using shared libraries. Acked-by: Timothy Redaelli You may use the following commands to replicate the problem: --8<--------------------------cut here-------------------------->8-- unset RTE_SDK RTE_INCLUDE RTE_TARGET export RTE_DEVEL_BUILD=n rm -rf x86_64-native-linuxapp-gcc make O=x86_64-native-linuxapp-gcc T=x86_64-native-linuxapp-gcc -j$(nproc) config sed -i 's/CONFIG_RTE_BUILD_SHARED_LIB=n/CONFIG_RTE_BUILD_SHARED_LIB=y/' x86_64-native-linuxapp-gcc/.config make O=x86_64-native-linuxapp-gcc -j$(nproc) make O=x86_64-native-linuxapp-gcc/examples T=x86_64-native-linuxapp-gcc examples