From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60482A00C2; Fri, 14 Oct 2022 11:37:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30CB9410F2; Fri, 14 Oct 2022 11:37:17 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id BC4F1410F2 for ; Fri, 14 Oct 2022 11:37:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665740235; x=1697276235; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=LuLsZ16vI6XWaqfrAPSyMvdbIqJJF32aHuwF2igjc/8=; b=VLfEatVlOHvIDEaAKNPwTPyQJ5PI5EcwSh2joDOCPRPBC29TnJ51CkYU iKw4FkvmdISy2qC8SOAA37O9Ww2ruSCTctnyXv6kYTsItFADJbzc4m9Qt SAV7I1b8aNk76qMlhE52ohlSMgPeTjc87njWXH41iXGDDMDSg4caQfj0T IRfBJ3JcJELYXJG3X4OTKwOgQ10Gim0qn6xnt9BZxHOgYZfwUXR45YJ2H tpF+6lZ5QQiIJ2Uki0NrdbHwmXgvVLtiQY/B5QY1uJEny1Zj5IJmd3WPg pWVsNyCb6iRBJ6rJbq2+b37YtorYR5Xws26ilveZvhMR2Sa8okjBJw/yf g==; X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="306985574" X-IronPort-AV: E=Sophos;i="5.95,184,1661842800"; d="scan'208";a="306985574" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2022 02:37:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10499"; a="627515391" X-IronPort-AV: E=Sophos;i="5.95,184,1661842800"; d="scan'208";a="627515391" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 14 Oct 2022 02:37:14 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 14 Oct 2022 02:37:14 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 14 Oct 2022 02:37:14 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 14 Oct 2022 02:37:14 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 14 Oct 2022 02:37:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4VtrfUydG1B7tBVgvS73uhpfcILStmlXj8gQ/rvaS3xp2hywOjIQU179goPlN8eZKiWxVTa/2TvgAcAeAsNwTRGVlMR0bN4jYUUuvjLFnfw7dfcAij1694yGhQbHAXe6rm8hprCM+MeVNcC+xgJVAXtvnjh5yrWdmnqEK/IIPeeIJQ8w4pqDevdHU3X3u2yTBtafy0EU2O3O1+/Yq/qb5WcPjrHxMlwrTRg8sKanRgwQ/TioGhRaizbz9ph48SGO3TYx0j8F0X7eSA/yYPNUenADrzF18ybIunFG9hYxVB8lZm66LtTds0UhMW2NVM4rNVl2Hy/vmpnSlIGJbR72w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5xDNGYNXYk8aJ2/zejYxuP4VwqaD7VD15Sq+NrkA5sY=; b=Ib0b3xEZikdlqJOQeLDWYyPJNJiedUFDesfGgiHANdCEXn4t/QleD2Tv8CcOQbsOAUos5YYvvM51L/TLZqiZqPgbjlm+wNMQ2vzY+f/h5b8J013TttWe3v0cm8Q+CFZsclOG5sIA5PcIBjkXuPKYnbXyoJLZe67b3ZNxT5gxyIi1oe/AlRgh0/F5iqJDRM3AZB7XsXgLObJ2H0VHAeFXvSj49BZSyQxzuuU8qVrYWIMldWkCmCObkpvd6lrft610busNG/6ifLWZfrBoeqfgSj4+wrKu3V1TDsc32ml2q/3Jykbb2WWz5y0O7ROUtIfBS3WoXwXS7fnZN2QSvMZbww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by CO1PR11MB4900.namprd11.prod.outlook.com (2603:10b6:303:9e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct 2022 09:37:13 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::4504:d466:7e7a:6fa2]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::4504:d466:7e7a:6fa2%4]) with mapi id 15.20.5723.029; Fri, 14 Oct 2022 09:37:13 +0000 Message-ID: Date: Fri, 14 Oct 2022 15:07:04 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH] app/testpmd: remove useless check Content-Language: en-US To: Yuan Wang , Yuying Zhang CC: , , References: <20221012142915.553392-1-yuanx.wang@intel.com> From: "Singh, Aman Deep" In-Reply-To: <20221012142915.553392-1-yuanx.wang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0161.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:26::16) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|CO1PR11MB4900:EE_ X-MS-Office365-Filtering-Correlation-Id: c135d341-ad38-4d14-30ff-08daadc7ac8a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BKNhvGAtZfvKNqqNsgh9O/PU0mMIaWOOn2nMwvIkpVThmO0tqDr3kPBOif6w4I/WHGUeiycGyzeEM2hYS9YBnQKvz1ig7UZtbN+9m9UmbQnaetVIvQP8Zsqs7lTsBFBQAVbX6nddxtuYAjcG57dFBEzbjwF7LfejHJeyRpm473DEAwRQ4HULXb0T3s8q4+MS96OiLo9Q2x4aIdMzeTGOZAQYIa4GXOc2KbGWIY5sYzsqoF5/4NmgZvwGbeEh83jtrDlYiZGPjKVTxMHuTHjATrWPJlDv5TdEZTIbIAazfZGzBzjSEQvxwjjtE3ENn7JPUq9kDFEd4FjthLGFwUlVyrc42ZQM1uIGycOqVgnIjbwNpWIeesfio2SNVcQ+cdDpEZaAf/Dvn55RtKTkT/oXzdckYNWPEmuthHnnzLuZrt7ykTv2bQmge+1V5Cm2Bq6SgDA3CafjKdqoIqkfHUs3N2A1UGSCQhKkqOw+P+njT2rQZasj9oTUhZKivp1BDe8qoFtv0Nt7DujFOWWGdDWc6NTcYW60Nt6i8GwrCT7TBrj0ZDsg+VCnHnr++sa0Dcj9+4USAiFO0PVP9gxfBaJySNFCv8/AtYRDsAtHQoF4+fGcCPUYpBxIkipEVay1mhBx7QUl2kdh0dGInPmL5MFKv0KGp4tBol+Wc0zz222o3iEgzuGM/8GxvPOBIQ7DBNR4h8s6KTexUVksHFbyvvIljBl3cv6I//erLVcr+FUJJPuz2OJEcoFbb7Pg+vyzheGxSKMtucH2c5uLwyGntBC3sxy1TlPGKqeqDBXwC0LZ8f4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(376002)(136003)(39860400002)(366004)(396003)(451199015)(82960400001)(31696002)(86362001)(36756003)(53546011)(41300700001)(6506007)(26005)(4326008)(8676002)(5660300002)(6512007)(8936002)(66476007)(66556008)(478600001)(110136005)(6486002)(66946007)(6636002)(107886003)(6666004)(316002)(38100700002)(2616005)(2906002)(186003)(83380400001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YS9RZjgzQmdlbXFuekJPWENjR3JXSlY0WENoWThMYnVZaG1yNVE2eVhoRXB2?= =?utf-8?B?QkZ4cmx4d3ZLWWZqOEFJdjZQL3JLcWVhdUs3Mzk5VE9zakU3VmIwTjZDSUNq?= =?utf-8?B?NmtmYUd2TG1jelpxU1FocXhRcEhuVWhBSSt5aVVQSjZXT2MvazZSdXB5VFZx?= =?utf-8?B?YVk1akpQbnlCMWRFTGRyQkVIUnpCNXByYXdySmpwYXVFNkpneVp6bW8wVTNp?= =?utf-8?B?NXJLeFE1UWJuQ1lBL0xEek55N2prdkZ3NXJIWmFEdDIyMm5xQjA5V3Jkb1dM?= =?utf-8?B?ajkwZGtqL1hIblBFTTBpK3pwTTZoajgzSGYrSmJYcEpPdFIyNk45YlR0K3J2?= =?utf-8?B?enF0L0VNUkR4SGVJQmtBVUo2MWFhKzEwMWhBb0NaY3liZ2pDWU4remJqcVVE?= =?utf-8?B?V0h1ajFmZEZ1a2lhbngvOGJMeDU4UWNLcVRKbXVuQXVDdUlDQTd4TmFpWjVh?= =?utf-8?B?OU9vMFNYVFFOZGRkazlnSTBXbW8wK2JZRFVuRFdXV3p0bEZqbllHWHQrQnFo?= =?utf-8?B?TFFXVk5jYW1IQ2Ntb0lHUHJYRzlaVVE5Wk8yVGNNN2NnYXVXTVNDS2ZTbE5s?= =?utf-8?B?NlVjSGhoc2MvVWVyUmh3R2hOMTE3b2dKbXlHMU8wTkQ0ZVhSSUlxR1dkbmRM?= =?utf-8?B?WmU1SGNZNFJ2WXVnelRjamUrOERhWnh6dkVDekZaRGJVbzZUM1pIOHY2N1Uw?= =?utf-8?B?UHpkbW9IVnV6QldFeWJzeUFSUFlRQUl5WXoyVUNQUkh4c2NvcC9XR3JQWE5a?= =?utf-8?B?NElmeDlUV3JrQ3VJNzE5T2g0MlhGL2lzN3lML3RMMGI1OE1OU0VjM2I3TWFk?= =?utf-8?B?TkRCcjZpeHMxayt5Wjg2dkk1bXVJZjMzQS9HekZWUWc5WlhOQmZwNllDMDI3?= =?utf-8?B?TGJuSHFENDk5YWZjMDFhYUZxclNFTUV5Uis5VlhWNDBRem03NndiTzBEUko0?= =?utf-8?B?akdWb2FwcnZOejczM2YxcEdjU3k5NVlNYUNRSmNaK0V5WWhZMFF3VVUxVSt2?= =?utf-8?B?c1RRdjlmVi9qclljVGVGcHJKY1ZqQ0JpNHBUSk9nTzV3NnJxVmNDU2JrUEsy?= =?utf-8?B?OFlqeXlyK01CRlVTNUliRkhOb1JBV2FaeUs3b0QxWVhVaVR1OWYvaFhoWjBK?= =?utf-8?B?RnJlcEU1R1Z0WEMzZSs3Mm9xaDQyWmE3QUprVzEvVjVYM05qWXBkbzhDN0F6?= =?utf-8?B?dkMyNk1tdlBicURJdkpxekR4ZnpzTXBSeWY0M0ZoVHZiajB2UXM2VW85WWlN?= =?utf-8?B?eEc2VVBUQm1kSWVIZkFGR3ZWWlhUSkRJWmEvQlFhVVh5U2RXUnh1c3BEOG1x?= =?utf-8?B?Uk96Sm1xMTJiVTBYZDN1QzdHcGV6QkRUdU54T01GU1MrRTVlQVR1U0tUOFJh?= =?utf-8?B?M2ZWMHJYYi8xZThYOGZzcXBGeThBR01ieURFdkhVN08zVzlQRnl3R0ExREt3?= =?utf-8?B?WDZpR1FXcm1FVHhqbEFCVFA0RmZOYzFETmoxTUxLYmFOdE9aZ1ZmMUNJWjVi?= =?utf-8?B?bVFpaytDN3ptUTFnZHRkZ0RNL1E1Y1l4S2o1U1hscVdWOUUwb01tRW5wWWFm?= =?utf-8?B?bWZ1WVozR0hWMHRURlN3Z01PQlpxWEc3RkU5eDRjZXVTVk5DVEpsUk5RMG15?= =?utf-8?B?YUJuVm1uQ3NIWVFTREdDb0Y0YjNVQW50S1QxU3dLMEpQTzUrYkJObzFYUFpS?= =?utf-8?B?WXdRQXJTeFd3bjFHYmVwc3JQWHhjNHZKRTBqS0JTbzQwbEg3WGRPMmdYTGow?= =?utf-8?B?V3Z4N3hmTXFybmRLV1hkTWlZQko5TWVnNHRxemIvZ0JNZDFVbTVxK1ZSZkR2?= =?utf-8?B?Z0JMMGhyNU5Xa25wZEc0cWFmZzBaTFM1OXJrbmtCcFpwQmdaSktiMDVXSUkv?= =?utf-8?B?YlBDTzV4RzdQVUFrMDFIRERUOC9pdGRyajZQYXM2RDlyK05qQ0l1dmV3a0lY?= =?utf-8?B?SlQ3Y0xzdmsvTkdVY0w5OFpQOFV0a3QxZU5MeW15VU14UlpMZlArSmFCL1l5?= =?utf-8?B?elRYOUtuSWhlSHppclh3Q01TRyt0WkJsUlppSXRZSWdTQVdhTzJPUUNyREY0?= =?utf-8?B?bUV1SUkrYWo0SjRvUWhEODV6dk9BT3o4cGYwcG1SNGo1ekpuSGVmSEpCcDh6?= =?utf-8?B?dXhJZS9WL1JmaGFBWDBHalZyVmJsbkVtNnpPSGg4QnNrWWhVeWRUc0xMNXN3?= =?utf-8?B?MXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: c135d341-ad38-4d14-30ff-08daadc7ac8a X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:37:13.1962 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZpkpkeIQh1bTG1ADDToc0bDirku0TbBUIP6H1TCtWpjSyBa+d7E1DSNgoZ9pUNPcAO4G2KaDB0rQunL1uQN8pP2qUJFB1jq6wPfkYA7HZsc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4900 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks for the patch Yuan. On 10/12/2022 7:59 PM, Yuan Wang wrote: > Protocol header sequence checking is supported in the ethdev library, > the application does not need to do it again. I would like to rephrase the patch title to make it more specific. Like "remove useless check" to "remove unused parameter in rx hdr split" or something like that, to specify the patch. > Coverity issue: 381396 > Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") > > Signed-off-by: Yuan Wang > --- > app/test-pmd/cmdline.c | 6 ++---- > app/test-pmd/parameters.c | 2 +- > app/test-pmd/testpmd.h | 2 +- > 3 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 17be2de402..29e4b2329b 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -3440,7 +3440,7 @@ get_ptype(char *value) > > unsigned int > parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items, > - unsigned int *parsed_items, int check_hdrs_sequence) > + unsigned int *parsed_items) > { > unsigned int nb_item; > char *cur; > @@ -3462,8 +3462,6 @@ parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items, > fprintf(stderr, "Number of %s = %u > %u (maximum items)\n", > item_name, nb_item + 1, max_items); > free(str2); > - if (!check_hdrs_sequence) > - return nb_item; > return nb_item; > } > > @@ -3854,7 +3852,7 @@ cmd_set_rxhdrs_parsed(void *parsed_result, > > res = parsed_result; > nb_segs = parse_hdrs_list(res->values, "segment hdrs", > - MAX_SEGS_BUFFER_SPLIT, seg_hdrs, 0); > + MAX_SEGS_BUFFER_SPLIT, seg_hdrs); > if (nb_segs > 0) > set_rx_pkt_hdrs(seg_hdrs, nb_segs); > cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1); > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > index ff760460ec..5b305c833c 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -1272,7 +1272,7 @@ launch_args_parse(int argc, char** argv) > nb_segs = parse_hdrs_list > (optarg, "rxpkt segments", > MAX_SEGS_BUFFER_SPLIT, > - seg_hdrs, 0); > + seg_hdrs); > if (nb_segs > 0) > set_rx_pkt_hdrs(seg_hdrs, nb_segs); > else > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > index e65be323b8..0b99339df8 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -854,7 +854,7 @@ unsigned int parse_item_list(const char *str, const char *item_name, > unsigned int *parsed_items, int check_unique_values); > unsigned int parse_hdrs_list(const char *str, const char *item_name, > unsigned int max_item, > - unsigned int *parsed_items, int check_unique_values); > + unsigned int *parsed_items); > void launch_args_parse(int argc, char** argv); > void cmd_reconfig_device_queue(portid_t id, uint8_t dev, uint8_t queue); > void cmdline_read_from_file(const char *filename);