From: Ferruh Yigit <ferruh.yigit@intel.com>
To: asomalap@amd.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: support sfp module EEPROM
Date: Thu, 14 May 2020 17:35:59 +0100 [thread overview]
Message-ID: <f49c492e-f570-522b-2f25-ed468ea31bf6@intel.com> (raw)
In-Reply-To: <20200514134302.29118-1-asomalap@amd.com>
On 5/14/2020 2:43 PM, asomalap@amd.com wrote:
> From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
>
> Adding API for get_module_eeprom and get_module_info.
>
> Signed-off-by: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
Hi Amaranath,
I guess this is v3 of the patch, can you please use the version info and keep
the all versions in same thread (using --in-reply-to), this helps us to trace
the status or previous comments of the patch.
There are multiple change requests and comments to previous version, same seems
sent in this version, can you please addresss them first?
http://inbox.dpdk.org/dev/67d7272a-29fc-885f-ad8e-e865687e1267@intel.com/
> ---
> doc/guides/nics/features/axgbe.ini | 1 +
> drivers/net/axgbe/axgbe_ethdev.c | 2 +
> drivers/net/axgbe/axgbe_phy.h | 4 ++
> drivers/net/axgbe/axgbe_phy_impl.c | 107 +++++++++++++++++++++++++++++
> 4 files changed, 114 insertions(+)
>
> diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini
> index 0becaa097..80a3bcee1 100644
> --- a/doc/guides/nics/features/axgbe.ini
> +++ b/doc/guides/nics/features/axgbe.ini
> @@ -18,3 +18,4 @@ Basic stats = Y
> Linux UIO = Y
> x86-32 = Y
> x86-64 = Y
> +Module EEPROM dump = Y
Can you please add the items with same order as 'default.ini'
next prev parent reply other threads:[~2020-05-14 16:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 13:43 asomalap
2020-05-14 16:35 ` Ferruh Yigit [this message]
2020-12-22 7:01 ` [dpdk-dev] [PATCH v4] " asomalap
2021-01-04 14:23 ` Ferruh Yigit
2021-01-06 12:31 ` Somalapuram, Amaranath
2021-01-06 14:02 ` Ferruh Yigit
2021-01-12 5:28 ` [dpdk-dev] [PATCH v5] " asomalap
2021-01-18 15:17 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2020-04-08 7:08 [dpdk-dev] [PATCH v1] " asomalap
2020-04-08 8:30 ` Somalapuram, Amaranath
2020-04-09 9:42 ` Kumar, Ravi1
2020-04-09 13:16 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f49c492e-f570-522b-2f25-ed468ea31bf6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=asomalap@amd.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).