From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 052E41C00
 for <dev@dpdk.org>; Fri, 12 May 2017 12:49:45 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 12 May 2017 03:49:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,329,1491289200"; d="scan'208";a="86743845"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81])
 ([10.237.220.81])
 by orsmga004.jf.intel.com with ESMTP; 12 May 2017 03:49:38 -0700
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Shepard Siegel <shepard.siegel@atomicrules.com>,
 Ed Czeck <ed.czeck@atomicrules.com>,
 John Miller <john.miller@atomicrules.com>,
 John McNamara <john.mcnamara@intel.com>,
 Harish Patil <harish.patil@cavium.com>, Rasesh Mody
 <rasesh.mody@cavium.com>, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Marcin Wojtas <mw@semihalf.com>, Michal Krawczyk <mk@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>,
 Jing Chen <jing.d.chen@intel.com>, Helin Zhang <helin.zhang@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, Matej Vido <vido@cesnet.cz>,
 Pascal Mazon <pascal.mazon@6wind.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Shrikrishna Khare <skhare@vmware.com>
References: <20170510131053.75843-1-ferruh.yigit@intel.com>
 <16254100.QC6ztoDaX8@xps>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <f4aa5d75-6a50-d39d-b367-98e5e924f4dc@intel.com>
Date: Fri, 12 May 2017 11:49:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <16254100.QC6ztoDaX8@xps>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] drivers/net: document missing speed
 capabilities feature
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 12 May 2017 10:49:46 -0000

On 5/10/2017 2:51 PM, Thomas Monjalon wrote:
> 10/05/2017 15:10, Ferruh Yigit:
>> --- a/doc/guides/nics/features/bnx2x.ini
>> +++ b/doc/guides/nics/features/bnx2x.ini
>> @@ -4,6 +4,7 @@
>>  ; Refer to default.ini for the full list of available PMD features.
>>  ;
>>  [Features]
>> +Speed capabilities   = Y
> 
> We should validate this feature only if the driver advertise the
> right speeds for the device.

Hi Thomas,

Can you please clarify more, what is expected implementation in PMD?
And perhaps a good and a bad sample can be helpful.

Thanks,
ferruh


> Most of drivers advertise every possible speeds for the driver
> without considering device limitations.
>