From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0C2541B114 for ; Fri, 19 Apr 2019 11:39:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2019 02:39:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,369,1549958400"; d="scan'208";a="166085396" Received: from ggluhoex-mobl.ccr.corp.intel.com (HELO [10.252.19.246]) ([10.252.19.246]) by fmsmga001.fm.intel.com with ESMTP; 19 Apr 2019 02:39:50 -0700 To: Lukasz Krakowiak Cc: dev@dpdk.org References: <20190409095401.16740-1-lukaszx.krakowiak@intel.com> From: "Hunt, David" Message-ID: Date: Fri, 19 Apr 2019 10:39:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190409095401.16740-1-lukaszx.krakowiak@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 09:39:52 -0000 On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote: > Removed dependency to mac_list from policies: > * BRANCH_RATIO, > * WORKLOAD, > * TIME > in function update_policy. > > Fixes: 1b897991473f ("power: update error handling") > > Signed-off-by: Lukasz Krakowiak > --- > examples/vm_power_manager/channel_monitor.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c > index 74df0fe20..ad1ddde07 100644 > --- a/examples/vm_power_manager/channel_monitor.c > +++ b/examples/vm_power_manager/channel_monitor.c > @@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt) > /* Copy the contents of *pkt into the policy.pkt */ > policies[i].pkt = *pkt; > get_pcpu_to_control(&policies[i]); > - if (get_pfid(&policies[i]) < 0) { > - updated = 1; > - break; > + /* Check Eth dev only for Traffic policy */ > + if (policies[i].pkt.policy_to_use == TRAFFIC) { > + if (get_pfid(&policies[i]) < 0) { > + updated = 1; > + break; > + } > } > core_share_status(i); > policies[i].enabled = 1; > @@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt) > if (policies[i].enabled == 0) { > policies[i].pkt = *pkt; > get_pcpu_to_control(&policies[i]); > - if (get_pfid(&policies[i]) < 0) > - break; > + /* Check Eth dev only for Traffic policy */ > + if (policies[i].pkt.policy_to_use == TRAFFIC) { > + if (get_pfid(&policies[i]) < 0) { > + updated = 1; > + break; > + } > + } > core_share_status(i); > policies[i].enabled = 1; > break; I hope it's OK to add Yufeng's Tested-by. As a new member to the mailing list, they've tested the patch, but does not have the original email to reply to. Tested-by: Yufeng Mo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 71BF8A00E6 for ; Fri, 19 Apr 2019 11:39:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 24CA51BAB5; Fri, 19 Apr 2019 11:39:53 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0C2541B114 for ; Fri, 19 Apr 2019 11:39:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2019 02:39:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,369,1549958400"; d="scan'208";a="166085396" Received: from ggluhoex-mobl.ccr.corp.intel.com (HELO [10.252.19.246]) ([10.252.19.246]) by fmsmga001.fm.intel.com with ESMTP; 19 Apr 2019 02:39:50 -0700 To: Lukasz Krakowiak Cc: dev@dpdk.org References: <20190409095401.16740-1-lukaszx.krakowiak@intel.com> From: "Hunt, David" Message-ID: Date: Fri, 19 Apr 2019 10:39:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190409095401.16740-1-lukaszx.krakowiak@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419093949.yRvoy2ujSGyBySH4PwrG-okRZ4msLSpQ-xE1Rlc_ogQ@z> On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote: > Removed dependency to mac_list from policies: > * BRANCH_RATIO, > * WORKLOAD, > * TIME > in function update_policy. > > Fixes: 1b897991473f ("power: update error handling") > > Signed-off-by: Lukasz Krakowiak > --- > examples/vm_power_manager/channel_monitor.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c > index 74df0fe20..ad1ddde07 100644 > --- a/examples/vm_power_manager/channel_monitor.c > +++ b/examples/vm_power_manager/channel_monitor.c > @@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt) > /* Copy the contents of *pkt into the policy.pkt */ > policies[i].pkt = *pkt; > get_pcpu_to_control(&policies[i]); > - if (get_pfid(&policies[i]) < 0) { > - updated = 1; > - break; > + /* Check Eth dev only for Traffic policy */ > + if (policies[i].pkt.policy_to_use == TRAFFIC) { > + if (get_pfid(&policies[i]) < 0) { > + updated = 1; > + break; > + } > } > core_share_status(i); > policies[i].enabled = 1; > @@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt) > if (policies[i].enabled == 0) { > policies[i].pkt = *pkt; > get_pcpu_to_control(&policies[i]); > - if (get_pfid(&policies[i]) < 0) > - break; > + /* Check Eth dev only for Traffic policy */ > + if (policies[i].pkt.policy_to_use == TRAFFIC) { > + if (get_pfid(&policies[i]) < 0) { > + updated = 1; > + break; > + } > + } > core_share_status(i); > policies[i].enabled = 1; > break; I hope it's OK to add Yufeng's Tested-by. As a new member to the mailing list, they've tested the patch, but does not have the original email to reply to. Tested-by: Yufeng Mo