From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Cc: john.mcnamara@intel.com,
Bernard Iremonger <bernard.iremonger@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: rework vm power manager user guide
Date: Tue, 25 Feb 2020 16:46:11 +0000 [thread overview]
Message-ID: <f5155aef-d8da-23f3-0b97-9d4bcc38d8e4@intel.com> (raw)
In-Reply-To: <20200217104817.23401-1-david.hunt@intel.com>
On 2/17/2020 10:48 AM, David Hunt wrote:
> Review and re-work of vm_power_manager documentation. Hopefully this
> is clearer, easier to follow.
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
>
> ---
> changes in v2
> * Fixed typos. Typos not found even with checkpatch from kernel 5.5.4, but
> when the codespell package is installed, the typos are magically
> revealed!
> * Moved the text blocks from within the high level image out into normal
> text for easier future maintenance.
> ---
> .../img/vm_power_mgr_highlevel.svg | 2043 +++++++++++------
> .../img/vm_power_mgr_vm_request_seq.svg | 1455 +++++-------
> .../sample_app_ug/vm_power_management.rst | 1216 +++++-----
> 3 files changed, 2653 insertions(+), 2061 deletions(-)
>
<...>
Bernard reported following errors [1] in DPDK 20.02-rc4 caused by this patch,
while building the docs in Ubuntu with "Sphinx (sphinx-build) 1.3.6".
I can't reproduce it with "sphinx-build 1.8.5" on Ubuntu, or with "sphinx-build
2.3.1" on Fedora.
I am putting this as a record, not sure if something needs to be done.
@John, do we have a minimum required sphinx version required?
[1]
.../doc/guides/sample_app_ug/vm_power_management.rst:420: ERROR: Malformed table.
Column span alignment problem in table line 5.
.../doc/guides/sample_app_ug/vm_power_management.rst:545: ERROR: Malformed table.
Column span alignment problem in table line 5.
.../doc/guides/sample_app_ug/vm_power_management.rst:754: ERROR: Malformed table.
Column span alignment problem in table line 5.
next prev parent reply other threads:[~2020-02-25 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 9:13 [dpdk-dev] [PATCH v1] " David Hunt
2020-02-16 11:13 ` Thomas Monjalon
2020-02-17 10:44 ` Hunt, David
2020-02-17 10:48 ` [dpdk-dev] [PATCH v2] " David Hunt
2020-02-21 18:02 ` Thomas Monjalon
2020-02-25 16:46 ` Ferruh Yigit [this message]
2020-02-25 16:59 ` Thomas Monjalon
2020-02-25 17:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5155aef-d8da-23f3-0b97-9d4bcc38d8e4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).