From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46B1D43750; Thu, 21 Dec 2023 12:46:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 124314027D; Thu, 21 Dec 2023 12:46:33 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 98420400D6 for ; Thu, 21 Dec 2023 12:46:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703159191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+D3FRgUaqwbhcwtSdzvEjsE4yYKlA44uA5ehMG2Zg0I=; b=LTEJNAYXFKAxpzV4rY5XrVM573jBLtNmG2eR4XAAsmDS83i3f4thYeDkhsAbIauxJPn+RG iCcdvi34M59wJ0xSg7lU9lk3L7BY7SqxAmXYy4Ib1vUmCuVHmz8dk5KWBumdASaZiwT+/3 o0sXWQ6hNNrKdAcncO0Rw2h8Rq146qY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-F94Azlk1OJ2-9VIZNlhUjQ-1; Thu, 21 Dec 2023 06:46:27 -0500 X-MC-Unique: F94Azlk1OJ2-9VIZNlhUjQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40c4a824c4bso5112775e9.2 for ; Thu, 21 Dec 2023 03:46:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703159186; x=1703763986; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+D3FRgUaqwbhcwtSdzvEjsE4yYKlA44uA5ehMG2Zg0I=; b=hT+VNM80V7CQVB2GcPq5dfOAicQPmUcV75rInW3qIndy6zNvcnN6fLGysIkcF5oxmF DdrwMVH+2cR06F0wDBP5PnYNgDpice73q5+EpjtM+AdkFhjR0+H4WqHrrurdOoRLA9BV IJBa1n9mu1dF6F4uImi247XgHUxWFpVPxMly3f2/8khOd3kx2pQFdQ7ALDbB7fBIUez3 wEyo0IeHQF2809T3xBIlbnTFuyHEcrpfcfF/ynEJIoh8kqjZUAUMm4pha82+PtYpwo8s sPuBDxpJ4ZHywYex9uVfinJ+lmTf8GFZnQ4l6PHcLabqW2lW7bZb0jhhBrYwhfrs5Pei QxFg== X-Gm-Message-State: AOJu0YyhDzoiZQpjRv3ZwxTA2dGAa5C52prK4JWnnXquC7IHKNqfjmaa GkX3mOILcbvbKtCBqjXG3eTl8n5adcTfE6s3VcI5e3rFE5pkJKdhWZO3+sBg4SVLCYaHfXNV/uS 6SEA= X-Received: by 2002:a05:600c:2e08:b0:40c:20d3:3a0f with SMTP id o8-20020a05600c2e0800b0040c20d33a0fmr708812wmf.78.1703159186428; Thu, 21 Dec 2023 03:46:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHTD3rJg68PMxJ8ge+e5hFH6rWCya4U6oaBMIMVXoKYuyH6gkAmoTEVlqmoxfq593aHiqLZyQ== X-Received: by 2002:a05:600c:2e08:b0:40c:20d3:3a0f with SMTP id o8-20020a05600c2e0800b0040c20d33a0fmr708805wmf.78.1703159186077; Thu, 21 Dec 2023 03:46:26 -0800 (PST) Received: from [192.168.0.12] ([78.18.22.228]) by smtp.gmail.com with ESMTPSA id s21-20020a05600c45d500b0040c3953cda5sm10846358wmo.45.2023.12.21.03.46.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 03:46:25 -0800 (PST) Message-ID: Date: Thu, 21 Dec 2023 11:46:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v6] net/af_xdp: enable uds_path instead of use_cni To: David Marchand Cc: ferruh.yigit@amd.com, stephen@networkplumber.org, lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, shibin.koikkara.reeny@intel.com, ciara.loftus@intel.com, dev@dpdk.org References: <20231215153946.2100669-1-mtahhan@redhat.com> From: Maryam Tahhan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------usG2b5YzZ5U2XmCIJ5zrI9QB" Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a multi-part message in MIME format. --------------usG2b5YzZ5U2XmCIJ5zrI9QB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/12/2023 11:36, David Marchand wrote: > Hello, > > On Fri, Dec 15, 2023 at 4:40 PM Maryam Tahhan wrote: >> With the original 'use_cni' implementation, (using a >> hardcoded socket rather than a configurable one), >> if a DPDK pod is requesting multiple net devices >> and these devices are from different pools, then >> the container attempts to mount all the netdev UDSes >> in the pod as /tmp/afxdp.sock. Which means that at best >> only 1 netdev will handshake correctly with the AF_XDP >> DP. This patch addresses this by making the socket >> parameter configurable using a new vdev param called >> 'uds_path' and removing the previous 'use_cni' param. >> This patch also fixes incorrect references to the >> AF_XDP DP as CNI and updates the documentation with a >> working example. This change has been tested with the > If there are fixes mixed in, please separate them in dedicated patches > so we can backport them to LTS releases. Thanks for the Feedback David, I don't quite understand the ask here, is to to have a separate patch for documentation to fixes? As previous feedback in the mailing list was to keep the documentation changes with the fix. There is one fix in this patchset (for for broken socket behaviour). The rest of the changes were fixing up all the documentation. So do I need to create a patchset with multiple patches, one for the c code and separate ones for the documentation? --------------usG2b5YzZ5U2XmCIJ5zrI9QB Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
On 21/12/2023 11:36, David Marchand wrote:
Hello,

On Fri, Dec 15, 2023 at 4:40 PM Maryam Tahhan <mtahhan@redhat.com> wrote:

With the original 'use_cni' implementation, (using a
hardcoded socket rather than a configurable one),
if a DPDK pod is requesting multiple net devices
and these devices are from different pools, then
the container attempts to mount all the netdev UDSes
in the pod as /tmp/afxdp.sock. Which means that at best
only 1 netdev will handshake correctly with the AF_XDP
DP. This patch addresses this by making the socket
parameter configurable using a new vdev param called
'uds_path' and removing the previous 'use_cni' param.
This patch also fixes incorrect references to the
AF_XDP DP as CNI and updates the documentation with a
working example. This change has been tested with the

If there are fixes mixed in, please separate them in dedicated patches
so we can backport them to LTS releases.

Thanks for the Feedback David, I don't quite understand the ask here, is to to have a separate patch for documentation to fixes? As previous feedback in the mailing list was to keep the documentation changes with the fix.

There is one fix in this patchset (for for broken socket behaviour). The rest of the changes were fixing up all the documentation. So do I need to create a patchset with multiple patches, one for the c code and separate ones for the documentation?

--------------usG2b5YzZ5U2XmCIJ5zrI9QB--