From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E07DA034C; Tue, 18 Aug 2020 15:50:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CDF61C1A7; Tue, 18 Aug 2020 15:47:22 +0200 (CEST) Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by dpdk.org (Postfix) with ESMTP id 8DA311C0BD; Fri, 14 Aug 2020 07:26:02 +0200 (CEST) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07E5NQmL153147; Fri, 14 Aug 2020 05:26:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=bn/lPiQ9tyTGHo1oo3Sirwv+us6KoPyrP6371bEBbkk=; b=bUG2Mh5FyXLOdrZH8Dca0jdORPeVKOgjdQM8a06iIe6OJaTqcZBWYDDP+8fU01X5dw2d OMgPcv7p4irBw+7ELseYhCQ2w1LoIOUOwOVsRPmyL+/YVAbxgW1O9vTtPWA+Qbca8HS8 tF5bOTi6IFxgBPikzD2SogJFwKKS2FSUXWJvnVBaJe2qlHxex5qRzo7rG65sT5V+3ZaM pxzODlgBhROW3TcTEVzmH09QeUJuF0WVoybpHTxbAEkGmE7Dbqa6ZJBY7q9odTzq1tk4 6OOI7wx0Kwox1QDr1yzTtt602fJkYu0ymQZlUGvqptjoWbNxg46zclyliMA8rvKGU4q9 RA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 32sm0n4ahy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 14 Aug 2020 05:26:01 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07E5HVaJ172810; Fri, 14 Aug 2020 05:24:01 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 32t5ybmxkw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Aug 2020 05:24:01 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07E5O0tM007981; Fri, 14 Aug 2020 05:24:00 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 14 Aug 2020 05:23:57 +0000 (UTC) From: Vipul Ashri To: "Xia, Chenbo" , dev@dpdk.org, stable@dpdk.org, "Wang, Zhihong" , maxime.coquelin@redhat.com Cc: Edwin Leung References: <20200807125731.1287-1-vipul.ashri@oracle.com> <20200813162222.1635-1-vipul.ashri@oracle.com> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 15.0.5257.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9712 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008140042 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9712 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 clxscore=1015 suspectscore=0 mlxlogscore=999 priorityscore=1501 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008140042 X-Mailman-Approved-At: Tue, 18 Aug 2020 15:47:00 +0200 Subject: Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All I tried twice uploading this same patch but it is still not listed under ht= tp://patches.dpdk.org/project/dpdk/list/. Please let me know if I am missing something and required to do some additi= onal steps to submit my patch. Thanks to Xia for reviewing this code! Regards Vipul -----Original Message----- From: Xia, Chenbo [mailto:chenbo.xia@intel.com]=20 Sent: Friday, 14 August, 2020 6:56 To: Vipul Ashri ; dev@dpdk.org Cc: Edwin Leung ; stable@dpdk.org; Wang, Zhihong ; maxime.coquelin@redhat.com Subject: RE: [PATCH v3] net/virtio: fix wrong variable assignment in helper= macro > -----Original Message----- > From: Vipul Ashri > Sent: Friday, August 14, 2020 12:22 AM > To: dev@dpdk.org > Cc: Xia, Chenbo ; vipul.ashri@oracle.com;=20 > edwin.leung@oracle.com; stable@dpdk.org; Wang, Zhihong=20 > ; maxime.coquelin@redhat.com > Subject: [PATCH v3] net/virtio: fix wrong variable assignment in=20 > helper macro >=20 > Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is=20 > always failing as assignment done using var_ having local scope only. > This leads to TX packets not going out and found broken due to cleanup=20 > malfunctioning. This patch fixes the wrong variable assignment. >=20 > Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions") > Cc: stable@dpdk.org >=20 > Signed-off-by: Vipul Ashri > --- > drivers/net/virtio/virtqueue.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/virtio/virtqueue.h=20 > b/drivers/net/virtio/virtqueue.h index 105a9c00c..20c95471e 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq) >=20 > /* avoid write operation when necessary, to lessen cache issues */ > #define ASSIGN_UNLESS_EQUAL(var, val) do {=09\ > -=09typeof(var) var_ =3D (var);=09=09\ > -=09typeof(val) val_ =3D (val);=09=09\ > -=09if ((var_) !=3D (val_))=09=09=09\ > -=09=09(var_) =3D (val_);=09=09\ > +=09if ((var) !=3D (val))=09=09=09\ > +=09=09(var) =3D (val);=09=09=09\ > } while (0) >=20 > #define virtqueue_clear_net_hdr(hdr) do {=09=09\ > -- > 2.28.0.windows.1 Reviewed-by: Chenbo Xia