From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61D3DA0C4D; Mon, 4 Oct 2021 15:05:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E02424136A; Mon, 4 Oct 2021 15:05:15 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 63DC041340 for ; Mon, 4 Oct 2021 15:05:13 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10126"; a="206223352" X-IronPort-AV: E=Sophos;i="5.85,345,1624345200"; d="scan'208";a="206223352" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 06:02:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,345,1624345200"; d="scan'208";a="622185974" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga001.fm.intel.com with ESMTP; 04 Oct 2021 06:02:03 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 4 Oct 2021 06:02:03 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 4 Oct 2021 06:02:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 4 Oct 2021 06:02:02 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 4 Oct 2021 06:02:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QYbhLZfkOSYbjaL6PAZcGJKECMw9TzctjIdeyk+FSLcQcdPYg8/myS38ehHNDCIVQpHaGuBxcfObsjDi/t2HVqZAb2FTzMtZnnQGS086/jUXNtQ/ck62wAQrp7G1iIGHjfmGduWGqiEDvL+9zeYNtPh3xuRp7qIrdMayddj0gvm+lAAi90XxX0udhwrRMD50cJeNmqkmCDu+UNTYDrc//FwIMXyQsttnCtN1LUWEM+hAvM0l0rZDj2CWpo1iDsnnY/T8ZZ3tXrGTXkWjNbrCU4QG7iGghNcpCVWziC2XSxxLOSYXAH//d9QxIW/QLtqn8ozoud/FBPdrClCCAuNlZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4WRuA2r1xh7F6nIhELREjeeWubqqXtwnrYpgYebZ2wY=; b=Q3OHw4rFjvgTM24TV0eqaWASiAOnAkUGGZct5TQWVpq+aRPNejJFlxoYvjXaKT3kqjXe9jcR5Y5GUTlifTf1edrVyJQyDWB3c6SVc+kvuwKXtxsLwyWXMfDyTx0XdtbzFVsdKoYIX4le1BSMGXF3w+4lLH/8eWpDhk+odHUo+pXUEHVyOcO8SpBJ4NiayhremSjnBq6JqhM/4e9kYIlKCKl89dyDpu35xiZG0xHNQ6ZPaKQsGajRDOjjoUgq/2uWfWMmLh9iB+/2Ut5K++MDqgXSO8LW30Tit4GEVjD8bYBlE9fiV+PrW9oGnp0iRNoWsO6kcZJEfru/Dl4PiI3tBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4WRuA2r1xh7F6nIhELREjeeWubqqXtwnrYpgYebZ2wY=; b=nrLl7W/NtHQeg+2L1bUkcdZ+qsCFkEzCZ4jpXR+ZDDxCcInx3sTrnwSGG5RQdpoTKRTS2cplqFu1eAV8dj3igJpjhe+PvOCa8YxspPimaPDvKID7z1eeW2YkbfEQBSpSU2/09xoAtznES8FwjO4URRwPs8+Nktl/pxuzKZeNeeU= Authentication-Results: nfware.com; dkim=none (message not signed) header.d=none;nfware.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5160.namprd11.prod.outlook.com (2603:10b6:510:3e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16; Mon, 4 Oct 2021 13:02:00 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Mon, 4 Oct 2021 13:02:00 +0000 To: Elad Nachman , CC: , References: <20210924105409.21711-1-eladv6@gmail.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 4 Oct 2021 14:01:54 +0100 In-Reply-To: <20210924105409.21711-1-eladv6@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB3PR06CA0005.eurprd06.prod.outlook.com (2603:10a6:8:1::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR06CA0005.eurprd06.prod.outlook.com (2603:10a6:8:1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.13 via Frontend Transport; Mon, 4 Oct 2021 13:01:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31c86eed-8b8b-4106-130f-08d987372771 X-MS-TrafficTypeDiagnostic: PH0PR11MB5160: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KNB6k+Tu9pcB3vSXYRNJkDO34FZsQ62aGZwlJGrekxPFpLEdNfwjtXDrM663IdLifdqwczpcJRnuXGf18h+oTbbfh4VpFcb6fYX/CaUz6EDVVnlMr/u604Y1FwhoQn3k6kld2bUgqqU/4RoYLh4MvO3TCPAIXaTtojRYNmkNVy3u8M5mrDUQQeZgE2Ri6pHf7JHVKrQ6Wv0S/p3fb9HoHz9z78uMRT2rfyHKxsdbc51r/K5J8UpJ7clbS6/iqlVBmaAa+SCdTLXry93z3+x0hJxLkM1e2SWMqqiIAy/toLbEk4cjFAy0KY8F+MABuFOMuwhGiR+rFiqmhsyXY4T4McICW3A9H1e1t4hWTBjIEFmNsiJQsaEeB/EY1QNYCgPjEYo52flRe6KwpG+P6jsV7etsMJxnVjjfXenTf/vE6/xh6P2+jmcPRmmwlmSxyBLyNcaAQh/iImhPvredMSCaGg0NTAFU+OODbhXv/d3A5rUv4VJMbCvLJ7MX7FVNLvQDix4E4bFaE9u79uf9Liavv2kpbj2CxBjmWMCtz2OkrMqxp73Q0UcwgVznFbfZPib3aHQ3QyTjFEOlbSi8VBI94ooZkrl/Q8vnQtr2zuhJotCvYd94lX4A/Qfkb94cQnpwNLTd9a070XOzexFi4Ifg8eF3RPr+WyerzFO7ScQltCWw9xHn9rVKreuWrRCjz5wDg9QY4rX1aTTrfYIy9oziGg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(83380400001)(6486002)(508600001)(6666004)(53546011)(2906002)(2616005)(38100700002)(8936002)(4326008)(31696002)(186003)(36756003)(86362001)(31686004)(16576012)(8676002)(26005)(44832011)(956004)(66556008)(66476007)(66946007)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2FaUDlGem9LYlZ2N1NXS1VoY0xQMlV2bWRMNFNXWUhDU1oxQTg0VFZBdCtx?= =?utf-8?B?azB2QU1PMjN4RjdEeU81M0liczE0Ym80Z0syYU81OUwvUHYrMGZQMlZENFRZ?= =?utf-8?B?NUF6Z1ZDbWs1bFhKU1pzbUk2S0JkTjZRTDJGa2xlY2gvVGhNZkhKQUJkNUlY?= =?utf-8?B?QXF5M3JYWjVVMVVnSVZZWG1ZTlRFazJ0dU1ML0VrTGdsd3RIMlZROE9kY3hN?= =?utf-8?B?QmdyQnN4OG5vZTlWek1WN3V6VkZqaVIrNythVHBhMHpNT3A1YmpLcy9ZbUtj?= =?utf-8?B?MlgzcjgrNnphYTk1eFBJMU5FeFdrK29FT2R6UitKdXUrZ2x1V0ZBT3NEWGli?= =?utf-8?B?RnY0dXJaOFpOQWdkL1lyUDZSVFpHN0cvUkJKdlcvWVFubVRTVkFLcUw0TUlq?= =?utf-8?B?L0kxcERycVBpUis0TnVYNmZsa1hNWi82c0FiYi9MVC9KaUZSWms1U00wdHUy?= =?utf-8?B?L0JKK0tJS0hvckVoaFhNS0VTeEdJYlFGK3pnajBTTzBPWlN4TkJNWlJNNzFI?= =?utf-8?B?bWlvb1BodHJIT2E5Z3BmaE9xTU9lNVcrY3pMRTZWTjVBdUozSk1FVGZ2WnAw?= =?utf-8?B?K2RhMzdVcjVFQ054VFJYaUw5cC9mdVJuNnBtUTVBWklDam1lYi94VGVnelc1?= =?utf-8?B?ZTNYbitka0ZXR0VkZGdLMXdEVmVyVEpHQU4wUHYxd3Vra1JBRFBCMHRsOHZi?= =?utf-8?B?SVV6cEtad3VVbUtMREVXNHVGT25pVHFOYWVLemVlTmFNZ25YNDdkYTMzU01n?= =?utf-8?B?dHZvMWFxYk85dTA5eHlBRnNPRWdja1BJTUpWRHg3NzJzT1A0VzlxbjFMSU1x?= =?utf-8?B?bnpUakMxUHFHVm1ZMlMrSWtJUWwydFpmaER2SHBRY05YMCtqZUY0T3NZZ1pP?= =?utf-8?B?ZXltSVF4K1d5Sm5hOW50V3pjWmtjOHlCWW9wQUIyTlFSTVh1b210K2ZhK2cv?= =?utf-8?B?K2pwczEvOWVaMXRaWk9QV1RqR0FvMWNxcWRSaVFtWGZEcGphcmxxcXB3MjZp?= =?utf-8?B?RkpVdFZmU2pVcVhNMys2T0FlaEhJTENYMXluWk5QMEkvRmltejJuUUIxVDhv?= =?utf-8?B?SGhJMFJSZnhzNHZGTitLbVJKOGI4aG4wdFdmZVB2MWVxSDdQaElPcGRlUXNJ?= =?utf-8?B?a3dLNGRqSURidmwyVWRuUmN1TjFjeWozMXhxM2c1NnJiS2NuRUZSNnZSNHQ2?= =?utf-8?B?M1ZIYUR4NzdiWXFXU3daTGEzQjdieUE2dEc2WmZ5UDFrT2RDY3A1M21McURK?= =?utf-8?B?ZmV5Mk53dFM0bVRRalVCTHArZml4c3VkYkRDSStsbVVwdzRxc0s1M0Rka3ZF?= =?utf-8?B?NFpXV1NReWkwNG9Zc2dDS3R3Vms0RTVsUVM2enlsNkRSdmxnb29DTmszWHc3?= =?utf-8?B?R0pqQ2x0T2tqTmMxb3MrMUV2UkplMjUwNXJhYW82eE5rcnRXY2NTT1V5ZG4w?= =?utf-8?B?NytheUladDRpR1diWXk4bEtHNHA5UnVoRmptYlVDTFlWNzdibWlqSTB2bGhr?= =?utf-8?B?Y2Y4Zk5XMVh5SDJjMDYyV01pa1Y5K0pHR1pWK3QrdjlLblVYeXdGS0hWRTh5?= =?utf-8?B?QnpibGtpeTdiSHkyMkNjUS91NUtoOEhEWm9lMDIxWkdkYlY3WS94dURSdjVm?= =?utf-8?B?QUNyWnpkVUEybTd3Q0FIbEdLRFc5QXZNa0Q4L1ErSVFNNDkwd0QyQlQrU0xI?= =?utf-8?B?bVpZMVo4Y0syRGF5ZjlMWDN4R0xHNkRabW1lRXAwQ1VBMU81MitlNXQ4bkZr?= =?utf-8?Q?gcAlz3/DNfj2hC9OOzZFsiHclQtNFNSPS/WoQSk?= X-MS-Exchange-CrossTenant-Network-Message-Id: 31c86eed-8b8b-4106-130f-08d987372771 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2021 13:02:00.6270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TVAw+WOtjkFZYHwpYe4Uz6V+tIfTnsh6aByjQkduVODhZ2WYIgbnEvWqZljsVD3lGqlgMJbLMNsPG5ZqF+Gtkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5160 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] kni: Fix request overwritten X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/24/2021 11:54 AM, Elad Nachman wrote: > Fix lack of multiple KNI requests handling support by introducing a > request in progress flag which will fail additional requests with > EAGAIN return code if the original request has not been processed > by user-space. > > Bugzilla ID: 809 Hi Eric, Can you please test this patch, if it solves the issue you reported? > > Signed-off-by: Elad Nachman > --- > kernel/linux/kni/kni_net.c | 9 +++++++++ > lib/kni/rte_kni.c | 2 ++ > lib/kni/rte_kni_common.h | 1 + > 3 files changed, 12 insertions(+) > <...> > @@ -123,7 +124,15 @@ kni_net_process_request(struct net_device *dev, struct rte_kni_request *req) > > mutex_lock(&kni->sync_lock); > > + /* Check that existing request has been processed: */ > + cur_req = (struct rte_kni_request *)kni->sync_kva; > + if (cur_req->req_in_progress) { > + ret = -EAGAIN; Overall logic in the KNI looks good to me, this helps to serialize the requests even for async ones. But can you please clarify how it behaves in the kernel side with '-EAGAIN' return type? Will linux call the ndo again, or will it just fail. If it just fails should we handle the re-try on '-EAGAIN' within the kni module?