From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26272A04A7; Mon, 24 Jan 2022 11:30:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD344427BB; Mon, 24 Jan 2022 11:30:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 98AD240E0F for ; Mon, 24 Jan 2022 11:30:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643020214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ADeHQ81YOzruo9HwZPVGsn1EfRlg3lVcx8VDgRgP2xk=; b=R/eW0oZ3QS6AVa7Vklz9GbUNux8UAeMYz8AvYJu9tQcjNVs1VI++wk+k5feSHqyw0CsMlQ ADKk3TysGhqpWwTY6edzzN9H0hGajTKIBiIGmom5QB76RKGqiPb8zeFmQx/EnPjk1Zb/X6 K7fOkIjg/iAsoS1rBJYrDO6Ic3rZfqY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-358-pGibR_wHNgS0_gDiqVS7NA-1; Mon, 24 Jan 2022 05:30:10 -0500 X-MC-Unique: pGibR_wHNgS0_gDiqVS7NA-1 Received: by mail-wm1-f70.google.com with SMTP id o193-20020a1ca5ca000000b0034d78423625so13466413wme.3 for ; Mon, 24 Jan 2022 02:30:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=ADeHQ81YOzruo9HwZPVGsn1EfRlg3lVcx8VDgRgP2xk=; b=uFfg1UeFc37Yc6GaS/69DkYN5+Dg+MCpvYxSe0jAueUdhSY8vpLeABT8Wk+w/fLbGS JsI2PQMKG5c5LcE+a5gRH+yZv8CNVE5tKkChj+1fKsV+cNWRO4ATUBRUpCQShA+ioVqP gJPv/9U3imuLFv6xx/UZUtTfxmMgbjCfQECaBOE1s8bimWJ2LSLBoQL20QByseCN0mqz mG2TEdyyH4qv3t1hCDYy0R5q4O6pdX/7l1e8gHzhvswNT3K+1SjUys5kj/iYagSPaPOt EvcqqXGDof5PSpajS7cBMzEVIlcIfU0KUfROfzj0h7f/pb6GcG4WtKnqtHrVkhKQluKz Sefg== X-Gm-Message-State: AOAM531m1KZ5Z8gq5nY8V0bLjazYEe6pNE9fijnnVwqrrnu1b9o5VMlu YH+NWl2HB4tbkIQzSwP0xSfOCWvMh8Y3EtAyKZ1SW6gyptbxdvpD6wZtqfLF049VaNy9w1pvj9N XkbY= X-Received: by 2002:a5d:55ce:: with SMTP id i14mr13985350wrw.224.1643020209678; Mon, 24 Jan 2022 02:30:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqRhGX/t2YTfT4DmGT2yYtZ9LJaQWkYeNguAd9j9C/qS/xC1njGGi7stT8ZVIBazHgnxEzqw== X-Received: by 2002:a5d:55ce:: with SMTP id i14mr13985330wrw.224.1643020209476; Mon, 24 Jan 2022 02:30:09 -0800 (PST) Received: from [192.168.0.36] ([78.19.108.41]) by smtp.gmail.com with ESMTPSA id l15sm17687775wmh.6.2022.01.24.02.30.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 02:30:09 -0800 (PST) Message-ID: Date: Mon, 24 Jan 2022 10:30:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 To: Ferruh Yigit , Xiaoyun Li , Aman.Deep.Singh@intel.com, olivier.matz@6wind.com, mb@smartsharesystems.com, konstantin.ananyev@intel.com, stephen@networkplumber.org, vladimir.medvedkin@intel.com Cc: dev@dpdk.org, Sunil Pai G References: <20211015051306.320328-1-xiaoyun.li@intel.com> <20220106160333.762686-1-xiaoyun.li@intel.com> <20220106160333.762686-3-xiaoyun.li@intel.com> From: Kevin Traynor Subject: Re: [PATCH v5 2/2] testpmd: fix l4 sw csum over multi segments In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 24/01/2022 09:16, Ferruh Yigit wrote: > On 1/21/2022 5:09 PM, Kevin Traynor wrote: >> On 06/01/2022 16:03, Xiaoyun Li wrote: >>> In csum forwarding mode, software UDP/TCP csum calculation only takes >>> the first segment into account while using the whole packet length so >>> the calculation will read invalid memory region with multi-segments >>> packets and will get wrong value. >>> This patch fixes this issue. >> >> There should be a 'Fixes:' tag and assuming you want this patch backported to LTS, 'Cc: stable@dpdk.org' too. >> > > It can't be, because fix relies on new APIs added in this release (patch 1/2). > ok, makes sense, thanks. Do you think it worth adding a Bz for it and listing it as a known issue in 21.11.1?