From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05C6243F12; Fri, 26 Apr 2024 09:25:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C04E243AE0; Fri, 26 Apr 2024 09:25:44 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 4BDBA402EF for ; Fri, 26 Apr 2024 09:25:43 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id D2637128C8 for ; Fri, 26 Apr 2024 09:25:42 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id C618D128C6; Fri, 26 Apr 2024 09:25:42 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.3 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E468012849; Fri, 26 Apr 2024 09:25:40 +0200 (CEST) Message-ID: Date: Fri, 26 Apr 2024 09:25:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/af_packet: cache align Rx/Tx structs To: Ferruh Yigit , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , "John W . Linville" Cc: dev@dpdk.org, Tyler Retzlaff References: <20240423090813.94110-1-mattias.ronnblom@ericsson.com> <6f7aabcb-2c12-4cfe-ae9d-73b42bfd4977@amd.com> <0cd9b883-6bf2-435f-a1f2-c1e07afce2db@amd.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <0cd9b883-6bf2-435f-a1f2-c1e07afce2db@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-04-25 17:35, Ferruh Yigit wrote: > On 4/25/2024 4:08 PM, Mattias Rönnblom wrote: >> On 2024-04-25 16:08, Ferruh Yigit wrote: >>> On 4/23/2024 12:15 PM, Ferruh Yigit wrote: >>>>> Signed-off-by: Mattias Rönnblom >>>>> --- >>>>>   drivers/net/af_packet/rte_eth_af_packet.c | 5 +++-- >>>>>   1 file changed, 3 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c >>>>> b/drivers/net/af_packet/rte_eth_af_packet.c >>>>> index 397a32db58..28aeb7d08e 100644 >>>>> --- a/drivers/net/af_packet/rte_eth_af_packet.c >>>>> +++ b/drivers/net/af_packet/rte_eth_af_packet.c >>>>> @@ -6,6 +6,7 @@ >>>>>    * All rights reserved. >>>>>    */ >>>>>   +#include >>>>>   #include >>>>>   #include >>>>>   #include >>>>> @@ -53,7 +54,7 @@ struct pkt_rx_queue { >>>>>         volatile unsigned long rx_pkts; >>>>>       volatile unsigned long rx_bytes; >>>>> -}; >>>>> +} __rte_cache_aligned; >>>>> >>>> Latest location for '__rte_cache_aligned' tag is at the beginning of the >>>> struct [1], so something like: >>>> `struct __rte_cache_aligned pkt_rx_queue {` >>>> >>>> [1] >>>> https://patchwork.dpdk.org/project/dpdk/list/?series=31746&state=%2A&archive=both >>>> >>> >>> Hi Mattias, >>> >>> We dived into side discussions but with above change I can proceed with >>> the patch. >> >> OK. >> >> Should this go into some stable branch as well? >> > > I don't see any reason for not merging to stable trees. For this please > add fixes and stable tags. OK, I'll submit a v2. Thanks.