From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F02B44180; Fri, 7 Jun 2024 15:37:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 740F840151; Fri, 7 Jun 2024 15:37:42 +0200 (CEST) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by mails.dpdk.org (Postfix) with ESMTP id EEF7340150 for ; Fri, 7 Jun 2024 15:37:41 +0200 (CEST) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-57c614c572aso348708a12.1 for ; Fri, 07 Jun 2024 06:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1717767461; x=1718372261; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U8Htl7D8S4zVYJmBr3XtsK7cp4JXHOKxdw67Q86kZSE=; b=leBmjz8zINNjt5nHx2cL3+mqc7gpYwwUlLX/pKCSBsmfkO0ZcOog8nPLn9g8WKqNeU vWf2BG2tPXqDLcvusSkfka4nTOlZrOUMMNkwuK64GRn1IToS6imcrXMlOxbnEw6J8yyR p8iAwpNoWzpypd+TYdOrTZeqOtAxmOSQBiFR3TAKAhJEtwQSxnT0zFdFEQ5A9wIzfy0W gbJ2lce0XgZhOeQHjicwm7iO9UqU1lnETsXp6PSoocAVQciRg61ZRtQhNzLQi+6EgEzJ aI1VAJhLGfHmGoa+g+jIeAcfDpTQTesYSVd6cx4c7iykAjusKuzVA1KKNggyv4KY9KO/ 4BHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717767461; x=1718372261; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U8Htl7D8S4zVYJmBr3XtsK7cp4JXHOKxdw67Q86kZSE=; b=wT0ly/DJU+SgmiqkgPw75sc3E/0FrbYWe9F8uZ5RSnUpHfIXdvC77GP5aE6HP//D3M POoV83ozj2Bh/1aWJMI/7c6rGobnsprHWIKtcB5ssAXizzmO56gNgMwydlnNFbHhp4pz ZtgFsG5OdNsJolao+XD5AusVTPqi4ML01OIf1dujsO9t7GefRLipYDOcrI0ez+U/5sAF /LZjTsKVX5kGa/qKHXVbEifhlqlg4o5FMnkzGxpFInMb7uKzpYKbcUnW9uLgH75KElOY szZh5ga5BI2Rt85S/3+1aNbUOCfJ2gFlibD9io3+WUb+Z5+F3bXhyhrp/IHvy5kZJg00 uhQg== X-Gm-Message-State: AOJu0YwlGzs5kUzKZFlJGbOUFh8KReHqbaLVVxWrJTvVQTar2KUh3F5D jM88nNEiKDhLHfPbih7y21TtKogovumJyfNaip9jRRrKYpCfKvaIXw+Lr3VXh4s= X-Google-Smtp-Source: AGHT+IFwCMzA0manNqw2oi+sZm13r2dUljCy0U2n5SB19xY6Cy3lDBFivSnz8yldKw43Q6NqFpZhxA== X-Received: by 2002:a50:96c2:0:b0:57c:6009:1b70 with SMTP id 4fb4d7f45d1cf-57c60091c46mr668539a12.23.1717767461227; Fri, 07 Jun 2024 06:37:41 -0700 (PDT) Received: from [192.168.1.113] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57c5fd78477sm596242a12.40.2024.06.07.06.37.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 06:37:40 -0700 (PDT) Message-ID: Date: Fri, 7 Jun 2024 15:37:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dts: Improve output gathering in interactive shells To: jspewock@iol.unh.edu, paul.szczepanek@arm.com, wathsala.vithanage@arm.com, probb@iol.unh.edu, npratte@iol.unh.edu, Luca.Vizzarro@arm.com, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, yoan.picchi@foss.arm.com Cc: dev@dpdk.org References: <20240501161623.26672-1-jspewock@iol.unh.edu> <20240529194910.26803-1-jspewock@iol.unh.edu> <20240529194910.26803-2-jspewock@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240529194910.26803-2-jspewock@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 29. 5. 2024 21:49, jspewock@iol.unh.edu wrote: > From: Jeremy Spewock > > The current implementation of consuming output from interactive shells > relies on being able to find an expected prompt somewhere within the > output buffer after sending the command. This is useful in situations > where the prompt does not appear in the output itself, but in some > practical cases (such as the starting of an XML-RPC server for scapy) > the prompt exists in one of the commands sent to the shell and this can > cause the command to exit early and creates a race condition between the > server starting and the first command being sent to the server. > > This patch addresses this problem by searching for a line that strictly > ends with the provided prompt, rather than one that simply contains it, > so that the detection that a command is finished is more consistent. It > also adds a catch to detect when a command times out before finding the > prompt or the underlying SSH session dies so that the exception can be > wrapped into a more explicit one and be more consistent with the > non-interactive shells. > > Bugzilla ID: 1359 > Fixes: 88489c0501af ("dts: add smoke tests") > > Signed-off-by: Jeremy Spewock Reviewed-by: Juraj Linkeš