From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A96BFA0562; Wed, 14 Apr 2021 13:55:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F2EB1619E8; Wed, 14 Apr 2021 13:55:48 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id A8A3B1619E6 for ; Wed, 14 Apr 2021 13:55:46 +0200 (CEST) IronPort-SDR: DVv/FpStA8gKKhPnhcR3z9q8c7W8cabuXDSRPPGmYsNnMwxfG+jsb4dUw+nepF4AHCaTh6bwEQ vzWFNS/sO8PA== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="191437176" X-IronPort-AV: E=Sophos;i="5.82,222,1613462400"; d="scan'208";a="191437176" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 04:55:45 -0700 IronPort-SDR: BPnYY88cFnw31P7RkN5O5d7oElPR1exRMhDDMT5s23T1J6AkYV0sbnAoyIxMkmSp+bJRateHY+ bQcilsHL02aw== X-IronPort-AV: E=Sophos;i="5.82,222,1613462400"; d="scan'208";a="461187058" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.205.34]) ([10.213.205.34]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 04:55:43 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: xiaoyun.li@intel.com References: <1617877348-16394-1-git-send-email-humin29@huawei.com> <1618369325-32797-1-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 14 Apr 2021 12:55:39 +0100 MIME-Version: 1.0 In-Reply-To: <1618369325-32797-1-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix bitmap of link speeds when force speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/14/2021 4:02 AM, Min Hu (Connor) wrote: > From: Huisong Li > > Currently, when the user sets force link speed through 'link_speeds', > bit(0) of 'link_speeds' is not set to 1(ETH_LINK_SPEED_FIXED), > which conflicts with the definition. > > Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) > --- > v2: > * When users set 10M and 100M speed, fixed bit is still set. > v2 fix the bug. Moving acks from previous version Acked-by: Ferruh Yigit Acked-by: Ajit Khaparde Applied to dpdk-next-net/main, thanks.