From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50DFD431EE; Tue, 24 Oct 2023 10:40:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBDE7402BE; Tue, 24 Oct 2023 10:40:08 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id DF97D40262; Tue, 24 Oct 2023 10:40:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698136807; x=1729672807; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=6c3RtAEaHzexI3pCPiYnqgKMosur7yogp2uO2buK948=; b=Ot8Rlmr5ne64LK+vWRMTBYc5fqnBXyux1xxXDIPOEK0ldiDRcQhUnKSg 0IPTtchSoVdyzklENIpB1BHqkWq94qD5WvahTmno/voSv3vG1vqYAyTZP KgRx4SnQOwXKpXFBVn4O2lcqlm5D8bjBBbWzQms+4E3zdS+dRZi+IS9n8 rrDPyzRRNs2Onyg34IjKPhH/R1hi8hOmnq9Oh9S8yyMr5svSvzs+i/h5v uUGONYBKUOI4NljaJPLmsW6cN/QNL9F6LlEAmbDh5wJf1fF8YdHYVrc1T ToIpif2aVK6xaZcz9bqfpjH9/3f6iBMcik2o/Ge4ltXY6lXyrpoYBl0Bs g==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="8563380" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="8563380" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 01:40:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="1089780861" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="1089780861" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Oct 2023 01:40:05 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 24 Oct 2023 01:40:04 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 24 Oct 2023 01:40:04 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 24 Oct 2023 01:40:04 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 24 Oct 2023 01:40:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BhG/yPti+6omtLL2NYEpaQ3gg/YsNt1LlA35u35pU76Vmqt0Djs+1eP4f37WQIjp5U5NlZtAHeUcxD94Uq7F7Nrti2859/ZVIP8jhlJ52VmdqEScLAUYK1pWiGzeWi8ublLuEPhL7dwSpDT48/uJNPQ4BaFBdJquOqZ/6JR0beK0/rxkHcBrMLso54IrLZZrzoDza+C+GCdf4mB/qBMGsQCMBFBf3hGu23WWCSoGs9/Y4NTyzJBSQWgINaf1/Y5r8CMj4/3Qp5hJyGEqE580xOT5rgBuE0thenaqoVomVPjLgDbG0nbfXaNhim9cd0Pmarzi9407PEjiTCImDffXsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BTe14OIj578w+xZFM1jRoZ2fjAhkwO5XulkX+YCGi+A=; b=DWLmEcNSUgxhe+V31kCw8fuDKL7WWAMon27wCKorO8NhmpU06Se/+8OmoIAsW/xe4WBLY8nBkSvAiJ4dhyZBAM7Iz0YQbLLpeYFABcudjb5RXbGbLGTAl1B+Rxke87IHp1CRD1IVbbGeWzG2ViM8U5OuL8v3dne0gkHul8AfhJCH7NqL0q/5XpV6WXmba3T38eErzTCjkT0WUAfQgNLCzebCPyQTTEXc1YOjMrP00roXVDjqxxRihreyEuloNtZ67LZ577NQyZ/4yIF+8hhd+Iuics2HDLkrRQSRN89WVUvD76QVYuzXwyYfytN83SdJh8bCE5OE9f68gN5XAJQs0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by SA1PR11MB8448.namprd11.prod.outlook.com (2603:10b6:806:3a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Tue, 24 Oct 2023 08:40:01 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a%7]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 08:40:01 +0000 Message-ID: Date: Tue, 24 Oct 2023 09:39:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] net/iavf: fix Tx offloading flags check To: "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Marchand, David" References: <20231023163803.98455-1-radu.nicolau@intel.com> Content-Language: en-US From: Radu Nicolau In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0205.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b6::18) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|SA1PR11MB8448:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ee024e9-5cbc-4ad6-1ee2-08dbd46ccfce X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +HWP5SUeK/Js16is0cBehPrmOHszXuHPpOCsa3QOtCxhigTWljswnALMF9CtOTtlpJo5L2osQBDGdfVNNyYY2K3WPXGdi7S7wX/yjwg3GSZdnTEIZfifE2zHmF9BJb1C+oOqqfB4LRMb6/PJVHP74sNUw1UwMxa6ZQ3ofYJQKb3OYAqsN9tdFy7oxkh4t57enp7s905xdVz/omLwy29Mn4cW9qUE16TUE/jOm8UunXef3KHdDDzK5cDI5SskqT6rNCR/ofvuARzxdPIxhpdofqTRKeHgwJoiTY0LZS2WQbrk7TwHXnj3EGoQuL2lk5TYT/Ht6YcXPY1t2cxPL0D/u8CRVyyYBml8RPrLc35wLIeqlascd4mm73ixGp4XYR/yRq6NlAz4d13eSeeIcJ3waybD/OHdKa7PI4aeKb3byJlrXGK4PZU8Jcr1HSHgxw0gj47xnfQ8cVgaVp9eHlfbcZGsJQ9HEhPToy808JEgZVTXHqcP2OvEzATrVehAN2xDbGIPG9lKdyLwRRMrTT3v1mFwHxDunQpgHRt3uy8Mfn9rHaA6n3LjFREQPrO+3OTVeD6WRtcts17wT+C6GFIouEYcGo4Pl1enV4ZTAktNSxa3vKTZmaijHJS+pjGeMoQyHpPMxQR+IpTlvAWc1t0R/g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(376002)(366004)(346002)(136003)(396003)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(8676002)(8936002)(41300700001)(4326008)(2906002)(44832011)(5660300002)(83380400001)(53546011)(6666004)(55236004)(6512007)(6506007)(26005)(31686004)(31696002)(36756003)(86362001)(2616005)(38100700002)(82960400001)(6486002)(478600001)(66946007)(54906003)(316002)(66476007)(66556008)(6636002)(110136005)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3dKaXRwd3k5SHg1OEdZSytYdXBDbmZPWW1ycC93dnNPWkpOOFN4SVdxelRt?= =?utf-8?B?UTBxWERaV2ZuUml3SnltWGUrVUwzQVVlZ0VNalNCdkRXbVpDdjVvSTNURWFo?= =?utf-8?B?d1JkS2JvcnkyZ1BpdjZGeEJ3ejZMOFVZeFZVYnFMVHVobTRiampKbWdlaGlI?= =?utf-8?B?MktRdjJENDhnK0R0ZDRNYmg1UnNLUFU2YVNQaFErRkQ2VWhHeVNLVUVhSjlk?= =?utf-8?B?N1VDY0dRWXdrWkNWVU0zcFBsejZacjZVZzZHc1U0MjBVcDBQQ2dYc0pZZDBC?= =?utf-8?B?UzZoNXhpRUcxWDZzd2N6ci90QmN0ak45TElCZWVOb1ExcmsrZENYb0xnUGxR?= =?utf-8?B?MkFjaHFhYUJuMzZYU3M4ZFVRV3dxbjZLN0FaSGxlelc1T3VFT3ZtT1p1Z0VX?= =?utf-8?B?djRXUGh3REdPNjd6TXlaaXJOdEREVkV6RzMreHFjUXc0OHJVcjAxTWV4clpw?= =?utf-8?B?N0hINVZ2Vk5lRFV6eUZQelgzMXlBQkZpdEdSZlpmOEJaUTR1SzVvdlc0aW5a?= =?utf-8?B?MnhVVDVlb0lidXh6NUs4RUVPa0dILzd6bEY4S1VCQzFqM29IMkc2YklzUmc2?= =?utf-8?B?R2tpczJyRnRlekhaL2xOQkRIWE8vRjNHeFpoVFc0TEQrLzJ2QTNvWmN2Wm16?= =?utf-8?B?aTNUc0d0NlJYN01IT00wYzlNaDNheUFNeTJKS01uYis3dzRRcXM3d1lSZFRV?= =?utf-8?B?QXFMdDBVSXJMa01xWWplL2ZDQlJmS2p0aVAwM1FCWmg1ZXlkdlRvSWR2dFlU?= =?utf-8?B?SE1OSDFqNU05UkRkSjkycDNvRXg3alNzREVMN3gvMGtTZmNKdEd4Um8rcitO?= =?utf-8?B?anZiOUNjZ1JreXJjNFhYbEQxWEJvWk5UQnJWN3dxVTcyUjlyWU04UHNKZndY?= =?utf-8?B?WkowQmcrVkU5bzVJR1hUdnhYZG9BTHFqZWlKUGJueWZIQ2IvV2lXWXlTbFN2?= =?utf-8?B?aVZYUmlJdDRCTnFRbHVPWmRkRzZDaFlObE54YzNFR2V1a1VoMzFJMXJGY0Jw?= =?utf-8?B?cXB1akV6d1dMcVFmZVpYeTVvcE5tckF2VFRmZ0xtRFlrUUd0VDdNQy9neGM3?= =?utf-8?B?bGMycitSbnBvNXNXVUJzNytUa3lOZ1cyU3c3YXpjN3dBMmZic2p2c2x0a3dl?= =?utf-8?B?ZzlobGNVMllQU1hzTHNueUQ0OXI0RU56eVFaMnBqNjl2UGRUemxqbTFCSVdM?= =?utf-8?B?Ykg4a3RrK1J6cjc3WERZMzhTY3YxZFoydFVvZEMxcFhuZkhXQ3RhSklUUks5?= =?utf-8?B?L3Rwcm1GeXgxYTUrdDVFM0UrRk9SK1hWams5eTJzSmp6ajFlRVo0ZFh5bU1G?= =?utf-8?B?SzhweUhJVlBUeWZlNjhReGRSZGg4b1BsT1dESXVJY0NzSFpSM05wWnlmZlpR?= =?utf-8?B?ZEJHczJZRTZ6NkJEaFR4R2Mxc1U0QkY1dzd0RkVzdHFUYmVVcnJjdU96UlNU?= =?utf-8?B?WWlrVTg3S1hxSi9Zendoeis0YWR1R1k0Y3dHQ3FmWnNnQi9XV2NGTUQ1eGht?= =?utf-8?B?WHR3b0FsdzgyM2NMVGk2RUlseGY5b0VadEVOQnE2UTJxbW5SVVFSTFdIbVls?= =?utf-8?B?NENRcUtZTGNZL0VQQ0g4eXZPdzN3ZTFTMnlydk1qODJIQ0NPT0VVMjZpY1VS?= =?utf-8?B?WDQ2M2NldGMwUkFmM1F3T0RUSm5iUHM0cTk2M21WSy9PTnpxSUd2NTJ3eHZE?= =?utf-8?B?QnljWE9ZQ1ZXK2NDWldnN1FONktwMkZuQmtIcW5aYVlDSFAxM05GQ1RrM1pq?= =?utf-8?B?aUR6MUtmOXUxNkJqTVlKTDVBN0xETDlyaHpYaWI1NldSUUtRNE0wNmIvQkNM?= =?utf-8?B?b2RESURyYzRlS2hpUFpDK1V4WUI2STJyQkdxMnhVN0syaUFjcmJoV2NpVmQ0?= =?utf-8?B?TUtiOWxnZkRYRHJXcC83alhJQjFKbzNpMVplMlp3QkFJRTdNZnNrK0hpKzVU?= =?utf-8?B?a1hQU3dqMHhucEVFNUdETE1hNVF6U3g2ZEdpQUtQM1dTeEdGSHlsaVJ0QWps?= =?utf-8?B?U3BJdzRzaGdMR1NzOVphRHpOeW43azVlVFVmaTF1WFNDNldHRXJCWnI3YTFZ?= =?utf-8?B?RGtWL0J4Wk8zcTgxRW14N3BqQzEvNWhEdFppT0NsQU9USnQ4cVBVaURSV0dr?= =?utf-8?B?Vkw2bG5SSnZuVE9hNk5WNXcyMWZjZStQWmM1dVFXbjFnZVJlL0s3UWlVMFhD?= =?utf-8?B?SUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8ee024e9-5cbc-4ad6-1ee2-08dbd46ccfce X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 08:40:01.3561 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 04uMaNwrUBilc3gZpsmmSu0wy7Uc1oCJulqrYh3wXiINlsWPiqc2u+w1fR+i7j/yTTaXWur/HqnY686d9q08yQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8448 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 24-Oct-23 6:42 AM, Zhang, Qi Z wrote: > >> -----Original Message----- >> From: Radu Nicolau >> Sent: Tuesday, October 24, 2023 12:38 AM >> To: Wu, Jingjing ; Xing, Beilei >> Cc: dev@dpdk.org; Nicolau, Radu ; >> stable@dpdk.org; Marchand, David >> Subject: [PATCH] net/iavf: fix Tx offloading flags check >> >> Use IAVF_TX_OFFLOAD_MASK flags instead of >> IAVF_TX_CKSUM_OFFLOAD_MASK. >> >> Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading") >> Cc: stable@dpdk.org >> Cc: david.marchand@redhat.com >> >> Signed-off-by: Radu Nicolau >> --- >> drivers/net/iavf/iavf_rxtx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index >> c6ef6af1d8..85f8c141ce 100644 >> --- a/drivers/net/iavf/iavf_rxtx.c >> +++ b/drivers/net/iavf/iavf_rxtx.c >> @@ -2664,7 +2664,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile >> uint64_t *qw1, >> l2tag1 |= m->vlan_tci; >> } >> >> - if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) == 0) >> + if ((m->ol_flags & IAVF_TX_OFFLOAD_MASK) == 0) > Not sure if this will break previous fix. > Could you please provide some clarification regarding the specific offload flags that not in IAVF_TX_CKSUM_OFFLOAD_MASK, but you still don't want to skip? A specific flag is RTE_ETH_TX_OFFLOAD_SECURITY, and because this is not contained in IAVF_TX_OFFLOAD_MASK the previous fix broke the inline crypto feature. The previous fix was supposed to prevent reading l2_len and l3_len if no Tx offloads has been requested - but there are offloads that can be requested that are not in the IAVF_TX_CKSUM_OFFLOAD_MASK set. > > > >> goto skip_cksum; >> >> /* Set MACLEN */ >> -- >> 2.25.1