From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE8BD43327; Wed, 15 Nov 2023 20:34:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90F93402B7; Wed, 15 Nov 2023 20:34:16 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71]) by mails.dpdk.org (Postfix) with ESMTP id 44F18402B2 for ; Wed, 15 Nov 2023 20:34:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VgHcX2Z71UhJxrOdAeeM1VkEyjjuUEEj6xffE0LYULJRd/5mmzY9kGWemK/56xEvYBuVkPTYxWjc6nkF2TMPgtEHsvomUw5y8aw56H+7yXhP+JGWEhS0fxnMWgZnKstCdGbYc9O7+DpHBCPFjy6vS4r3m5hGUTTy65cX80kKMON/CTgXc66HZhQQq+jEissrPDotaoq8GccpQYCit+fbqPuYpX8UtYjOt9tNZVTW51CPaGtAbW6SUpTWn8lK9SpwxFa9RyXV8ROaXiHQY/WEDHO6ls0Owi3sotos1Dy0gbzI8QbZ4Q2566FHiwa8oFsPzNowrr8j0gLwif1n3q9AKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ew1wwiMwZgH7kva97f+yHVlzcH6dQxvTuKC7PKkWNJM=; b=V8+fqV23cc3A+lVc/Hg6JNJAfDtrc+xqxI/9OxsBscL5DNdASCBfG3LxNoLFHvlEBsr6e7TDLEqcDTipLXQkgm7yDUX5s+tQKMiUgDFrYlydgk+xZ5WdrpFqgljcoq0tCu7tfUDflguAdpDptS2sscPPw5gZHZ9TnT4IITwp7leCAS/M4CCkm4Cr+MTZINazdhQ1nIcN3AEVJFlAhAGiST5o0K2MQPulXDhoORTeB13MFeOkPuwDlJJp1gIu/2Vx5SOVQHvcCGZbxd805coU3nrMxQz+6lBSW1LKcyA+E3OYeu1hj3P953ATqZlF1xCNkpVy87FoELPBeA75KpfQZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ew1wwiMwZgH7kva97f+yHVlzcH6dQxvTuKC7PKkWNJM=; b=vX5/NDCukotOSBA+RqJy6B5SWIYjjkRibhlMpEz3YJ/DKIX0VGPkBtT7zNm36n0+SkB1ioT3mpdNMfVsJH+UqnAcKTog4i5m9S+6nPhuGh0zgwfu2ZvdcOjg87u1l9M3paAqLxndsrdI0Qb9XEFVtpTv9xU8cWwcAGFvYWcNOLY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB8141.namprd12.prod.outlook.com (2603:10b6:806:339::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Wed, 15 Nov 2023 19:34:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7002.015; Wed, 15 Nov 2023 19:34:12 +0000 Message-ID: Date: Wed, 15 Nov 2023 19:33:40 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] net/axgbe: support TSO Implementation Content-Language: en-US To: Jesna K E , dev@dpdk.org Cc: Selwin.Sebastian@amd.com References: <20231111160006.455767-1-jesna.k.e@amd.com> <20231111160006.455767-3-jesna.k.e@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231111160006.455767-3-jesna.k.e@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB8141:EE_ X-MS-Office365-Filtering-Correlation-Id: 1424fdb1-09f7-491c-5ab4-08dbe611d82e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KsJtdND7wvTUBnFVv7HrrRgLLLfwp13zsW2crlsX1onkK5ncb/UH7N9Bi7X8Lt1HQHwhtPH++HOjY0baPfOaQNCCHYLjC8OI/JBqOVGWTA9q15fS46nMEkg5axHmGY4D3T2eTWvw9SIhMr+SpHpQLxFgzLYoT1Kss2uc0C1aPvNAGKhh9LVwkctRN84R6dU45kY//sRaUEvenQ8rkSsEjQEY5MZfJmbi+euTcJON44mIkLokFrXA9fc/Ewo6nwn6hNX20E8883UQPnJ3skv6BCIOVgsNnJTnJTz8CUQDt2VvQFCl3kKKaYyg+MYAM3bAVKb5Ss3vsKLxxFZN2rWID89e58gH+Vw1Nc0uzkqeaZ35Of+OKTDQWzbbL5yXzV8e1AulGh7J3bj4cnLqo7qSjWw485cK9knH1OacPmUAMvznM/uKn0+f1s1LR82dSYWHtSa1tOATtRhpWlwg6Znlj+WA2D/+xxEXg16KM6vVIu6PmDx6RNaCiTMtUZxj9hzUXCXfNpYCbMXU5ejX7B8Y5/3D3yEHY1jtYLhlZOMgBmvRTkeFAGAMfmjMUTBnzcUqrRfEc2aSO/fsMaI4QdsAtkv/ffySkG7HVxMjTwmdYi9Hlxrf1dsOo3arsY5QwpPTwIoPXxBTSvCGsTCVZRV+0Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(396003)(136003)(346002)(376002)(230922051799003)(186009)(451199024)(64100799003)(1800799009)(31686004)(8936002)(4326008)(8676002)(53546011)(6512007)(2906002)(26005)(44832011)(6666004)(6506007)(83380400001)(478600001)(41300700001)(38100700002)(6486002)(316002)(5660300002)(2616005)(86362001)(966005)(66556008)(66476007)(31696002)(36756003)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDQ2cEl6bkN0S0RnVkV1U0VNdzhSeVBaUmMvYlNzMmMyZS8yaFZ3U3U2RHlD?= =?utf-8?B?Q0V0amlONFdGS21SZzZXUEVuVkJJNDZEU1gxSlJ6L21uUGVIUmtEcUhUR3Fy?= =?utf-8?B?OFJIWTNIalBzU2NjUkRIcC9FVW1DMEJkU1dWQS8xcXdKT0l1ZDR3ek9WRVJa?= =?utf-8?B?d09lZi91YmNJdVZQWDhYUXZTNGo1dVEyMVVBelBLL0ZuU2RKYitVYjM0Tkh0?= =?utf-8?B?cXpBWXNMSEp4QlpmOXMzazMvcURjeThiUXlSS1ZuSHpGMVkweUw5S1kxWWcx?= =?utf-8?B?YkpkcHhrOE5Jd1BkS1JwdVkwRDZoVVhrM1VHVUZTTUQxRmJ0Mzg5K1g4UDVG?= =?utf-8?B?RXZEUmx3a21id0FPNE8rTzFFNUlRMnQrckE3aGxLSVAxWENtTys0eGg4NjJv?= =?utf-8?B?cCtaRXRBVGlrMVZWNm9LVlI1Qk12UnU4WmVUTnhTbkhtWWliYW1nN2pVYTJu?= =?utf-8?B?aGNxdmNCemhLZFZySXZZSXpXdmZ2SysyamVjTmtuUUY2RjJVdE1DRHFuK1JG?= =?utf-8?B?eVRpYzVIWWpWZmpCSUdITlN0SHJmT0Jubks4TlZIajI5dUpKdnpQQXBCc2FP?= =?utf-8?B?dThzeFYxTXZqR3RlT056WFJ2K2RTL1lqOFcvRTloRnNmTVFYQ1cwWjd0UW9W?= =?utf-8?B?dTRMbHY0LzNYNnA3WGdHMTE1V0swdU9aRVpwMkMwQzNTTnlPNjc3ZkVEVm8y?= =?utf-8?B?QmJGN0s4K2VNcTJEV2dzRzhiRVQyaTVFVnpIQnhObVRWT2xaR2lRUCtaeGNh?= =?utf-8?B?UGx1eXgyWlJYaTFZZUt4Qm1pWlNROTZlMW03eW80NmxUeGlRNGY4VGdCcWk4?= =?utf-8?B?bG14cHhSUWtBN3NjREQ1TUE5SU13U3pSSjVOdHY4UXIvQjhZZHhqS25zWlNx?= =?utf-8?B?bUtGbDBWL2tDQjdpdWJvdEpERlgyM1VoZWNkK0hpVW1tY3MyUkkxc3AwV0JC?= =?utf-8?B?T2Z3bjJSNk9kRUVxOTdYSEdLSXcxTHJidkNGaUd6YkgyTE42cUVNbjVpRC91?= =?utf-8?B?TWxTQmkxTWlZZXgvQ0NqQ0N4MFJLeEpkckFuQmJsL1FmRE4rSlN6ODdqbkRo?= =?utf-8?B?Y3kwRDhWUmNZNnJyaEdGdXRJVG5RbUxyOEJWeERkcTBlRitweTNUM2VVMkZK?= =?utf-8?B?c1NoYUtJT29GRkVZbHdYaGIrN0pZWFVpeVlyN1g1RGRlUTNZeDdsby9PYTRL?= =?utf-8?B?YUE0Z2RoS3dyTU5KbGxSOFEvRVFYb0d1WVhyTWJ1UlJUVmYrTUdTeHEvMDRP?= =?utf-8?B?cUF1cHpNNTl1UUFDc1lSUi9IVVBRcXZtcHI0SXlTamRFMXBHYnNTcmxua0Q3?= =?utf-8?B?amZtaFA1eXdTdjlBdFU0WHV0NU9mUzY2d1NEM3J6VjhPdGtieXlYSG9yUkNF?= =?utf-8?B?SXdDbFVZZmNieXB2T0t5TFFYcjdtRkFvMEJEV2RmUnl5T091RUlCbTBFWmEw?= =?utf-8?B?NTkreXBRWWV6Z3hzMm41MUR1ZG1WOXZ3MGhHd2tGd3FOUUVlODNMVDFZdjBR?= =?utf-8?B?MFJ2K0M4REE1Q29vMXRROGl3RlhtUlNQdUtVbjcvZTB0dHhMTTFpSGJLeWpC?= =?utf-8?B?ejVDa2ZJNGliRzgzdzFOTzN2bEwzSXRJM3RxZnV5OVV4ZkV2SHViNGpoTkd0?= =?utf-8?B?K2hON0k0cnhNbDRpcnBPOWNlQm03RzFJZHBnUUNiN2F2MHFmbXJjUkxhbWhZ?= =?utf-8?B?dGdYUlZBWWF4YnAzYTlRUFlCNHlTOHdhc3BSVUVwRHg3d3l0dVlpeHJoNnJt?= =?utf-8?B?NGt2MmZWa3pMUHFQL1FKS1lBU2xNV0YvWHg4M2lxNnIwbHV2VjJEL1E4bXdK?= =?utf-8?B?aGR0aDdXQVQ0bFV1MkE3YlhYSEh5YjBINWpMZFplc0FaM2hFdjVKZFl2ZkxE?= =?utf-8?B?SlJWSWFvaTZsQnRKOTVNaCtXVVhlb3RCYU9hclBRVUZpcFVZY0p1RC9Va0pj?= =?utf-8?B?QUhqUDN1S3ZnZ2pxZnQ4M0Y2YUhPN1pqK1JTVWNHWHAwZXFsSGtXOGlBK3pG?= =?utf-8?B?T0JNNFNXc1BORnRTdHhXU3J5Y042K2pwU3F1cEdtdlZOdStLWDBaVTdsbzE2?= =?utf-8?B?TWRwUllTbUpTOGg4SGJSRFRBQk53M2xTN3VtK2JYM0N0NzN1R1ROaVJwQSsy?= =?utf-8?Q?oBK4=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1424fdb1-09f7-491c-5ab4-08dbe611d82e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 19:34:12.1349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: drYzMUwqgAVrHzQy1DaoLuFGd6bdCEdUmqIoR6nHYYc+9EFFsvj7RDlSYCD7+79C X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8141 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/11/2023 4:00 PM, Jesna K E wrote: > Signed-off-by: Jesna K E > Hi Jesna, There are some reported build errors [1], can you please check them? Also please provide some commit log, event it is brief. [1] https://mails.dpdk.org/archives/test-report/2023-November/508540.html > --- > drivers/net/axgbe/axgbe_common.h | 11 + > drivers/net/axgbe/axgbe_dev.c | 19 ++ > drivers/net/axgbe/axgbe_ethdev.c | 1 + > drivers/net/axgbe/axgbe_ethdev.h | 1 + > drivers/net/axgbe/axgbe_rxtx.c | 305 +++++++++++++++---------- > drivers/net/axgbe/axgbe_rxtx_vec_sse.c | 1 + > 6 files changed, 223 insertions(+), 115 deletions(-) > 'doc/guides/nics/features/axgbe.ini' needs to be updated > diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_common.h > index a5d11c5832..1face6f361 100644 > --- a/drivers/net/axgbe/axgbe_common.h > +++ b/drivers/net/axgbe/axgbe_common.h > @@ -162,6 +162,9 @@ > #define DMA_CH_SR 0x60 > > /* DMA channel register entry bit positions and sizes */ > +//TSO > Please prefer /* */ comments > +#define DMA_CH_CR_MSS_INDEX 0 > +#define DMA_CH_CR_MSS_WIDTH 14 > #define DMA_CH_CR_PBLX8_INDEX 16 > #define DMA_CH_CR_PBLX8_WIDTH 1 > #define DMA_CH_CR_SPH_INDEX 24 > @@ -1232,6 +1235,14 @@ > #define TX_CONTEXT_DESC3_VT_INDEX 0 > #define TX_CONTEXT_DESC3_VT_WIDTH 16 > > +//TSO > +#define TX_NORMAL_DESC3_TPL_INDEX 0 > +#define TX_NORMAL_DESC3_TPL_WIDTH 18 > +#define TX_NORMAL_DESC3_THL_INDEX 19 > +#define TX_NORMAL_DESC3_THL_WIDTH 4 > +#define TX_CONTEXT_DESC3_OSTC_INDEX 27 > +#define TX_CONTEXT_DESC3_OSTC_WIDTH 1 > + > #define TX_NORMAL_DESC2_HL_B1L_INDEX 0 > #define TX_NORMAL_DESC2_HL_B1L_WIDTH 14 > #define TX_NORMAL_DESC2_IC_INDEX 31 > diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c > index 6a7fddffca..7e0d387fc3 100644 > --- a/drivers/net/axgbe/axgbe_dev.c > +++ b/drivers/net/axgbe/axgbe_dev.c > @@ -808,6 +808,24 @@ int axgbe_write_rss_lookup_table(struct axgbe_port *pdata) > return 0; > } > > + > here adds extra empty line <...> > @@ -843,7 +847,7 @@ static int axgbe_xmit_hw(struct axgbe_tx_queue *txq, > > idx = AXGBE_GET_DESC_IDX(txq, txq->cur); > desc = &txq->desc[idx]; > - > + printf("tso::Inside axgbe_xmit_hw \n"); > We are not allowed to use 'printf' for logging, but need to use logging macros. There are other instances of 'printf' usage in this patch. <...> > + } else { > + /* Enable CRC and Pad Insertion */ > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, CPC, 0); > + /* Total msg length to transmit */ > + AXGMAC_SET_BITS_LE(desc->desc3, TX_NORMAL_DESC3, FL, > + mbuf->pkt_len); > + } > +#if 0 > Please remove unused code for upstreaming.